From nobody Sun Oct 20 15:12:43 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XWhl042wPz5ZPv6 for ; Sun, 20 Oct 2024 15:12:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XWhl01wVbz43LP for ; Sun, 20 Oct 2024 15:12:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729437164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2T4a73IO/p7rU/3mSKqn/7MUVvaijDxE6Y56ox6ft8=; b=qo5Yp6qBUS3EsPe7BGXWBThDVu49CSSw6u22J8HPyuUkvuIN+gWtrCc5tzN+LAZYqAURx1 gNnqQeSWJhFX+yguPMlf6tnhZre5ZD+7A3BO2ZY/iDPZdWT9scAwonYWYo20DXRIoFBMRC NzFcJqcG5IVf9sgTrqaxkSv10rNmompDADWB9W0dYyibV3UULkaDZMLoKdcHRXeHskCWBW vIdZXfvON1OmlZWUIb/UlQpGFL7ChiMQFeqGt2+Iab+PESncvvAv/+tGtNoIMCqWfEVdQ3 aFS91q8ZOZh+oP+lmp+4LrKWTc/oYE7ksY35icn5W1+xWdxoBEVHFISyjyBH6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729437164; a=rsa-sha256; cv=none; b=bXiZjI1G0J54s5M93xqmyKTS8rPmOExGQGQvxZJm02IxBkzLtEETcLVbdSiS7qqbKcKLfd aKr1w8CUJ7+ocD4RJG+zivF2jDgiv0Pmj7tikMNs4bPG2gkxZkmaqGiMB8+9vYavB+TvPZ NJu7A+ThqPhDWwxu6BGBNXkPW4WN5kcrZvFazTV1gImiyP4VhkU/mNvxqexRlG6c7VQb1r EvTLWQBj2G8ElA5gP3aBY/ZvkpLd1f1agS/RCQgnrRQkGjE0j2uD/HfzAvOlfxsSBySBn9 j8ypI5EHqJXsfu6f3qCA0JDEE9NKSnqQg5M8/96tSGGInlc8fQ7G1UUjL8Gq+g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XWhl01XBfz15lj for ; Sun, 20 Oct 2024 15:12:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49KFCiNi011900 for ; Sun, 20 Oct 2024 15:12:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49KFCiR4011899 for fs@FreeBSD.org; Sun, 20 Oct 2024 15:12:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 282169] zfs rename deadlock with mountd, df & fstat (and possibly others) Date: Sun, 20 Oct 2024 15:12:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.4-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282169 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org Status|New |Open --- Comment #1 from Mark Johnston --- Many threads are blocked on the ZFS "teardown" lock. I guess a writer holds the lock, or a reader leaked one. I looked through uses of ZFS_ENTER and couldn't find any leaks. I'm confused by the locking in zfsvfs_teardown(). That function unconditionally acquires the teardown write lock, but there exist cases lat= er in the function where it won't be released. Specifically, if `!unmounting = && !zfsvfs->z_unmounted && zfsvfs->z_ops !=3D NULL` is true, the write lock se= ems to be leaked. I'm not sure if that condition is possible in practice, but it looks rather odd. That code path could potentially be triggered by zfs_suspend_fs(), which is invoked by a couple of dataset operations, rollback and recv specifically, = but as far as I can see renaming a dataset won't trigger suspension. --=20 You are receiving this mail because: You are the assignee for the bug.=