From nobody Mon Apr 08 18:22:18 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VCy9l05X2z5HTZj for ; Mon, 8 Apr 2024 18:22:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VCy9k6834z4bnN for ; Mon, 8 Apr 2024 18:22:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712600538; a=rsa-sha256; cv=none; b=E+8r9ves1/ID5o2koSGIOUossr6r1o3aAv6mRtgv/uLTaGu2kPL0Oa1DkV6Nfykvgf3Fp6 ZdF18xG2xawJ+W3oltL9puzQmxk8D6msJr9qYEY0yHPcTtkeBza0xUXt8GBILoZZQLciP7 krRHcoDOBrV7MYuwLF4zTTgPTKIioHsuOsGCY1v53UYBsWoA2zc09nhfOJxr+5/swD26Sp HmKvdw4HR4gW0zDJFt6toLSFQgMHvSaJwvvGPyD5rYcAbYq64DNlF53Dn7C1LKMwh4hIKp nSFwa4QQromc/2OHqYp9Cl8XSQleum6ZFFdPngOynDaX9ITkYBBR00468M3TRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712600538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft0Co2VYFSUFjqGawnsfC44mSSqHiJ+QY3DzULBxQm8=; b=n5UtiaqSsBtxi+raVjQzAXtE0UlWxEU1Y5eNNeH/Zyat42bhIVO/eEs5jszGY4tdl4CJxq qvDrQXmKAv/cSNTp+LS1ymidVhH1X9c7eWOIhCmTfUlSI3I+HdL/s+941B34m6Y4OU1Bmt IYNhurf7xJ9x8876Sc2LRMgnn9I0RvUrz91GHfvYIejmTegmLvOVntW2pxN69r/LbZZ1Zr tjQfp5zT3icx7Ebkmt786QJ6pOYznwXRgclrFEsgvGP9Rm0p+JGlBPYLlpVatAFPddUrJf fqq9cYabJZM+yR8DI1+rXZuyhMGCTkT4L2vNq1Ka0HKcEsDyIjApfgKaLNxJyw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VCy9k5lqbzLsF for ; Mon, 8 Apr 2024 18:22:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 438IMIcI048755 for ; Mon, 8 Apr 2024 18:22:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 438IMIEb048754 for fs@FreeBSD.org; Mon, 8 Apr 2024 18:22:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 270089] mpr: panic in mpr_complete_command during zpool import Date: Mon, 08 Apr 2024 18:22:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: imp@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270089 --- Comment #19 from Warner Losh --- A few problems with your ncq trim theory. (1) scsi_da doesn't implement ncq trim at all. Until mpi3mr was imported, t= here was nothing in the tree that could create the necessary ATA command with the extra registers apart from ahci (which uses ata_da). (2) mpr can't possibly send ncq trims if da were generating them and (3) import is a read intensive operation, so is not doing trims and will do minimal writes. As an aside: We likely should just assume the 4k quirk always. That would eliminate 90% of the quirks we have if we also stop doing READ6/WRITE6 comm= ands entirely (they are a compat hack for SASI and READ10 was in SCSI1, though n= ot universally working, SCSI1 drives are not relevant today, certainly not ultra-low capacity ones that were quirky at the time). But that's a differe= nt issue. But that's not the main issue here. I fixed a lot of 'state machine' bugs, which this panic as, and Scott Long fixed even more before I did. Those changes should have been pushed upstream several years prior to the uname date in this bug report. Since this is on = an ARM server, there may be something subtle there due to arm's weaker memory model than amd64 that's causing this. My testing of mpr on aarch64 has been light since we don't use it at $WORK and my aarch64 chassis that I have don= 't have slots for hard drives... So I've just done bench testing to see that I= Can see the disk and do some I/O, but not much beyond that. And of late it's not feasible to redo that bench testing due to changes in the amount of junk I = have on my bench. Out of curiosity: is this a zpool import from a pool that was created on another system? Or was it working fine and then this started happening after some upgrade. mpr and mps both share a common history, including the state tracking code,= so it's not super surprising that this is being hit on both. --=20 You are receiving this mail because: You are the assignee for the bug.=