From nobody Thu Sep 21 20:53:51 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rs70w6njxz4tykT for ; Thu, 21 Sep 2023 20:53:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rs70w5HvDz3ZL4 for ; Thu, 21 Sep 2023 20:53:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695329632; a=rsa-sha256; cv=none; b=WVH4sQ5/QtPeg7DcHlIOB//PDyI1wsSZ92qiGyPpoJ3AfdV9N63SPH+487tKg/Qy16W20J a9MaKuO5LbzMTwbEwlDhVFdV5+wdjuozsVqrbh7sT0jvA8VxajOB8dM4XcRcRYCtbZXNws gBL/IKxR0OcWxO2vcFSXVDCbL3QUtKmL5M2cPsIzqyPlauP4iwIrsB17fPUxd/J0K39v8y j+vBkF55yZ4kPfHSbiYWkqWCxeAxN1wSR5b5y/N+h9NG7llb+4WfPf2mCUI9CGCOzbt1L+ j7WrvuDxxY8btyHgHMNj1qF1Jq1XDof0b90NMkx1s+aMFFm0JzcqvjqIDCNtKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695329632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpwsCuLSn+fhiYIhI9kw03aLW6ts9fbQu5QUACOleEs=; b=qnROVMpy0bIbRNrN6dorRKINgM6i5s4DkRfBAcRAIFJHSbzHSf7JDqRuuTEBZi+tJRSp03 wheQAugMu6rmBp+2vd07dL/UVELeHy0t3YmHZBYlak2XnCN+6G/FOyARpVRjGHxpUNP6kU xbtJ2hL+81KFOMe3dzsDna6yEzLV6Ej4RZQr+i1TtSqIrzRE4W7QIiV39aNQtPsn0dJiYH IpxCemZluI4kKHh5eNY0HtsFm4iol+grybdXtM8fybbCJnQ5s4+K/NMoaa54Z/2wHfeTNB NfQILbbuOLDSO6GPa5XLRSq6E50AKIavG+zODLoxI4UxmTQFUwbQgOgzVWHZZQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rs70w4Lk3ztTB for ; Thu, 21 Sep 2023 20:53:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38LKrqNt037451 for ; Thu, 21 Sep 2023 20:53:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38LKrqou037449 for fs@FreeBSD.org; Thu, 21 Sep 2023 20:53:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 273663] zfsd crashes in the presence of pools with removed TLVs Date: Thu, 21 Sep 2023 20:53:51 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: asomers@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable14? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273663 --- Comment #11 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Da39aac5bb8e46b0d9cd77e85be8a65808= f8a89ce commit a39aac5bb8e46b0d9cd77e85be8a65808f8a89ce Author: Alan Somers AuthorDate: 2023-09-12 01:20:39 +0000 Commit: Alan Somers CommitDate: 2023-09-21 20:39:52 +0000 Fix zfsd with the device_removal pool feature. Previously zfsd would crash in the presence of a pool with a top-level-vdev that had previously been removed. The crash happened because the configuration nvlist of such a TLV contains an empty ZPOOL_CONFIG_CHILDREN array, which led to a pop_front from an empty list, which has undefined behavior. The crash only happened in stable/14 and later, probably do to differences in libcxx, but the change should be MFCed anyway. PR: 273663 Reported by: Marek Zarychta Sponsored by: Axcient Reviewed by: mav Differential Revision: https://reviews.freebsd.org/D41818 (cherry picked from commit 0b294a386d34f6584848ed52407687df7ae59861) cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc | 37 +++++++++++++++++++++++++++= ++++ cddl/usr.sbin/zfsd/vdev_iterator.cc | 5 +---- 2 files changed, 38 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=