From nobody Sun May 28 00:13:49 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QTJzf0BVWz4X1tx for ; Sun, 28 May 2023 00:13:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QTJzd5980z47Y7 for ; Sun, 28 May 2023 00:13:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685232829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4C02AVvrUKOktORY4rqWuVETlgKAuin1EdVU2/6uwvc=; b=YkOTDONQ+Boh5cxnBgakobntqc0UuO4DOGApaR+Ca5AZrjMqIJWurnLtzqstD+4U/8THzk VTQ8z9YMuwYNzCGv3dZRA1puopz5fi5Gb87QWARNJCYDp1Rb3ut/mbnPYFEgMX5vN6qiaG dQhIRXbfaSFnLGBXCFGTlu6kGtszb4GOaMSaOprtD+z+qHCPXGwPqndHxeeTf7VHjtUUOG p3XirwpJJhBkkXy5Jkvkm+keJqKcDXQ1JFEUr3JkUNJVl161Bfv0r+A4/62EVNMhjsL5sD oHKeAQod+ou7c60mpo+kEIQNSbjSLFz9DrgXr7cgZWAgdBhmZLlq2MvJpn8I0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685232829; a=rsa-sha256; cv=none; b=ihmES3CWckuhv2tCaZsEnvanKTKgfgStrSM7r1nGWnzEI3ov6AacQIAWFICE8dEK2J0HgP 0o2m2rZ3im9YVEUnmkzJtkWhUvur/+tvnJlpaJAWtKVD4tOmvIqb7cvJ5cjBntvkW3zGHe dpZ3ZzS4AQWq6XnEw2cMdsWEfPLY8VH7XXhRvZhy15RRy/sn7omLi7nSuCss+dvHKJcptM 3QIlauGLNn9Wdnmvwh+hGAXbgVYDmsE056YiGbAQpQLeWzyjHnSich9e8PfDNVpiQGdcFf nRQDSnnNBd1GiP09byfrl770rofB87l6PipSvFKxp3OQ8Gs7RQe3UjXqekRwoA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QTJzd4GCsz17mR for ; Sun, 28 May 2023 00:13:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34S0DnOA010056 for ; Sun, 28 May 2023 00:13:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34S0DnUq010055 for fs@FreeBSD.org; Sun, 28 May 2023 00:13:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 271378] negative jt_size in ffs truncate journal record causes fsck to crash Date: Sun, 28 May 2023 00:13:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271378 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D101a9ac07128a17d8797cc3e93978d2cf= a457e99 commit 101a9ac07128a17d8797cc3e93978d2cfa457e99 Author: Kirk McKusick AuthorDate: 2023-05-28 00:09:02 +0000 Commit: Kirk McKusick CommitDate: 2023-05-28 00:12:30 +0000 Fix a bug in fsck_ffs(8) triggered by corrupted filesystems. Check for valid file size before processing journal entries for it. Done by extracting the file size check from pass1.c into chkfilesize() then using it in the journal code in suj.c Reported-by: Robert Morris PR: 271378 MFC-after: 1 week Sponsored-by: The FreeBSD Foundation sbin/fsck_ffs/fsck.h | 1 + sbin/fsck_ffs/fsutil.c | 25 +++++++++++++++++++++++++ sbin/fsck_ffs/pass1.c | 12 +----------- sbin/fsck_ffs/suj.c | 3 +++ 4 files changed, 30 insertions(+), 11 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=