From nobody Sat May 27 23:08:35 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QTHXN1p5Xz4Ww7n for ; Sat, 27 May 2023 23:08:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QTHXN0XSNz3Jk0 for ; Sat, 27 May 2023 23:08:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685228916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZuAWU0/QZofOq0U+VS6BBCu8vyZPD79uFXoVNpspV4=; b=QIX/wT0dE/x7frOLNUxh6ycRjfZUTvQ9swEQ0Kl51k/p053k5WloVEhA17mYM6R5tbcLMu /zgxKuZe+fGRkfAULFHAsRP4ImGB6Kbbq1hlhq1adlkpzOeYIN4MZsbaw6o5JV0b/M2DZz 58IY+u5lMDRYqC8AUJ6s12L6tcOYvssfq54PpHd1JCp/pDBHX5aIeJWaFvoARPPUp837lX PpvjgFXs4oLbMgQRWNQaZEXRKPYU1W/9Tpz7HzZgVSL53WrsMEnTChgiYrwpSI9dNHYlzb Buw8TuwHjNkTCs1m0Egw27c0UuAJAf10MQEZHwAuQvuIwT4EtVDZgMO99ypUDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685228916; a=rsa-sha256; cv=none; b=W/bVRWAvjTkCLXwQvUDnoHUFdkVI0xJmy5KXCxp4Swi94xnxhDbAqc+qwCUKkGjfgjppRj cZR2MOVQEV/u0danqS5Nx3Hq0DbJvuiUQJITB9VOwhTd4aEBOAPWCNNTYJpzgvJAKABXUN PE7N9bZMb4D5umydpg+15GC0tT9XSxlHvcDfkfeqjdbs2qUkZGw5F3uM6wSHBg00YE6C9n 9L6SKTLfF7vsXga7qgBUECz1RhXsThboBFzd5ztCWafmPQc+VdiTILsblDfW9yKSclGOtK IAeBAle92ar1bLV257RxqdksinLwAAHgx0VN2bAmpsF1s+6mqOiHNFe5AeD2IQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QTHXM6fF0z16KZ for ; Sat, 27 May 2023 23:08:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34RN8ZcI003044 for ; Sat, 27 May 2023 23:08:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34RN8Zga003043 for fs@FreeBSD.org; Sat, 27 May 2023 23:08:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 271312] inum > maxino should probably be inum >= maxino in fsck_ffs Date: Sat, 27 May 2023 23:08:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271312 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D11ce203e0535c1c8f520c9bda81ab9326= cf5db80 commit 11ce203e0535c1c8f520c9bda81ab9326cf5db80 Author: Kirk McKusick AuthorDate: 2023-05-27 23:07:09 +0000 Commit: Kirk McKusick CommitDate: 2023-05-27 23:07:09 +0000 Fix a bug in fsck_ffs(8) triggered by corrupted filesystems. The last valid inode in the filesystem is maxino - 1, not maxino. Thus validity checks should ino < maxino, not ino <=3D maxino. Reported-by: Robert Morris PR: 271312 MFC-after: 1 week Sponsored-by: The FreeBSD Foundation sbin/fsck_ffs/dir.c | 4 ++-- sbin/fsck_ffs/fsutil.c | 2 +- sbin/fsck_ffs/inode.c | 14 ++++++++------ sbin/fsck_ffs/pass2.c | 4 ++-- 4 files changed, 13 insertions(+), 11 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=