From nobody Wed Mar 29 09:38:11 2023 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PmhLy3z5Zz42JSq for ; Wed, 29 Mar 2023 09:38:34 +0000 (UTC) (envelope-from woodsb02@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PmhLy3Fq4z3v9f; Wed, 29 Mar 2023 09:38:34 +0000 (UTC) (envelope-from woodsb02@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680082714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jo75x3lAOHNM7psaRMWMmkWuorTc6JmBziSFGtQ8fMo=; b=GwpHr/+tSos9xeFQB12uwd/SblMx68AXEzMPK/lGVZyiPCROS5VIlubLN5jY0w+pqf9p1u SYRTz11kSHX47VYrj7mYqst2JClLST00IShovgnga7520W3TYgwg3STLMEADKikcbn1a0f ZHsP2zOvyOl9kGy1GH2YSyamWMTA4jOg19/eLJRY/74OHCUpdeQdYlyjEgzx8CgDA+XWVu SE4Gb2j+y4EzDqUo6tFdwt9PiV3pTKKNwTO5Nz8Eq1xI67rIn323EE3X14Tv61y6mUp2aE mDduEM1WwnnPT0/ism5sfPW/9LbO3e5l+mDC8tk6uX8+/DoVfSxvIQt6ZohVhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680082714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jo75x3lAOHNM7psaRMWMmkWuorTc6JmBziSFGtQ8fMo=; b=fGXSPwahzOD/Vte0Oay+QJ42MeUvtBMUdwqy0L7VQ75Lzfyc6ChnJ2y4pjjKHoSVMcjEDN eDW8YGt1kO/qjgKXWaY6rlNJFwX88FNwGiPWFZqgxv0ZIXNGkpdgx/USAo/xOvSCp/tzUs OBExZwFVRsFdmyLbGM2f9pXMCIGjQTMwMk+pbe5YxMafRHLEE9Ph48lS5u10NuNNWuXw/e 8JQh51imDTaW/rdGB1mbhE/7VY46jBTROAZTrZR4DVIVvSYtTxsa6ew9KfVSxtJj7HrRkh PlubwmiZgL0DMvJRk79YuSpj4V33PXgQJfXT6UYWTu4jn7sNbsZdb3lUYVYwAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680082714; a=rsa-sha256; cv=none; b=RRNUszLtsBf0rGrVxdnTcMN7uj0MaLbhU6eOCOxpQ/OGWzDtN/nR2oK+Yjp4t/8d0b/QaR nQ1l/EKFX+Dp0dO4tWOJn51u3RZow0amr/mB9QzD2GLl5Gwy+Nnj4T6qUtBb5l3KZS2dXP pqfo0LfxFEfBEWe3x70CUBLD6Mwjeq3fhprieQHXvgojrFdJo/n1rd4VGw6+kXVeO0B7Kz urd4S8l3AowI8c6ZsP1Aa8IU/vjq8o638rvb4ZglbpgyaoiUzQ7czpEXyheUBwLR6UDmIU 3X9vnQOLTBVTaHWhjh+z1xY/SsJSveThPPpcU4AvqI/tES4tVUxp+dq1Z8Uo9w== Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: woodsb02) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PmhLy25Tlz1400; Wed, 29 Mar 2023 09:38:34 +0000 (UTC) (envelope-from woodsb02@freebsd.org) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailauth.nyi.internal (Postfix) with ESMTP id 588C527C0054; Wed, 29 Mar 2023 05:38:33 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute1.internal (MEProxy); Wed, 29 Mar 2023 05:38:33 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehiedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfuegv nhcuhghoohgushdfuceofihoohgushgstddvsehfrhgvvggsshgurdhorhhgqeenucggtf frrghtthgvrhhnpeeludejgefhfeevfedutdfgfeffudevheeujeelieeuudejjedvheej teehvefhieenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsvghnodhmvghsmhhtphgruhht hhhpvghrshhonhgrlhhithihqddutdelfeeiiedvkeekqddvgeejkedvvdektddqfihooh gushgstddvpeepfhhrvggvsghsugdrohhrghesfihoohgushdrrghm X-ME-Proxy: Feedback-ID: if9c9472a:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id D6C2A2A20096; Wed, 29 Mar 2023 05:38:32 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-237-g62623e8e3f-fm-20230327.001-g62623e8e List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org Mime-Version: 1.0 Message-Id: <160ca907-c39a-40dc-9715-7ac3520ef00e@app.fastmail.com> In-Reply-To: <25c778f5-f477-5cd1-9a5c-9c02a20dbe56@FreeBSD.org> References: <202303081948.328Jm50O078295@chez.mckusick.com> <25c778f5-f477-5cd1-9a5c-9c02a20dbe56@FreeBSD.org> Date: Wed, 29 Mar 2023 17:38:11 +0800 From: "Ben Woods" To: "Stefan Esser" , "Kirk McKusick" Cc: freebsd-fs@freebsd.org Subject: Re: FAT32 statfs(2) inode usage Content-Type: text/plain X-ThisMailContainsUnwantedMimeParts: N On Thu, 9 Mar 2023, at 3:53 PM, Stefan Esser wrote: > Am 08.03.23 um 20:48 schrieb Kirk McKusi>> Date: Wed, 8 Mar 2023 17:40:34 +0100 >>> From: Stefan Esser >>> Subject: Re: FAT32 statfs(2) inode usage >>> To: Ben Woods >>> Cc: freebsd-fs@freebsd.org >>> >>> Hi Ben, >>> >>> I have created a patch that has been tested with both FAT12 and FAT16 >>> and which has passed all my tests with different file system parameters >>> (e.g. number of root directory entries) and all operations (create, >>> rename and delete files and directories with DOS-8.3 or Win95 names). >>> >>> Could you please create a PR that describes the issue you had (wrong >>> report of no free inodes on a FAT16 file system) and assign it to me? >>> >>> I'll reference the PR in the review I'm going to create and hope that >>> this will help get the issue reviewed and the patch set approved ... >>> >>> Best regards, STefan >> >> Stefan, >> >> I will provide a review for you. Just add me as a reviewer when you >> create the review. >> >> Kirk McKusick > > Hi Kirk, > > thanks, I have already created a review: > > https://reviews.freebsd.org/D38987 > > I'm not happy with the choice of function names for the increment/decrement > macros, and I think that the exact location of their invocation should be > reviewed with regard to error cases. > > Best regards, STefan Hi Stefan, Thanks very much for your work on this, and for committing it today. I owe you a few beers at a conference some time! https://cgit.freebsd.org/src/commit/?id=c33db74b5323480fba7adef58e8aa88f6091d134 Cheers, Ben -- From: Ben Woods woodsb02@freebsd.org