From nobody Thu Mar 09 07:53:12 2023 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PXLyh5Jwvz3wKlh for ; Thu, 9 Mar 2023 07:53:16 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PXLyh4Z58z4Dl8; Thu, 9 Mar 2023 07:53:16 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678348396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mWvTTEDiAJLkKNOkgeemq9+7ZKwuSJh3+rX566D71iw=; b=d9K5nX0TOa9J/sAbaCuCXPdWeGxK/tePXdG015Zz+aRoyHPN7TLWH7BGOqdMH1V0ivSnjR yFRUNUQZjMcY8MySRoYsNquwc/rtQK9FAJMu5dqVpA5bjpjS0M4c/GVgwgBd6ZxQ196cPl wmRFJYl4gHmWeY5/w30VxsfmqqM1vHvPRhVELE56/9xMZUXFqTm7d1pkVpLJPVxQad8aXm 57X2L6tAGiE5TtaIvLIbNv4gbieAlPOrKSS47nX0VD/VRpFauPQxKkccw06bg0lTMuEUVz 51vyRUMpjBdt7+lLcX5eFcHciLWN5GAdnGZF1sZZYy+wnPfJTqsrPm9DIDeNtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678348396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mWvTTEDiAJLkKNOkgeemq9+7ZKwuSJh3+rX566D71iw=; b=TucbUwoFKmn3HEKKm2xftx6bxJlFVHLe145nazliuAl7DO/L7vOOdEc5VcRaobr8U+99Dm tCaNnR/o+j0Mm7g9ysP6sbB5RRhLGU0WvJru4db8G443+3Wq+hueJAlPXB+Ho2ZJH3cUsq CK5IQqsUUj1T5nAmTV5ARir0kp6gxPwW/jpDN0hNcOegFRa3A622PG5g6TXGJ6CpAi2fOb TkS9EM7LH2e0WDpFoUlzKS7Slo2CP8MrUJhQgaC9cRX4aQAP2tV9abcykWBFpUdzabPUCb FNcpkelKnJ9N5on7wwzdOESf+xUBPGyQ9VRvuoR57Q4iEx3cugKr5o+aIDUt1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678348396; a=rsa-sha256; cv=none; b=us03B2dUfLwJcXgrlEWEXZYK67u2NumYBpN5DGU2wMuA6g/ybf4UDwWo2LTz8x6OaBRX6a aaqAYYTjjPqsa4yjlEue+HRc8ApQNfQibfC1klyCneS7tZVIkEgroOVPCHmL1QZ+kpIF8+ cm2zkPc01SafvobxP1gQgWHN3BADN/ryoWVA26gFXd6Rf1lV6g1C6CjFVcks1rtRXO5T8u 9TlakRRhCfZoSarY2f0n4v7E4MqvJ34dQaTkWuXSFt5jMvKffmxMF/Urr5L2bNIC8RLhhK ubH/GL96WK918ULxsMCNMr6VudpeNt4K15VxYVnrg61tPloBiL3J2b8AeY40gg== Received: from [IPV6:2003:cd:5f1a:a300:98c1:724b:10d7:e55c] (p200300cd5f1aa30098c1724b10d7e55c.dip0.t-ipconnect.de [IPv6:2003:cd:5f1a:a300:98c1:724b:10d7:e55c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PXLyg6tyJzPmv; Thu, 9 Mar 2023 07:53:15 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: <25c778f5-f477-5cd1-9a5c-9c02a20dbe56@FreeBSD.org> Date: Thu, 9 Mar 2023 08:53:12 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Stefan Esser Subject: Re: FAT32 statfs(2) inode usage Content-Language: de-DE, en-US To: Kirk McKusick Cc: Ben Woods , freebsd-fs@freebsd.org References: <202303081948.328Jm50O078295@chez.mckusick.com> In-Reply-To: <202303081948.328Jm50O078295@chez.mckusick.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N Am 08.03.23 um 20:48 schrieb Kirk McKusi>> Date: Wed, 8 Mar 2023 17:40:34 +0100 >> From: Stefan Esser >> Subject: Re: FAT32 statfs(2) inode usage >> To: Ben Woods >> Cc: freebsd-fs@freebsd.org >> >> Hi Ben, >> >> I have created a patch that has been tested with both FAT12 and FAT16 >> and which has passed all my tests with different file system parameters >> (e.g. number of root directory entries) and all operations (create, >> rename and delete files and directories with DOS-8.3 or Win95 names). >> >> Could you please create a PR that describes the issue you had (wrong >> report of no free inodes on a FAT16 file system) and assign it to me? >> >> I'll reference the PR in the review I'm going to create and hope that >> this will help get the issue reviewed and the patch set approved ... >> >> Best regards, STefan > > Stefan, > > I will provide a review for you. Just add me as a reviewer when you > create the review. > > Kirk McKusick Hi Kirk, thanks, I have already created a review: https://reviews.freebsd.org/D38987 I'm not happy with the choice of function names for the increment/decrement macros, and I think that the exact location of their invocation should be reviewed with regard to error cases. Best regards, STefan