From nobody Thu Jul 27 23:08:32 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RBmf81xhkz4pqx7 for ; Thu, 27 Jul 2023 23:08:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RBmf80vzkz3ypP for ; Thu, 27 Jul 2023 23:08:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690499312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wp9433iTMlERlAWIhmdhXuNfnacolC8FqqvIzBeQA7U=; b=WZEGLJS1p7BdwFEhAXZgtAAOdbJcsEz0sheg72iB/8jZW+prS/nfyivazTye3FkJ6rMaJ9 ypQbEv2NBV+orHuZ9MRjzbVK3wEz5Y0aLaL/ZliVaylbK5JEp4JSmKAIdV8sJ2hKqKVpHH D2CX/zQ3D9C8MjQV5HPW3GmW4yr7RcPVRXuY0yusjPeVjT6F2GfvnReMG89zi/AsCqSlVY OhAyxmDay3L/vqCSlBVOnTLjNsUPxYaf4eC0H0gMP2uUOC/NkH6PgXvD5uLucVvHPRDuMI jALvDI4Gd4DM2RDalmo7AuTqNdiZl50+b+O+WnsoA+OZFyAjtJOpxCMQpJEz7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690499312; a=rsa-sha256; cv=none; b=gsCEzGm7gkUAdZMQGqks1IOdS/CRt4S9w5DX9K6SJghNC+YPkV61f0hEbXDFtjG2hf8kJa fN7C50j0qS4wcZodqGsgkOp/Sv+pvDWVXanrF4WPFTUeJPynlwVuJeCasrq5LM0FAQ6Pzg pMv3NjKO9ymECydKe4X/JzGO7lrOn4K/MLtxdmY4c/a2p3r8iVg/lB1q89fpYhVWqXz+Zk BekBqDebV8/n/EiX5gMoMySLID7wYVaP1Y09o4PEkO/iMtqMBl1c0Hh55TtZRtp2atAXmY mWheyA21ainBr1QgdKMpahsQRU7yb2veEansvZJRlw/+X5er+S4STGEhdEcDOg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RBmf76xZyzSr9 for ; Thu, 27 Jul 2023 23:08:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 36RN8VJf085117 for ; Thu, 27 Jul 2023 23:08:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 36RN8Vxh085116 for fs@FreeBSD.org; Thu, 27 Jul 2023 23:08:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 257768] Corrupt UDF disk image can cause crash when mounted. Date: Thu, 27 Jul 2023 23:08:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257768 John Baldwin changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fs@FreeBSD.org |jhb@FreeBSD.org CC| |jhb@FreeBSD.org --- Comment #3 from John Baldwin --- Thanks for the report. I have a UDF-specific fix at https://reviews.freebsd.org/D41220. However, I somewhat worry that bread*() and getblk() have no checks for negative sizes in general, and struct buf is full of signed fields for leng= ths (b_bcount, b_length, b_kvasize) that really should all be unsigned I think.= I think the code effectively treats the values as unsigned in practice, but t= here might be some subtle bugs due to the signed lengths. --=20 You are receiving this mail because: You are the assignee for the bug.=