From nobody Fri Jan 13 17:58:51 2023 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ntq136kXZz2sXP3 for ; Fri, 13 Jan 2023 17:59:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ntq134sSxz3NlV for ; Fri, 13 Jan 2023 17:59:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x532.google.com with SMTP id s5so32160246edc.12 for ; Fri, 13 Jan 2023 09:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Kh/N8FUiho/vobxnOCLbfakFqQRoIY6MP6aPvdIsukM=; b=nvCfJpI4g11lIxEAva1SCPPSs0KhTLigt3fSoi9cPGV5a7iAGKH0FP+CE4OX6RzBm+ gAL186D82gQKx0O3BfeROm/kHPguxQoJd5RhPKPI9OEifySJND5xEpTb2k5hxGfxwO4j yonZy6jJNS6z/bILJBFZgb8fBbuznd4J1SM7lwBU6YBADxeJCMjcy48aIeAl5sbRyvo/ 4h8gUxUES93qbRJCZ/+RTtQeTIF7qrRy0hjusTiflp2EPuEFACo8RlJWnzxgKpRuEUtd KnfvWrG/CiQrOK33F6xERx8yb4xCpJZf8lgQ+DUMhNOcl16v3CC1/FXQOmvyxZuH4E2s tHmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kh/N8FUiho/vobxnOCLbfakFqQRoIY6MP6aPvdIsukM=; b=I9tusgKTSVf/h6pabNRbiIXOy2vsOXYiohUrBSHRrZZMJjIYQpaghmPxSyfE3fa+vb sLTNQ/oS99j6lQeZ4bgWpaTuUhAK39EKp/J9RVvuMMRjcoRNSqwv5wihmzW/4offU0kJ LA/S7j89qf6LVye3XcgnfhuZHL0STWbG1AqWjS2u1QtMDhYxRaFEmIRmpW6kMcIndoSB V9TLukwESXrsQh4277wfO+XbiwD4CkRELTbNjGlmlxPkKhw45cZABep18OxYEkC69Zm+ L0HqYa814rLDQI7MKQvlRhoFGGNJdP3wtXpVIvVT+fZsAwouLYL+SXRPDUl5Vc7r1Gzn VM1w== X-Gm-Message-State: AFqh2kp6ElAN+8+zIhYBQ7v7efZ1bfyrboOnaLU0+ofkPdlC/uLiKeej +mrcXNSCEFaVKYbcz98PhGKreoDhQmUYs2nMKQKPuw== X-Google-Smtp-Source: AMrXdXvAtS2bMb14PglhCUKoe/2CdaQ0V6BbmDTgCWVmqlcBA4iyQH3SojnCh+q4NnicK4S6NpiB0vhml/tDzSAiFRo= X-Received: by 2002:a05:6402:3896:b0:496:a901:8de7 with SMTP id fd22-20020a056402389600b00496a9018de7mr3482489edb.136.1673632742360; Fri, 13 Jan 2023 09:59:02 -0800 (PST) List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Fri, 13 Jan 2023 10:58:51 -0700 Message-ID: Subject: Re: fsx revisted To: Alan Somers Cc: freebsd-fs Content-Type: multipart/alternative; boundary="00000000000017db9a05f228fda9" X-Rspamd-Queue-Id: 4Ntq134sSxz3NlV X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000017db9a05f228fda9 Content-Type: text/plain; charset="UTF-8" On Fri, Jan 13, 2023 at 10:54 AM Alan Somers wrote: > On Fri, Jan 13, 2023 at 10:49 AM Warner Losh wrote: > > > > > > > > On Fri, Jan 13, 2023 at 10:35 AM Alan Somers > wrote: > >> > >> fsx (tools/regression/fsx) is very useful at finding file system bugs. > >> I've used it to find several myself. But it's always had one nagging > >> problem: because it's neither installed in the base system, nor > >> available from ports, it's difficult to use in CI pipelines. I had > >> some free time around New Year's, so I fixed that problem. I could've > >> just made a port for it, but instead I rewrote the whole thing. The > >> rewrite is 100% compatible with the original (except for the -s > >> option, which I consider to be a bug), to the extent that identical > >> seed values will produce identical command sequences. In the future, > >> though, I plan to add new features that will break that compatibility. > >> For example, fspacectl operations. > >> > >> Check it out if you've ever used the original. I'd appreciate any > >> feedback, feature requests, etc. > >> > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268938 > > > > > > I like this idea. I've not looked at the code yet, but love more tests. > > > > How hard would it be to integrate into ATF so we can run it as part of > make test? ATF has the ability to skip tests when required packages aren't > installed (which it does for python tests)... > > > > Warner > > Easy. I had that in mind when I did this. We could add an atf-sh > test that creates a new ZFS file system and runs fsx on it for a fixed > number of operations. Likewise for tmpfs, ufs, etc. > Great, glad to see that's already in the planning stages. Warner --00000000000017db9a05f228fda9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Jan 13, 2023 at 10:54 AM Alan= Somers <asomers@freebsd.org&= gt; wrote:
On Fr= i, Jan 13, 2023 at 10:49 AM Warner Losh <imp@bsdimp.com> wrote:
>
>
>
> On Fri, Jan 13, 2023 at 10:35 AM Alan Somers <asomers@freebsd.org> wrote:
>>
>> fsx (tools/regression/fsx) is very useful at finding file system b= ugs.
>> I've used it to find several myself.=C2=A0 But it's always= had one nagging
>> problem: because it's neither installed in the base system, no= r
>> available from ports, it's difficult to use in CI pipelines.= =C2=A0 I had
>> some free time around New Year's, so I fixed that problem.=C2= =A0 I could've
>> just made a port for it, but instead I rewrote the whole thing.=C2= =A0 The
>> rewrite is 100% compatible with the original (except for the -s >> option, which I consider to be a bug), to the extent that identica= l
>> seed values will produce identical command sequences.=C2=A0 In the= future,
>> though, I plan to add new features that will break that compatibil= ity.
>> For example, fspacectl operations.
>>
>> Check it out if you've ever used the original.=C2=A0 I'd a= ppreciate any
>> feedback, feature requests, etc.
>>
>> https://bugs.freebsd.org/bugzilla= /show_bug.cgi?id=3D268938
>
>
> I like this idea. I've not looked at the code yet, but love more t= ests.
>
> How hard would it be to integrate into ATF so we can run it as part of= make test? ATF has the ability to skip tests when required packages aren&#= 39;t installed (which it does for python tests)...
>
> Warner

Easy.=C2=A0 I had that in mind when I did this.=C2=A0 We could add an atf-s= h
test that creates a new ZFS file system and runs fsx on it for a fixed
number of operations.=C2=A0 Likewise for tmpfs, ufs, etc.
<= div>
Great, glad to see that's already in the planning st= ages.

Warner=C2=A0
--00000000000017db9a05f228fda9--