From nobody Sat Dec 30 16:58:00 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T2T2c2mqxz55cD3 for ; Sat, 30 Dec 2023 16:58:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T2T2c1FyRz4F63 for ; Sat, 30 Dec 2023 16:58:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703955480; a=rsa-sha256; cv=none; b=NNnxhf0wfP8Nvtg0nRcdFHqyKd78/FZOy5v8pInMcMkrhhCEOy+i99wruPPOzPbZ/luiCW fdesVLdnI4bIGkCBueOqb/66n+gGW22UTELQjCkPMj5KXrYcKE78f6S2L8FIRXliFqyrXO wrUNzNBWXf9c3ZFdzvt2MVGb1XLwGuby/W7xYZquO2i5ZFATOB7HUMfYLPfDzZ249mTE5I I7xTi2+rnzh3q2MdK6yi+XMKpIt8Dss0n9s9rhsC6qwF7xUFcalU6yr0bhEP1JXa9AQfv0 ufQP8J/y8lIKNCF4uPhpH8c3SI5TjWLm1YIHWqGtSgv+yK4eBeytMSCD83c9dQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703955480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BEVq9Aun+S1uQS0kpA4VGk/7Vxn5uiKbmFfbJs6nw0s=; b=uyJ1+pUEiSSh6HobTwU4AAvr3xG4++BgVUQbhi/DqeMU4AtU2JFBY1gRXjXIt1pLE8+r3o upPULetIJDwmvejIDlVwIQVlEsoNo5qMoyktrPeWotdMogciPot1rzUkUiJLAjZ946z9lk kt+xS+XJUy0mTsbLoPtMXLew7oCyLhyYoMlUa9BpLd8wXYVOMj4lCTo+4hQXP8JqhnfzuT UR7F2HG68rZif+RjYYyytKnkfBuwlbpUG272AoifjZ4QWbAo+Q0QYO/r4PVnvQyvcIb+i6 J0IKzsZBe2Rfuq3WDt6+1Pc3lbP0wQmgR1M1pyMhkMiQGvR6YHlxMH7O14ki/Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T2T2c0MKwzyWd for ; Sat, 30 Dec 2023 16:58:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BUGvxht085597 for ; Sat, 30 Dec 2023 16:57:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BUGvxQS085596 for fs@FreeBSD.org; Sat, 30 Dec 2023 16:57:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Sat, 30 Dec 2023 16:58:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #21 from Rick Macklem --- Created attachment 247360 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247360&action= =3Dedit Don't clear the dirty bits on pages being written through the buffer cache You could try this completely untested patch. The last time we played this game, the problem was that a call to vfs_busy_pages() cleared the dirty bits when it should not have done so. This is the only other place where the NFS client code does the same thing. Note that I think kib@'s copy_file_range patch is needed. I plan to do some testing of it, to see if I can break copy_file_range() without the patch and without using mmap'd I/O. --=20 You are receiving this mail because: You are the assignee for the bug.=