From nobody Fri Dec 22 03:33:37 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SxCZ90YdFz54fGT for ; Fri, 22 Dec 2023 03:33:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SxCZ86Nngz3RH4 for ; Fri, 22 Dec 2023 03:33:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703216016; a=rsa-sha256; cv=none; b=aRxaQfSCRDJRD7Ge8SifS10KAJ1X2h5twbk/dF/Lf4NMECWDaBu4g1x0vruEbhiq1dlO1L /p2TJYgbT1dW8vAeTpx6dnuNF0ZNzsDA1kIwJ9uyuHGbi2FEzNKd8FM2c3eZHam5q5tHJA AkAPRcChkrJf8JlUdtvuV4vx+JFjr9ma+hAslKItNaWtzc8TBgsf135geuBQ/X/Zs4QDj6 cLaPPAosTTusuXOT+416C+jRQSW2SiFstw286vum7FNhXdG4TgDh7DlzGFqxuWlsDiQNGo LPEqNyXJ3AOcYZXvepz7hF6hkpMQmkJxoVKQBrNvt+E0H+xsCj+Rv46FG69oxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703216016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=74B9rh670hXiIG1KHoaukkJFvSOME1QzEPbt0+gGrqg=; b=iFmXrZqcNUNUbOVx7MCUj8NNdbeQm2hip8UCiSa5i9ZcNoTxUlx5N35p0h2/FHhUKddirb ZbAm6UH/hIQ9BeC1ytRX5759fpqDqY24UNvpyzaZ/gD/KsfQk3IXc2V1EtzgbPo/o90TS3 A54zH+XOmVxvxulOy+qdxGCzSw2XWWt02lBNjpPulqmc8L5QcqrmycUar8MRAvex4ijpbW k0T8WYg+597I2CnH6KmjuxgtfUAP1JZ5cbqo0CiLYViHaw2ooV+WKYIVrWsK96D5PPfiOQ FVLOLEObbyFVeOsISJeKEc/bNZRv2qLwDr5vDMrVtArqlcIhhXGsnE/SkCQGWw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SxCZ85TM3z10hS for ; Fri, 22 Dec 2023 03:33:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BM3XaYM041291 for ; Fri, 22 Dec 2023 03:33:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BM3XaB5041290 for fs@FreeBSD.org; Fri, 22 Dec 2023 03:33:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 275870] [unionfs] [zfs] kernel panic on umount Date: Fri, 22 Dec 2023 03:33:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jah@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275870 --- Comment #2 from Jason A. Harmening --- It looks like this was caused by the vfs_unregister_upper() calls I added in 14. I'm a bit surprised that zfs rollback obliterates the v_mount field of= the upper/lower vnodes, but then I'm not familiar with that code. In any case, unionfs should probably cache the ref'ed upper/lower mount objects returned= by vfs_register_upper_from_vp (as nullfs already does), because there are seve= ral cases outside of unmount() in which unionfs directly accesses ump->um_[lower|upper]vp->v_mount which aren't likely to be safe in the pres= ence of a concurrent (recursive) forced unmount. --=20 You are receiving this mail because: You are the assignee for the bug.=