From nobody Fri Dec 08 14:55:08 2023 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SmvM50mg6z545H9 for ; Fri, 8 Dec 2023 14:55:13 +0000 (UTC) (envelope-from olivier.freebsd@free.fr) Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [IPv6:2a01:e0c:1:1599::11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4SmvM45by5z4cn8 for ; Fri, 8 Dec 2023 14:55:12 +0000 (UTC) (envelope-from olivier.freebsd@free.fr) Authentication-Results: mx1.freebsd.org; none Received: from ravel.localnet (unknown [90.118.140.172]) (Authenticated sender: olivier.freebsd@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 09B7420039C; Fri, 8 Dec 2023 15:55:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1702047310; bh=hbMu1qk/fAo0BA1FhmOYW9ZoueqYtoHQbDypfwycxAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FiQxQSzbGfKyGk9OYpS/xPyAEno+XGu60NVWrcs73fsdPomlxAZ+JE1MTS1wzlAO7 v9PXP4GwlGawkmMdPYHXoaJxiUL/105NUKnrnm1o0VobMaEjuBLJfdoBT/7ukRbmho K5bvZDevqNSIHzIOgpcX/eN/4RsOB5gp95edFKCSCBLpJTugAAmayFxov2+p6W9LIn Rlt3c+amlvtungZUlq6ntklV9YMw7DLWXg+wBbAbnRMfSemNF86RzfMY+GewavYwKG KCd09HHFPNyK/Dkhb8ehIYMGHCqEuo6NCNrPJTouxQFF0j6Aty2OOHeRKZG2oDJ2Xs 3qaj358vhX9mQ== From: Olivier Certner To: Warner Losh Cc: FreeBSD FS Subject: Re: periodic trim for ufs2 ssds Date: Fri, 08 Dec 2023 15:55:08 +0100 Message-ID: <85152060.0ko45tJjV3@ravel> In-Reply-To: References: <2959153.slGk94SIus@ravel> List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12322, ipnet:2a01:e00::/26, country:FR] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SmvM45by5z4cn8 > I wouldn't expect that to work... Indeed, it can't possibly work if fsck cannot know the inflight block allocations, which I don't think it can know. So I'd say instead that, if 'fsck_ffs -B -E' doesn't spit out an error, then it's probably a bug... > I'd go the other way. I'd turn trim on for UFS and monitor the system under > load. Newer drives I've evaluated have much better pathological behavior > than the drives of a few years ago... there's a lot of left over fud about > how it's always terrible... Personally, I've never bothered and have always turned trimming on on UFS, without practical problems. Regards. -- Olivier Certner