From nobody Mon Oct 24 23:29:22 2022 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MxB9l6Gbwz4ftLv for ; Mon, 24 Oct 2022 23:29:31 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2048.outbound.protection.outlook.com [40.107.116.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MxB9k5k6bz3LWY for ; Mon, 24 Oct 2022 23:29:30 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=muI3+PLXaA6IECFksvbcTMbF7SzXbEM0xr2BV1c6csMda+0hbed4B9/zBWjzW3E/XL0UN8EW1SmjraJI1uqxTascoLVGUnY3ODpQscbneAhNa1LTGC63uNTueRRny7/8MHFxagPBD4ihdXxhRwV6/mcmv8YqMzW9Y0hu2Ay0hdNAHtRlnlvZThExD8j8N4h1m8Jv8+NrxhLpnQaLaNSk9+AiJyfHirVZOm/gDZtAWy0MbxZ2mnyk+3kFY0RAOJIEUo6A5N9cdUWsXpQFbFWw/mWfalnKLhhL2vKLXrqm044JRaeelPbK8JcGzxKSf4azWZ2UaJDoDjG3ZcyLvgr3zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LLUXU2DtTj2sr5wmCUlGue8jIEkv23I4bQfFo30rCE8=; b=Bnbfhy1nJJuxqXA1CsKOjmOKwlTOR2PIKjoKKqM3suBs6uppCBChFpHwQGDqwfgXhaiI8VLuD8dwm49xCq1szviVmgR9LHJvH10rJyo66V/h7hTHZzEnaG3guugrYckOPg32tawX/OtNmbM1mCofhwDC9nz95evF1gulIWrr41jYVaFRctyQmKoMIGkW+J6885z6NhAyh9b9GlprsTtyYNzL9cbtbdSlidf5zsF2MDDov5HE/SaJlHJ/lw/YVsaoWuFjtFyMfI5ATVlZDemO8IJnEE7bPra4CeOoZRbKdIHkJ+8MCt1LCaNpajGqPCTEEJKshhYxQ0NnwDfRREgTHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LLUXU2DtTj2sr5wmCUlGue8jIEkv23I4bQfFo30rCE8=; b=VwF6i/u8b2owfIxppzOSGwrHAFPiM8WaQP63gtlhzA5t+PWtIK7etdk8zT7QqCeaJIigDJ8johy9Gc6SPyzEVG5CWXNC5K8TrGy3GKdMEiUXIIyE443+bHmSEJB7FlgQG0yHgeX3N4Ejm5Az4u3vvWtDua7ZnEahM86IGDM6UuhT4SVCf2F4mwTGWen7Vsu7mytFrEHdgvf/cj/8AYQmS5xojf2RLihUq0e6CyYXT/ofwy7LksnzzFszobaAYuZ+phRZ2gy8/8if+17UMB6yVAE/nUuSM1XfZ1hDs6Q6jrOVIAOc6HsWduIiBMVEsWcjrNiWNHqNy1XNqVAuQTxOOg== Received: from YQXPR01MB4150.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6::7) by YT2PR01MB5268.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:53::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Mon, 24 Oct 2022 23:29:28 +0000 Received: from YQXPR01MB4150.CANPRD01.PROD.OUTLOOK.COM ([fe80::c170:753f:fac1:45f5]) by YQXPR01MB4150.CANPRD01.PROD.OUTLOOK.COM ([fe80::c170:753f:fac1:45f5%4]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022 23:29:22 +0000 From: Rick Macklem To: FreeBSD Filesystems CC: "brad@facefault.org" Subject: RFC; Should rpcb_getaddr() be changed to not use UDP? Thread-Topic: RFC; Should rpcb_getaddr() be changed to not use UDP? Thread-Index: AQHY5/6z6yyrRac0k0y4eWgimCQQ2g== Date: Mon, 24 Oct 2022 23:29:22 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YQXPR01MB4150:EE_|YT2PR01MB5268:EE_ x-ms-office365-filtering-correlation-id: 35e1d63f-2196-4061-607b-08dab617951c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PC2b/dvJd343LVd9X+tY78jOUMqzI/7FtdyX2UXaol2KBTsKuDqw5PfBikIpteDLQoCK7TmUHv/XgIXTYgSnBjXnFmRQWOLTil2pHzJixLd1CbyFOtSyeoonM0nDr4WPKN4fxjHCUfIFDxHKDhMqOswfM/IyTrs9b3gXPMniIofegzzHJ7TxWQ2nL1/iXp6WGb5gj34EDt06TWGkuuEJ+ucQvrceoZYQa4qp0m1PcdnVn8tO3jBfiB4subyw7mp+LVvxX6WcGL65aF/9V5y3f56WLG1ai1PKrcjKR8TkvcEBntq3EkysePFs68kUFMH07lEC69p9Iw8xS2J+rWICn1vFioff6TrdEjfSCPsRMETynYHtjPYVJMryWz5sx9wIjQMLor1Uwb/aCMafTTkDh3ul+viWFTOVJXfOJIFxYvvryuTsbz/2mYLyc3n/PFIEKUqIwt63zE5YuAo/UrYvdIc2H3gdzz/t0csJnFaf87HPaG93AKj0DEvGLoaaLIqzqorglebP0GHQlz0eCJGmh77w4bj9tsf1QxVJADUHfxKbyE5ahAFQzYfjgPB/ZUtJGfe3jjoEaE3ZKAg1kRcy01WcWT4ZnXTGcZEtsj+2GIeQ7A+mWjxmIuoAWjbBHMaCSjFc5uiEN7vPFbZIL/bTHcGrlnIdMILWnAfZi92WnM9pLE3t91mRg9lESU8MUU6OwvYTvJ26dYaYTrkFSGLDoLiGTVrb/oQVlwCt4jgL9L8LbpKH1egNm0xGRzQa68+RgJAtfeq7umMRBQZQGe+TMA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB4150.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(451199015)(38070700005)(76116006)(86362001)(33656002)(66476007)(66446008)(8936002)(38100700002)(122000001)(5660300002)(52536014)(66556008)(66946007)(91956017)(8676002)(41300700001)(64756008)(4326008)(41320700001)(2906002)(7696005)(6506007)(186003)(6916009)(786003)(316002)(55016003)(478600001)(71200400001)(9686003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Mn9B0Pz3mMDmRHZS/M1PE6cl93v0bvVqcPG3n7ftYFyfA4j4WF7Hnw7VYu?= =?iso-8859-1?Q?J5CmSh0Ue4yMHf/c0+UyN/05QCaaC8MQ0COEzEp62CGz/og4kx14XxgR4j?= =?iso-8859-1?Q?CjrTau8a6BJ0/y215lS/DtRZu/cfXMPWaVoQ765yj3uWvAXLMTx0NJsXaA?= =?iso-8859-1?Q?F32QkZNkjYsYIiK+KHehMfC+WxI0E2ml05oxsjb5F/tv1/LyKD9CGMZP3q?= =?iso-8859-1?Q?MrWBTetBoFuAcE173vPGXMkM7cqprcPoFMbVy/LQGNOsrm3YcrKNCG8eQH?= =?iso-8859-1?Q?QHhcw9wJmvn9mVAfsmla/HQ1VNnqTv33yB2FSnD3gfvSADI7F/UKYeG8Fm?= =?iso-8859-1?Q?NvQmM+KAmRVA5bkuw789enX+4n09ut4EdYdnUkUJv2mu0skEKor/VwSCQn?= =?iso-8859-1?Q?N0fLISDTuGJoHh6Fy6ETKT/6Clgn6mQHZtADl4359N9nZz+/SQ8ezE9lnf?= =?iso-8859-1?Q?2LfgbLoezbGcUIGfyieizRgZgxAGLhBvkuxu+wBxisooBvn5I1TzvUtBQF?= =?iso-8859-1?Q?9BYXj8U8vF6w8XqJQ1/+nFh5rfV2b7CKRIZ/ZsQSIkIDw6rN53e3qkla5x?= =?iso-8859-1?Q?bJ/mt0gaMrBAoqbGIRgk+PYdsHzN45490EaPma1PXtjV2C6Zd8iqrb/8+9?= =?iso-8859-1?Q?ukpmGywNeEOd7BAUvo8SpPlXlWtHegbO8TqVHNL2SyE5z9FKS0n0HAXbE7?= =?iso-8859-1?Q?RuWT2/U/JyOESx/ca+AOu4AHkZ3IEi52CXLbb96iLA6URJkrXrC3Mic5B0?= =?iso-8859-1?Q?TgC+phTexEDBnEKscIWwxVyCq4kZjVXBE6FxjEgc6aqYZfmDQtCluboCNA?= =?iso-8859-1?Q?lGG4cUyywdCq2FX/y5khZrd+GiKs2YUcZmlIrwdB5YwtQTVgH0Djz6zgV1?= =?iso-8859-1?Q?GUjhtQLhJwo9e7VVetVuNwRZl4vktR2hAW2b/UbJ5KYRIpcQyAbkVtqLr3?= =?iso-8859-1?Q?tM8IMQnxm3gIaxrSv1F8Ind5FtKdZki8wJPJ/oSYErgT30prubxb0yYPLA?= =?iso-8859-1?Q?hhfa5BiDWcEd6QPbNB2tcsY3VLYztKb3y4T+Xd7P6tkxL9zQHzKuHbU+PJ?= =?iso-8859-1?Q?KxEG4w5KFNPDcdZc1p2U8tLJ1j4lVumMf5aWaMyn5KcM72Uchy6TIrqt2d?= =?iso-8859-1?Q?dPdOT4GdSGu2wD1pmCVvnlqfOVkpluQbGDWGdHQaIaWFR6OdNwV5Joj5Ga?= =?iso-8859-1?Q?CkrjF2A/G5BI68lfvx5ulf0EWqNw03CauYCGp2x9Rr8xum4Vdo0XO7maMO?= =?iso-8859-1?Q?vPUR8/HuEK758fFuQ/baKO3vZnmAJ9fDLFXe+f51PbVeywczMiR0Ii/ve/?= =?iso-8859-1?Q?wYdvEgZ6A1f+yBmhH0rFgXC07cBzLWczHJr0vw1yn5HS3XEqw26Ao3KSA+?= =?iso-8859-1?Q?OFZWf98/rEbDg61i26swaQN/NlP6KbkAnakodiUgCzFLTEKn92qxpdPk7n?= =?iso-8859-1?Q?E16eafMgIBgntGP9AMZ7htxWHYKQQ876/XXgupF32+ESyGhLC3ckoy1QkH?= =?iso-8859-1?Q?0mA5JxdqwvhSjvFnpw/HXcur2AWj4s3pKVxy0zz5EIFx+8mAVSY9MXxjPK?= =?iso-8859-1?Q?3TudweGb30acWs1KIlZZcpb2ltcaD4KJ68oa8iNKVvSXShMoXGJmzyp/RY?= =?iso-8859-1?Q?5Hat9r4uS8zyapeBxZ6qbDABJ3WJPN1RvNdGYqUoeAzDYgkU3NS2MWxOOQ?= =?iso-8859-1?Q?l8ttS+qfx2d/mTa2z7PLjZpp5T7m3CkPb/InxlEp?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB4150.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 35e1d63f-2196-4061-607b-08dab617951c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 23:29:22.8358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5sonfbSCxMRZDDooJ6CncuMVydPLzu4TXjU1S8fhm6r7M2OUyM0m4Ogb83YEuN2iff3jt5A9qwGXbgJ5Ky1sMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB5268 X-Rspamd-Queue-Id: 4MxB9k5k6bz3LWY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=uoguelph.ca header.s=selector2 header.b="VwF6i/u8"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=uoguelph.ca; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.116.48 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.94 / 15.00]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.94)[-0.943]; DMARC_POLICY_ALLOW(-0.50)[uoguelph.ca,none]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector2]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-fs@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_NONE(0.00)[40.107.116.48:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[uoguelph.ca:+]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[rmacklem]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.116.48:from] X-ThisMailContainsUnwantedMimeParts: N Hi,=0A= =0A= PR#267301 reports a problem with an NFSv3 mount, due to the=0A= fact that UDP is always used to contact rpcbind/portmapper for=0A= the address. The code in rpcb_getaddr() looks like:=0A= /*=0A= * Try UDP only - there are some portmappers out=0A= * there that use UDP only.=0A= */=0A= if (strcmp(nconf->nc_proto, NC_TCP) =3D=3D 0) {=0A= struct netconfig *newnconf;=0A= =0A= if ((newnconf =3D getnetconfigent("udp")) =3D=3D NULL) {=0A= rpc_createerr.cf_stat =3D RPC_UNKNOWNPROTO;=0A= return (NULL);=0A= }=0A= client =3D getclnthandle(host, newnconf, &parms.r_addr);=0A= freenetconfigent(newnconf);=0A= } else {=0A= client =3D getclnthandle(host, nconf, &parms.r_addr);=0A= }=0A= It is pretty obvious why it uses UDP.=0A= However, the question becomes "should that still be the case?".=0A= =0A= Unfortunately, changing this function in libc will affect everything=0A= that uses rpcbind/portmapper, so it could either be considered a=0A= bugfix or a POLA violation to change it.=0A= =0A= The reporter notes that Azure expects TCP to be used and it appears=0A= that Linux now uses TCP, as well.=0A= The code has been like this since it was imported into FreeBSD from=0A= NetBSD 21years ago.=0A= =0A= Comments w.r.t. whether or not this should be changed would=0A= be appreciated.=0A= =0A= rick=0A=