From nobody Fri May 27 19:23:24 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7018B1B4DF92 for ; Fri, 27 May 2022 19:23:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L8vq11d6Nz4q7w for ; Fri, 27 May 2022 19:23:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D61F128398 for ; Fri, 27 May 2022 19:23:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24RJNOT1099161 for ; Fri, 27 May 2022 19:23:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24RJNOiV099160 for fs@FreeBSD.org; Fri, 27 May 2022 19:23:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 263979] [meta] UFS / FFS / GEOM crash (panic) tracking Date: Fri, 27 May 2022 19:23:24 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: crash, needs-qa, tracking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mckusick@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653679405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fXtWFVXD+ok1m3R72HnAk4jttAs5U+aYUeHIHU2+7VQ=; b=FiGV8TeyTQFzHQjA8Nnlh/GrlGFzj7vAFqdorG4tusg1Ct/HGF6EHs7NHQQT6zgJCQ/B/Y v2jYhSOZDgo7rgIV0X9cFjFnHtwUTEFQaCtabT0Bmxwb+WH8xxlaTbrznO0miAHA95h3q/ GULcbgkmYJsh9n+V/7ytqiYxHLRC6q/raC7brTJqSy80gnobpmIzn9OShhTnIUm+t5QXLX fcyDViIjwYEPe4hKIPpo5ZD/ViH1cydj70pP2QNNq/AmV4cwkCMGV6zMBR3AuB04zrFGQD GlqYjB/u6iCS1x/KcY9y7fFHmPwq2YlqDT9JTsc8k//2QsQ8cD9TLa8I1gtSqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653679405; a=rsa-sha256; cv=none; b=rELITv/EQ1ma4c8t6zWjEUE2VY4hqqJGrEYoVtHeppOMzWuL554n5mhW1ZdF2dXSrXitGI TtNbN4zfDH/dqAGk5l6BWiw4Ym21TzAnZBzngzDamWa08ozpap5j6X7lc/Ow5oP5n8q0cS jI9XG/aH7eO3g2cVFQ7lQ1VE8hXHXSsanQltDMMoMReXuSC41F5IomAzqjrcxC9pbNxND9 SgmNi6gF7DKzVOW7y3x6oHJ5kSZTIz8zig7DRh1v+3jzgwDoh4XUkfFHpIUsxZo92WBIQ7 EKnxSYVXJaqAOWH/9rcaSfwLKYxaEmgVkgZWHSXlzlVNswTSDo7molxkK0e50w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263979 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D076002f24d35962f0d21f44bfddd34ee4= d7f015d commit 076002f24d35962f0d21f44bfddd34ee4d7f015d Author: Kirk McKusick AuthorDate: 2022-05-27 19:21:11 +0000 Commit: Kirk McKusick CommitDate: 2022-05-27 19:22:07 +0000 Do comprehensive UFS/FFS superblock integrity checks when reading a superblock. Historically only minimal checks were made of a superblock when it was read in as it was assumed that fsck would have been run to correct any errors before attempting to use the filesystem. Recently several bug reports have been submitted reporting kernel panics that can be triggered by deliberately corrupting filesystem superblocks, see Bug 263979 - [meta] UFS / FFS / GEOM crash (panic) tracking which is tracking the reported corruption bugs. This change upgrades the checks that are performed. These additional checks should prevent panics from a corrupted superblock. Although it appears in only one place, the new code will apply to the kernel modules and (through libufs) user applications that read in superblocks. Reported by: Robert Morris and Neeraj Reviewed by: kib Tested by: Peter Holm PR: 263979 MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D35219 sys/ufs/ffs/ffs_subr.c | 163 +++++++++++++++++++++++++++++++++++++++++++--= ---- 1 file changed, 146 insertions(+), 17 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=