From nobody Mon Mar 07 19:52:36 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 820AD19FA8BF for ; Mon, 7 Mar 2022 19:52:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KC8J45QwHz3Knw for ; Mon, 7 Mar 2022 19:52:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 633106ACE for ; Mon, 7 Mar 2022 19:52:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 227Jqas4010586 for ; Mon, 7 Mar 2022 19:52:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 227Jqavo010585 for fs@FreeBSD.org; Mon, 7 Mar 2022 19:52:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 256511] UFS assertion failure when shutting down from single-user mode Date: Mon, 07 Mar 2022 19:52:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646682757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fr1eBx3Xc8W2JT7OGX+9xc+puW11IRJEgpqwT0HdLBU=; b=fQVFc8HAkEVMNkX+U6AQX7ypibGIxUUoGqSQyne9uON+hwtbOyxkLQbBzFMRl31nlOSzYX Jofx4rQrvG81DxilNAb9XQiz9Nc4+J02DWAYcsmE+mgB8rh+s/UGRPz65tEvJuIlpOQBIT R5t6oiXzqXB2m1vm1fwv5Av2QA71RkPxFvZBZO+ObzrGUvHsmK8xX1zi5y9U0CQUVQdWqT yqfOIijSQYG1yAVKfhrQcf6TgypScXCaLPTrrmYRNf50O11IKPjwcQRe0AoMwenCTXA/4L DoLVEXaXlWmW8G2mnJu9Vi2i/UkRrR360yvCgIYAnD7HJCCjjX9HIyltkBDAcg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646682757; a=rsa-sha256; cv=none; b=hoVRMl9C6nd3z8NWQBfXJg4TOb1JXMIbm7brEq33GBnEvrM/U48cWtNIC0maAKb7l2tvad OJPB+r4h25lnGJ7KnyCgfCKYyb6A8wdGv7qDqTODYRqsYziuCqfzPB4XWKx3QQS1UfJWHJ zIqDAb5bBLjCcnOPaX+SLBZxeiBQrpL/7ZOEZvBHNOKksfYtxZpdgO94FrfWadN7NjvLyh nP37Cje2oFsnN/zxA/XAv1kDVUf+inRvOGw5LefPlcW/QLuB9sTZnvXYICsN1kUXzGmgXK 2B9WxcS0PY6NqAGBgriTi7R+d0QSqANuttpGhwQYVHZNGUcV4XvKKG/8fLkuzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256511 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D0455cc7104ec8e8dd54b3f44049112a5a= 8ca329c commit 0455cc7104ec8e8dd54b3f44049112a5a8ca329c Author: Robert Wing AuthorDate: 2022-03-07 19:18:03 +0000 Commit: Robert Wing CommitDate: 2022-03-07 19:48:44 +0000 ffs_mount(): return early if namei() fails to lookup disk device With soft updates enabled, an INVARIANTS panic is hit in ffs_unmount(). The problem occurs in ffs_mount() when upgrading a mount from ro->rw. During a mount update, the soft update code gets set up but doesn't get cleaned up if namei() fails when looking up the disk device. Avoid this scenario by looking up the disk device first and bail early if the namei() lookup fails. PR: 256511 MFC After: 2 weeks Reviewed by: mckusick, kib Differential Revision: https://reviews.freebsd.org/D30870 sys/ufs/ffs/ffs_vfsops.c | 148 +++++++++++++++++++++++--------------------= ---- 1 file changed, 72 insertions(+), 76 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=