[Bug 252316] [PATCH] add OCF offloading to ZFS
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 07 Jun 2022 15:13:58 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252316 --- Comment #5 from John Baldwin <jhb@FreeBSD.org> --- I don't think the patch is correct. I think the issue is probably that you aren't using a separate output buffer, and in the case that we aren't using a separate buffer, we should just assert that the output_payload_start is 0 and not check it otherwise. Or perhaps you are using the output only for the digest and not doing encryption? In that case your patch might indeed be correct. I think though in that case we'd like to assert that payload_output_start is not used (i.e. 0), something like: if (csp->mode == CSP_MODE_DIGEST) KASSERT(payload_output_start == 0) else /* existing test that output region fits in olen */ -- You are receiving this mail because: You are the assignee for the bug.