From nobody Mon Jun 06 15:42:03 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9DFB91BE5DBE for ; Mon, 6 Jun 2022 15:42:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LGyR026gFz4X5l for ; Mon, 6 Jun 2022 15:42:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B2CBDE0B for ; Mon, 6 Jun 2022 15:42:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 256Fg3Yw031809 for ; Mon, 6 Jun 2022 15:42:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 256Fg3ra031808 for fs@FreeBSD.org; Mon, 6 Jun 2022 15:42:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 264174] Use of redaction bookmarks or redacted datasets on a boot pool renders the pool unbootable Date: Mon, 06 Jun 2022 15:42:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654530124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eFj25FtDsYKSoIw+zO1nB2o90nOzUcxW1YDSKJmIje4=; b=nf5Fz8VMcYLOdQXeUJYdBMhXhoeBt73rbeQUy+1UDZMBKi/BMBOJRSB4+k84IBXLMwHBaU 6wqqHahHe50D6CPs7Gb7frP6PMbhTnIDrAMYa+jXLw35Mg+Zft8XOsg2ZsR/89bULVxJR/ vCONcFTmXaH+h8Jcq09SF+2vhU56FGK1aWyT/7cHPA4FND6sp7npgtYSIG5eiVLIovATS3 mMvuYFs++5fj5KPxCvd62ta8kDLABdYJjroDVLzSGk/X2JMKnNSgXUxmIqzmOaldpHBWm9 CuKg8Gp7pTgRBwpNIzrFwrPaTIIh5GzHLuBIPZ6c0t8/9fNQ1i3OeMd+g4MbAg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654530124; a=rsa-sha256; cv=none; b=fmMptoTvwhVR2uvzo3i0JEBUNtj53NV8/wD8qTazY1A7McjN/IJqm0lhxcZYGvShYPNfqa KGcwW1ROLqM1hTxEf2qpLsjy7I94aJvd7/ycjTz9dOiMH3+9VzXcG3aeeO4Hb9/Nx8b4+h 6rXrV3Ksjp4T8RMvElx5VERC2p+LlBiRvbUlanu6b309/0H04zDSSPAy/SrM598ULOmOV9 XGweww1vzGZ/3zgMz+CnGjvsE+OQMxkxiagPKdxuhx2plUSmqWCV+kze+nHo1WNVCQH+lB fxgSetM6cU5T5T0DNC5yBp/XGu7Zx5XkNFxmH9WsetJMJFn6OIHhwbKJzEXpVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264174 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open --- Comment #1 from Mark Johnston --- I haven't yet attempted to reproduce this, but the described behaviour of enabling a read-only-incompatible feature upon receiving a dataset sounds q= uite wrong. I do see the following in recv_begin_check_feature_flags_impl(): 543 /* 544 * Receiving redacted streams requires that redacted datasets = are 545 * enabled. 546 */ 547 if ((featureflags & DMU_BACKUP_FEATURE_REDACTED) && 548 !spa_feature_is_enabled(spa, SPA_FEATURE_REDACTED_DATASETS= )) 549 return (SET_ERROR(ENOTSUP)); so it seems that we are indeed checking this. Perhaps that's not sufficient somehow. Of course, ideally we could handle these features in the loader. --=20 You are receiving this mail because: You are the assignee for the bug.=