From nobody Fri Feb 04 19:49:04 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8325919B92A4 for ; Fri, 4 Feb 2022 19:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jr5hJ2NfXz4SFF for ; Fri, 4 Feb 2022 19:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1FE4A118F5 for ; Fri, 4 Feb 2022 19:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 214Jn47T059833 for ; Fri, 4 Feb 2022 19:49:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 214Jn4CZ059832 for fs@FreeBSD.org; Fri, 4 Feb 2022 19:49:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 245916] Superblock check-hash failed Date: Fri, 04 Feb 2022 19:49:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644004144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8t2x503D1h+ZQbEMJZweIuRpBgsw3x20M1ccA2tzg3g=; b=xvnoe9gFP4w9me4NJVj5fttCHN9CHqqwZ0LGw5N/CyA+EWzZt+5TdYuevKqS1tPbHKY9Pk IXV6oBwbS1nDSOpt5TEWSOnI5NNlhoWZhyPbBTD7n7PipNC5nDX/fT0t6ro5qTfSvKzauc TUobQXDs7bKAwlYaXIb9dR2RET8vIK2CAkcmhxZFsR/g1bteD49R8Fv+zzVcgsk1HkVOJA DEa69zWD/sJjee8H0dslNMd1P4IajbJtgK2qGGsgZmQpcJnAU7k8wRIOQt5ugoHiBpBigr XfPz561S1R7hb+W0TyZuAQKHRJZhgTB7IFCSnqAIGfBGyXHx0nAmNYDBFhR3YQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644004144; a=rsa-sha256; cv=none; b=wWNg1s9MllaIwdNgvYXI4qnatuFts18r3PUSRS+SmSoy7IEr4A95jPFlJ+urRNNuEnCvPg IF0FZHcAMYj0/exYb2ygirHywpR29A2B/TOIJWqQr9od4fwVRdsKJGt0jST2m9Yfd0d6uq H9cLncV0hCVVlhqyO5VBh7fI1X73/tIFI3Xfm+vfCAP41GU4XaQNRsovg/WFDaH3KCE96d tOCFxqe6HfIHNtw/MXDBnerXfXcBqiyqyMFJuIsEoyhohPAlirZFPKaO5oQBKCH2JGJo0y rGdKgT4rAAqtTxfXjbyubsWzbh4t8bD8RSLYPsvz3FrcmIizopJpwrz1eUXDGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245916 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0bfa109b942659f609b7e2bf3ba042ec= 0cb3f9d commit c0bfa109b942659f609b7e2bf3ba042ec0cb3f9d Author: Kirk McKusick AuthorDate: 2022-02-04 19:46:36 +0000 Commit: Kirk McKusick CommitDate: 2022-02-04 19:47:48 +0000 Have fsck_ffs(8) properly correct superblock check-hash failures. Part of the problem was that fsck_ffs would read the superblock multiple times complaining and repairing the superblock check hash each time and then at the end failing to write out the superblock with the corrected check hash. This fix reads the superblock just once and if the check hash is corrected ensures that the fixed superblock gets written. Tested by: Peter Holm PR: 245916 MFC after: 1 week Sponsored by: Netflix sbin/fsck_ffs/fsck.h | 1 + sbin/fsck_ffs/fsutil.c | 4 +- sbin/fsck_ffs/globs.c | 6 +- sbin/fsck_ffs/main.c | 309 +++++++++++++++++++++++++++++++++------------= ---- sbin/fsck_ffs/setup.c | 182 +++++++---------------------- 5 files changed, 258 insertions(+), 244 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=