From nobody Thu Dec 29 21:22:55 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NjhFD1Y6Pz1HxfZ for ; Thu, 29 Dec 2022 21:22:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NjhFD0WQhz3pb9 for ; Thu, 29 Dec 2022 21:22:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672348976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kVpFE2u8ySqKY9l617KP2a/PEM7UkAYowO68w0L8Muk=; b=Np77wJ7guoBfvqmikuhAqetI+MtYsY2cjJE/iwJ+vCZ+QLB9TQ+ayXb0MJIw1UFt/xdVzM kBGG/0PLeNxD/5fSddrb+M8TjNXaHBMXpYq79eS4+6YdgHSwiIZa8N7MMncDumfiEzH5wm DoCEDzMvLVrUNZH6ZMcmhiZ2p9HFnV2/S53XesBUbZHfxfAeWQcfU0kEEET2yPzrXKmwc3 tVvDhIdVrLdYYBtWuPT7aZPLm2HBM7WKQrTxdp525UToTyG8RnpquSHyKtujsQHT2samWf hySy01kI1kVnt5H0b74I8HoIuy/yacNJcQXGQQ8KleMQuLFcfRFkTf6vb6QsUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672348976; a=rsa-sha256; cv=none; b=mvr0fqGPVsBZ8I2bUMX6fPO7XG7e1DjysO9MBJ+2WPYiuowBsQgn33GSt6qLYiJqZg9J8j YRdDc7M9dF0wQ8lAImsqaU0A8GFCShVDWXOBlDLwOqa1hQxqB2rqeMHFtdhFkISElaQdNv lZmISD1VkxwN8A/e7k1ou8WmvI5CGsIlAnA5jI6lQokOjKUIyeyjX1x428lCCE9ZUi0k/r xsMiPhrsIprfgQ45pQrkv+TFusTS35F1q8Zb0bxNCal/VKdFocdv9Zu2RmvsKZzROBQkk7 sAhqKjI/iC8tvxnQjUpQKyZkZCyPhazzWSVW6UTO7vr1V4ifZ61li4x7i84DZg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NjhFC6hWLzk0m for ; Thu, 29 Dec 2022 21:22:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2BTLMtgK049649 for ; Thu, 29 Dec 2022 21:22:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2BTLMtTg049648 for fs@FreeBSD.org; Thu, 29 Dec 2022 21:22:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 267628] growfs deadlocks if output is redirected to the filesystem being grown Date: Thu, 29 Dec 2022 21:22:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cgull@glup.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267628 --- Comment #5 from cgull@glup.org --- I have some WIP addressing this and adding enhancements, which I'd not fini= shed testing before the holidays. It may be a bit late now, but my fix to growfs is to check stdout/stderr for mountpoints in growfs.c instead. That's less general, but growfs() and /sbin/growfs aren't very general-purpose to begin with. I think kib's appr= oach is fine, though. I have some other minor changes to growfs to avoid writing to stdout/stderr unnecessarily, and I also implemented my proposed enhancements to growfs.c, growfs() syscall, and /dev/ufssuspend to write new cylinder groups before rewriting the last existing cylinder group. I'll finish testing these and make them available for review soon. --=20 You are receiving this mail because: You are the assignee for the bug.=