From nobody Tue Dec 07 05:09:00 2021 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E805318CA00F for ; Tue, 7 Dec 2021 05:09:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J7Sy441kdz56FY for ; Tue, 7 Dec 2021 05:09:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 66E3619977 for ; Tue, 7 Dec 2021 05:09:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B7590We065310 for ; Tue, 7 Dec 2021 05:09:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B7590Xp065309 for fs@FreeBSD.org; Tue, 7 Dec 2021 05:09:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 256936] Buggy filesystem detected - message wrongly triggered by FUSE filesystems Date: Tue, 07 Dec 2021 05:09:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638853740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8cZfXbx+Xy4FaRKe1l4cF9fh5NirxzSH15frB4r4wU=; b=QCfscS0+A5xByVLDl3CZ3TkfiJzBmBFFAAQHR73f/X3KInyPHC6pibNJfvlj8zFrfal/G6 jGAx9DNboQ/ZJTco75N3OmzDjBwTt7xZ0Mi7/pnPjenwRHpiWZibhCl+kX+WdZBadFidjG BpV3egZBMKafmWTSMcMM3LmJ/2/zVrpaQ88ivtFKvu8Ja2sQDhqdOfVeo1D0DwOxCHVMNl ROYSOeAx58xaeFyd9Gn2Y434MSnpz2EhAxwixyzetH5Axad0xGdmleOJpSg5Hk8taKrfyS gvBCz0h0ZLhFTBisticKTl0j7pTbcwkH14yE9qMNZfdzKdl6ttAqmMrRMKOo1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638853740; a=rsa-sha256; cv=none; b=RVvcTBEcQamOWtZGuVqoYqCnTH3G7QWfzPjZGakI54lRVrTE7roagSP09fiCQP52GxigUg nv+5gX3e562PwVEI57kyK1PAbgeKVbUVNX04gcZvEcyhrR6wKfFypqsCs4mkLPRYVoa53a iX1LifS9mGbX1MVc/XctjKSBwZZb1t/oFF3XoKnZ7vMFvzD+65VGcBMardYsQwQaiQMHqf vcB0NiFwH+LhLsmp1cB164JW9mH0MO0o4vRmfnrvOhuEYPTFE+vNnuLwKv+PMDxFGDcB94 EyU9rv/4gfpB1ayJYh5nZY/MqdYBXnkq1NaIEuTyOcb//YKblo0rgjgwhHQQDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256936 --- Comment #19 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D94b01af1e5953131d0ca2875e6a0cc882= 047540a commit 94b01af1e5953131d0ca2875e6a0cc882047540a Author: Alan Somers AuthorDate: 2021-10-03 16:59:04 +0000 Commit: Alan Somers CommitDate: 2021-12-07 05:04:44 +0000 fusefs: quiet some cache-related warnings If the FUSE server does something that would make our cache incoherent, we should print a warning to the user. However, we previously warned in some situations when we shouldn't, such as if the file's size changed on the server _after_ our own attribute cache had expired. This change suppresses the warning in cases like that. It also moves the warning logic to a single place within the code. PR: 256936 Reported by: Agata Tested by: Agata , jSML4ThWwBID69YC@protonmail.com (cherry picked from commit 5d94aaacb5180798b2f698e33937f068386004eb) sys/fs/fuse/fuse_internal.c | 74 +++++++++++++++++++++++++++++++----------= ---- sys/fs/fuse/fuse_internal.h | 3 +- sys/fs/fuse/fuse_io.c | 4 +-- sys/fs/fuse/fuse_node.c | 19 ++++++++++-- sys/fs/fuse/fuse_node.h | 2 +- sys/fs/fuse/fuse_vfsops.c | 40 +----------------------- sys/fs/fuse/fuse_vnops.c | 41 ++----------------------- 7 files changed, 76 insertions(+), 107 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=