From nobody Tue Jun 20 18:26:55 2023 X-Original-To: doc@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qlw8H3Jmtz4gZfY for ; Tue, 20 Jun 2023 18:26:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qlw8H1JdMz4Z2v for ; Tue, 20 Jun 2023 18:26:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687285615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S3keaxVoBS5q2WsQQp94ge2TU1NedbBjFZu0ytGEtWo=; b=lxwnjH95ta+qxcCqceK4D/YRZPOzdGfqjJ1SQ29rYq/ah1KVOUhbZWm8fP11+0DDt2oA+4 LfVYaeUMQwuL+zzFXFBgRdZQC6iBgctEMDZ2CpztnxqXf9lynNU8BUVtVR25yX74v9FBJI JVh3K11ne//aTja7oWNYBYrk9lQ/3lenpWGRkry/+XS9IHqOkeA+txHaDL5AhlAcOL5Sob xUGeJJFRYemAipFGdWxAExiYP54CjKI97Dv7v2OXM8DqQpcHnEFv4Zpzt6owR7VIsBIavr PPswFH0xX7iGaVnH44qpjNozn7WKSViYNqs+ZzbUXkZiEKkqwwMvulX2eaB1Ow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687285615; a=rsa-sha256; cv=none; b=WTQMWVH0Cm7U0MPrV3Og4zIjFkG8VeihCjez5I3wDXwI91JA/2lHpOBST/bJWRHgLH8e+B Dqu3LM15850bz7cydtvaEquqDW9J6RnOouXmrouDnD9/GiOABNGaaaeQqmjxZ/yiADv5dQ RyD9pYc4QqcrJDaKEoD5/0NXEhtnV95gMti4PQ31VV0F1pPHVHVszTs6QuCYFkX9+FHwrz ritVM7U/1tiKSHmUXsTLboAhYqgAVdjVTWyE7zzQuUZzTdWsQcaKVad4O4wCh7MBez7eET lNa+cempVrQ7AApOS6LZFjpvX0ruG08fsGmR39xhQMmRcz3c2hSil4CFWzKUmw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Qlw8H0JVxz199Z for ; Tue, 20 Jun 2023 18:26:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35KIQsUm090708 for ; Tue, 20 Jun 2023 18:26:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35KIQsEO090707 for doc@FreeBSD.org; Tue, 20 Jun 2023 18:26:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: doc@FreeBSD.org Subject: [Bug 259385] Committers Guide: "Approved by" description missed the case where committer != maintainer Date: Tue, 20 Jun 2023 18:26:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Documentation X-Bugzilla-Component: Books & Articles X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: doc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Documentation project List-Archive: https://lists.freebsd.org/archives/freebsd-doc List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-doc@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259385 Ed Maste changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emaste@freebsd.org --- Comment #1 from Ed Maste --- Like this? diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc index 612db2afb0..898fa7e307 100644 --- a/documentation/content/en/articles/committers-guide/_index.adoc +++ b/documentation/content/en/articles/committers-guide/_index.adoc @@ -2515,6 +2515,7 @@ There are several cases where approval is customary: * commits to an area of the tree covered by the LOCKS file (src) * during a release cycle * committing to a repo where you do not hold a commit bit (e.g. src commit= ter committing to docs) +* committing to a port maintained by someone else While under mentorship, get mentor approval before the commit. Enter the mentor's username in this field, and note that they are a mentor: --=20 You are receiving this mail because: You are the assignee for the bug.=