[Bug 277114] x11/lightdm: fix tty counting in patch-src_x-server.c

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 18 Feb 2024 19:27:14 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277114

Gleb Popov <arrowd@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arrowd@FreeBSD.org

--- Comment #3 from Gleb Popov <arrowd@FreeBSD.org> ---
(In reply to Guido Falsi from comment #2)

> I could not identify the kernel code actually doing the naming of these devices.

If I'm not mistaken, here it is:
https://github.com/freebsd/freebsd-src/blob/d0bf8b5aaccbe082d3728279620b8f8474d9ca8a/sys/dev/vt/vt_core.c#L1854

The %r modifier uses "current" radix, which is obviously 16 in our case.

> Base32 is a completely different thing.

Not completely. Base32 is the same encoding as base16 with only difference that
we're using a radix of 32. Which would mean that after ttyvf it would be ttyvg
and then up to some 32-th character (probably a capital one).

> I'm not sure I understand what should be changed in the consolekit patch.

I was hacking ConsoleKit a lot during last autumn and this patch doesn't seem
to be really needed from my POV. The code it changes already follow the same
path, IIRC.

-- 
You are receiving this mail because:
You are the assignee for the bug.