From nobody Sat Feb 17 17:17:14 2024 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tcb8C1zP3z5BYcL for ; Sat, 17 Feb 2024 17:17:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tcb8C02hMz4v93 for ; Sat, 17 Feb 2024 17:17:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708190235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=24h+y4sxPL2QUQtkVym3TaXX/DDG3/1zl4GIpjf7mVI=; b=hm4ZKIY6cmKSAzpLItAGCwWponH7/lgMxSbwylVx6HSPDZEi67e1SyYfAFhBaVSvVzzs3A AuOcYJQwY7crkUBB/uXwtt8Kb8da8eF5ryNQNcBV4m8KNaYvVUiH9fxb0Jzd1Pg+qNPB0u 52FI6LoRZJFBJALJF63DsnfSW+mOZ6IsFBD8OD1sIMpLVzojDi04mK4vgHDbWbN1TCPcFj wVdq4AQJy7fXK8B98HEhRpVcweQW0PZ8mv8PC7JDjk8VpgGqH2rxq8nmGyk/2x0aEOppDb f5ENLT1/kxFPpLycm/1A37iWM5Tdwm3rjczhe3JM4ixAzKhB84DOPFR6GkcGvw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708190235; a=rsa-sha256; cv=none; b=KKDynxyLjcsna9lB3dq6y5u5eqHVlfBUDEhkHNEoAKDDlpQJRdqmcbGbdpzfCwP+6BjnbJ ll+UEa8KLbqCvXWbkrmgVh7U0SYEfjG+0RRZtvMy7wF6rGSUDKVZ333DRe4wQhza2Lxlu+ eV43fgcnk/CKcSFLOGqQ6FLBbo+5PaEtr3mpzoH2loOpeO1vI6PpzmjZL4L99+TG+5eqnG wGx0x9ybrSORqLw1Jro1Uc7IGNvQn7RQzIvg9IADidjWt4TD6KDdgPVvg59HzrGce7ioa8 Lrf4BkjVVadhVKbRCiXQH52JipjOCFFzryrcJoBbjq/U0HVEKgBotn12I0wX2Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tcb8B665XzGxs for ; Sat, 17 Feb 2024 17:17:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41HHHE9I074229 for ; Sat, 17 Feb 2024 17:17:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41HHHEJF074227 for desktop@FreeBSD.org; Sat, 17 Feb 2024 17:17:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: maintainer-feedback requested: [Bug 277114] x11/lightdm: fix tty counting in patch-src_x-server.c Date: Sat, 17 Feb 2024 17:17:14 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 Bugzilla Automation has asked freebsd-desktop (Team) for maintainer-feedback: Bug 277114: x11/lightdm: fix tty counting in patch-src_x-server.c https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277114 --- Description --- In patch-src_x-server.c we currently pass "ttyv%d", but we count TTYs in he= x, not decimal and so it should be: + tty_text =3D g_strdup_printf ("/dev/ttyv%x", vt - 1); This bug was identified in 221452, but the accepted patches bandage over the issue rather than fixing the root cause, which is the counting. This patch was suggested and actually resolves the bug: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D236106&action=3Ddiff However, it is also possible that these are base32 numbers rather than base= 16 and points here: https://github.com/swaywm/wlroots/pull/1945 With this fixed, it may again be possible to pull back in val's consolekit2 patch as well: https://github.com/valpackett/ConsoleKit2/commit/18a058576d118dec428d81c7e2= e336 9d9ec939d0.patch