From nobody Wed Dec 04 09:16:01 2024 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y3Bhn593Qz5gG8Y for ; Wed, 04 Dec 2024 09:16:09 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y3Bhn4HhMz4shm; Wed, 4 Dec 2024 09:16:09 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733303769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=Yuhx1N3NSGSc7P1CFbtj9UgaY60rWgAti1rr9IcVe5I=; b=Pj/ZCKE8m0jSU3nH8GtbyahOa001NYam+9fPT3OdFH4bO63lbSG2rJXCrvvLv2ZbPGy15h SVUAVfhZS8g42hVPFtfwuTtKWbBiZa64REUyxQ0d+/bXlAAattVXtzH0mDVBESzpHnIO+f EZzwHDgscyNTa5nJMoyAlUrj3duEj4bK28HitFE9B+AKQaZrxtV39k4xY+AZ3XyfQuA9RE pXa9qSH9KkVAkR1RPeT00nZiIKbW/lGAVCLBBaL5cynwDMSuuPRU64WencYq8Y1VBaypM7 A/R1qbJ1UEvVTtkvvpwQPoa6hc5sFQWld4b1+gsrbwwlRqLKFBfT20DoMzCuiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733303769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=Yuhx1N3NSGSc7P1CFbtj9UgaY60rWgAti1rr9IcVe5I=; b=JMeJo3o8qEh17nNnc4jQIMOchrJZjZPMWXQxYCWsP/Ya/QOyKx4/lBeLi6yDCE/qBy7RF3 Wyz0Urf1rbNnR1BwD2MrWHIVu7r1DlLKejrUmZueLQuLDmU8NB0juUjQ5PSm2M6CFg/lbu vBVnVHTqeMvhcPSuZUUhGPOVoX4MVfeKiCyd8wnqoCSixYnmZHdpM3TeTGCfASGicrD89w 6auuZDBq4qLBC6ORVXIBafG8Eey8o3cfChJ+J3KV/TvLQsgegx241fMJRxpxO6uFwnP9Dd YKybIjVNE2ZIzhlX1pwbMp8Yu51Qi1d00dUQTbuvnKR5F1V3mAvZcYRLabLv0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733303769; a=rsa-sha256; cv=none; b=q+FcbmyY65pfkOR3eouMFS9CeH1PugBFvPc77nk9RQt+1s8QK9yirqTGvLCc4HvNFz3SGI fUy17PiPCLUmzsWKuPEOHunoUfFo1FN+W5AI1Qzkp2jzJV9gIc5jsDpAhtMFnQByZrYB1h ypnul0qcdXIvwGyKluTdzQk4M92Ci/13ISarnkcefBtYUIF4fop39Sksh2Yyjv47+JJNHH OidW+lPuiPh3Ldgh5g5K/uy+76r4IvBnfLqzvQEUGANWQFOLfrdy+kgHmODo+ETCn39GFK dyWaq+SeHd+FHQXI9/6HxT2yC3uRGE+3/dc9HNfQKxjc/67RGJIPvA0D18pnTQ== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Y3Bhn3Bkwz11fw; Wed, 4 Dec 2024 09:16:09 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 99D3F1C13A0; Wed, 04 Dec 2024 10:16:01 +0100 (CET) Date: Wed, 4 Dec 2024 10:16:01 +0100 From: Baptiste Daroussin To: desktop@freebsd.org Cc: diizzy@freebsd.org Subject: tiff "broken" after switch from autotools to cmake Message-ID: <2tyxpneq7k5wy2t6autgxzggdrn4gkemnz26b625sux3e6zgz3@sotkawd66bar> List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, With the upgrade to 4.7.0 of tiff, we have switch from autotools to cmake system build system. We are the only non windows platform using the cmake build system apparently and the reason for the switch was not exposed in the build log, so I don't know why we did it... One of the result if the switch is it installs some new lib/cmake/* files. and interresting fact it breaks FindTIFF.cmake provided by cmake-core. Checking elswhere I can see noone is providing those lib/cmake files. What is actually broken: FindTiff.cmake uses the lib/cmake package if it finds it otherwise do some regular path checking. One of the feature that is not implemented by lib/cmake things provided by the tiff packages is the Optional COMPONENTS CXX. I know nothing about libtiff or cmake, but my understanding is we should either fix the lib/cmake thing to it provides the CXX components (imho thise should be done upstream) or not provide at all the lib/cmake files for tiff until the upstream have fixed them. My second question is why did we switch to cmake building in the first place ? Looking at the patch that were needed to be provided it is clearly not a first class citizen to build tiff on unix like. Best regards, Bapt