From nobody Fri Aug 16 15:45:24 2024 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WlmXh3Jltz5T7pq for ; Fri, 16 Aug 2024 15:45:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WlmXh2D2Pz4fPM for ; Fri, 16 Aug 2024 15:45:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723823124; a=rsa-sha256; cv=none; b=xpqSOH9X3+i7vAKXBCMEYZdF68QXltiMVb0FbitE+mO2nsAElmL6y9QstcSQN7Mep/lryF tfy+MLzErZkfNeRZl+MquS5wIxUuPLzaQJm0dYBL4ZcM0qatalkKgpjGCNMv+A1/xLR74o jspk9IOHlgsD6fJ5KbcAH3AFo76hLBBW5m3dyjhb3mL3OgO+RdfDsxuLg9ynbGGDFCt4Te kahywtT/PIEGV/8ScPdXb+YDwrYyl/9UqFRSzj7TUz+uzTjnCeWo8glr9/7c0Q4be5Xfdw URjofObHNj8Xms9pHOV9zUz7z8+DT61CbrIcJR0x7MmFXpO4xi30dgmiF7gwbA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723823124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pFhqWg33HMHh2xpNsUUULJunPd1hED0CnvxTFcm4948=; b=jNJo5iDz34+W2hZ8MYxZIRFIs6AgWOWj6pN00QA4fCMp6cJKnmRqKRl1DLaTz+cruY3K4r B3y0RCAqjXMk8zM6tIAxQk2+wxC/O2822OBAd1oEEcCL5yyUwskxZdjSEJ9INBU/cJ2IZa QiQ0srXLH6jvnRFfHMAsk+PkA2klO+iC6mA6ymCxRHKBznwBzexij+FIrGa9l0//Pu0q4f OyOl358j9VVYt9bYhcFh6gAdTk66Th9yMb1tDwRvqniGUrhKTbE7fDddyTuTpzIk9+VoyD jZdf2ZNO5vKLC6/NNxA09EXEKv5zB2MYEyeLD6NJGLfth70wvXY7Hl2f4zqksQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WlmXh1qhMz1Bry for ; Fri, 16 Aug 2024 15:45:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47GFjOiU074578 for ; Fri, 16 Aug 2024 15:45:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47GFjOHo074577 for desktop@FreeBSD.org; Fri, 16 Aug 2024 15:45:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 280564] graphics/poppler: fix build with libc++ 19 Date: Fri, 16 Aug 2024 15:45:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280564 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D6930d099097eb9de5321e7bb9728e82= efaabf0f6 commit 6930d099097eb9de5321e7bb9728e82efaabf0f6 Author: Dimitry Andric AuthorDate: 2024-08-01 19:48:37 +0000 Commit: Dimitry Andric CommitDate: 2024-08-16 15:43:43 +0000 graphics/poppler: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes graphics/poppler to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ =20=20=20=20=20=20=20 /wrkdirs/usr/ports/graphics/poppler/work/poppler-24.02.0/cpp/poppler-global= .h:101:43: note: in instantiation of template class 'std::basic_string' requested here 101 | class POPPLER_CPP_EXPORT ustring : public std::basic_string | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Upstream poppler has fixed this in commit b4ac7d9a [2], so add it as a PATCHFILES entry in the Makefile, until the next version of poppler is released. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-remov= als [2] https://gitlab.freedesktop.org/poppler/poppler/-/commit/b4ac7d9a PR: 280564 Approved by: maintainer timeout (2 weeks) MFH: 2024Q3 (cherry picked from commit 6bf6ee19368dea736b8a402d115c797f271a0f47) graphics/poppler/Makefile | 3 +++ graphics/poppler/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=