From nobody Fri Oct 06 17:52:08 2023 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2GGK6135z4w10Q for ; Fri, 6 Oct 2023 17:52:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2GGJ6r3kz4f4t for ; Fri, 6 Oct 2023 17:52:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696614729; a=rsa-sha256; cv=none; b=G18ckVp1ndqEKIw18U6YWnL41Bh9G/N6HCggmzUtBGZEyvsbfIZO/6myG6H+TuABmnuMtt PDOANtLoD1Hx57LfJ7vZsNhLOFTgTMKBQb5/vRxHf16v1xRILHpCib5Iw9d6johxTQR7gz Od1NRyTSUjF2IYIVlEGVVYQU+PfyFTQle1u0IxdVxn4efXOVORKLwQDpEWfdbQgG5ft4yQ pNPNLxCIqUNZk3G5wYCXWJ1kAEQWrlm6P749v6dLnsablKPoiYiuKMAV+c8zYRjUhnlbp0 z1EuqkbORs4QGZ1JAwBCsGTegXzoMYLgaYRYcy5VM0sUcRseQ+paOwgdSM6RlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696614729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MsME+nhgRTO8QHycs8J7XD2lZHS02kAn+AGW6qoFVbo=; b=kF9vlghGtxlUJ/kozuwDphWRvqEHDfU9fz/KuUTwe49FHbacdrnuHybGtmQsDSeD3JPiaT ELRyjIxXLa4HeSo199wqtzBI2jERQJUAsHr2OpVH0eKhNsPzvYQDjSJki5ojwhAqtofb6m kXxfWx3ol+Wg0t5hYxdC0IwmoUDTzjNCGL9xQAoqXKIYlfE39o3+cytMNQp5XjFGwcRVgb BGjXr+fW0jqBpheUHkxrb4GJdoLZ44WIV5OjZkwfsnSG1yIvOpSJID/OAVearE0A4Zf/Mx bmiDY66Rfl+AvqT+Ko5KQOBFzusG8G42NyqAITpq65+0NC+vb3IopT7SoX+xBw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2GGJ57pqzxsq for ; Fri, 6 Oct 2023 17:52:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 396Hq7PE067792 for ; Fri, 6 Oct 2023 17:52:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 396Hq7Tp067791 for desktop@FreeBSD.org; Fri, 6 Oct 2023 17:52:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 274108] devel/libnotify: fix build with lld 17 Date: Fri, 06 Oct 2023 17:52:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274108 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D623262a13efb4c659fda87783fb5e61= 64c24a774 commit 623262a13efb4c659fda87783fb5e6164c24a774 Author: Dimitry Andric AuthorDate: 2023-09-26 14:19:09 +0000 Commit: Dimitry Andric CommitDate: 2023-10-06 17:48:54 +0000 devel/libnotify: fix build with lld 17 Building devel/libnotify with lld 17 results in the following link error: cc -o libnotify/libnotify.so.4.0.0 libnotify/libnotify.so.4.0.0.p/meson-generated_.._notify-enum-types.c.o libnotify/libnotify.so.4.0.0.p/meson-generated_.._notify-marshal.c.o libnotify/libnotify.so.4.0.0.p/notify.c.o libnotify/libnotify.so.4.0.0.p/notification.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,libnotify.so.4 -fstack-protector-strong -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wl,-rpath,/usr/local/lib -Wl,-rpath-link,/usr/local/lib -Wl,--version-script,/wrkdirs/share/dim/ports/devel/libnotify/work/libnotif= y-0.8.2/libnotify/libnotify.map /usr/local/lib/libgdk_pixbuf-2.0.so /usr/local/lib/libgobject-2.0.so /usr/local/lib/libglib-2.0.so /usr/local/lib/libintl.so /usr/local/lib/libgio-2.0.so -Wl,--end-group ld: error: version script assignment of 'global' to symbol '__prognam= e' failed: symbol not defined ld: error: version script assignment of 'global' to symbol 'environ' failed: symbol not defined cc: error: linker command failed with exit code 1 (use -v to see invocation) This is because lld 17 defaults to errors when undefined symbols are referenced in linker version scripts. Apparently the __progname and environ symbols (which usually come from libc, not libnotify.so) were explicitly added in: commit 0b0b10cff8d7b5ed08d11c6fa4d66e1977d6eb79 Author: Baptiste Daroussin Date: 2019-12-16T19:40:37+01:00 Fix build with old binutils. Somehow linker scripts should not hide __progname and environ from symbols. Reported by: kib but it is unclear what the original error was, or how old "old" is, and there is no reference to a PR. In any case, I think the patch-libnotify_libnotify.map file can simply be deleted now. PR: 274108 Approved by: maintainer timeout (10 days) MFH: 2023Q4 devel/libnotify/files/patch-libnotify_libnotify.map (gone) | 11 ----------- 1 file changed, 11 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=