From nobody Fri Dec 29 03:04:04 2023 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1VZr426sz55J7D for ; Fri, 29 Dec 2023 03:04:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1VZr2sb0z4CZD for ; Fri, 29 Dec 2023 03:04:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703819044; a=rsa-sha256; cv=none; b=Xb3Vkf9LftbpbbsaSuHw4+dn2GqQYJfULQyLhObOpMe9MUd9j062Ic28fmqhyXlCgkULnj +F+rc4wTWYYVrky9/wxNRx4C1Eb7RsdrP6N1FPiJquWEQuZl7vKXmZRlmQ/zxsqnHJlUqG AmkX4MuMhFxHNGdrCoEx13pm/8OVr3c46pb6fX/B0qlXyGsc7b/z6t5DArySo/+a9+zEDL WTb/KSx6KXeS5qQHMNKeoA6G5zcLYkYARFW6BeddZxGaWKx7SpZojWRRr3Iw1zA1TqJuAP f3yWwRJKzcljtBd7uMc/DVf1QnOVAnGa49FNnMrSi55zXf13SH3isBv0Re5Tgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703819044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gILIyI9t2/9p/kBOce+pZind4WORkWLmaJpZ8ZorKyw=; b=jXe2WFxoM6AdLB1UMurIWIC3Rmit4RbqUPPzcZNdRp+e6YERyqjRKflIzLr9gbJQigudcg dYCeBV6tKjIlU4ccPlvDV7hjReyxKmzrOVl7wjXya5tbXeLmEJWHNjNcYtPOJupHd5gNwu /e+j8dyX6XGWXfMkeQcdZA+WkBrxqdaFAFA7+GuSVilB5/Uo5c+oIRDwTUCpifAd1R/p0n BbE3cviIqvgHMYp4AqhwQtKkJrABF7eiUcV14i1l+pNGnSW4AkhbR8DTF458TatrH4P1Dh pQbBAY7x1oDABaygrjwCFKef6oGdJGmRca+3mk8JCUrh2q4PHw4aHhVhdzA7ag== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T1VZr1xlkzp3S for ; Fri, 29 Dec 2023 03:04:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BT344KK072026 for ; Fri, 29 Dec 2023 03:04:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BT344j2072025 for desktop@FreeBSD.org; Fri, 29 Dec 2023 03:04:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 275969] converters/libiconv: Unable to build without including /usr/local/include/iconv.h Date: Fri, 29 Dec 2023 03:04:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jcfyecrayz@liamekaens.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275969 --- Comment #9 from John Hein --- (In reply to Rodrigo from comment #8) > The problem is that I don't have a choice to include /usr/include/iconv.h > instead of /usr/local/include/iconv.h while using FLTK. Of course you have a choice. But the way the dillo build is constructed, i= t's just harder. The only source files that include are src/decode.c= and src/form.cc. Those are the only files that need to prefer searching for sy= stem include files in /usr/include before /usr/local/include. And neither of th= ose files need fltk header files. So you CAN build a project with /usr/include/iconv.h and /usr/local/include/FL/*.h. It's just more difficult the way dillo's build = is set up. Some projects support different -I options for different source fi= les. Dillo [right now] is just not one of those such projects. > That is why I was suggesting to maybe install libiconv in a prefixed path= like > /usr/local/include/libiconv/, so only one iconv.h header is present in ei= ther > /usr/include or /usr/local/include. That's not an unreasonable setup (other projects do that: e.g., /usr/local/include/openssl, /usr/local/include/apache24, /usr/local/include= /nss to name just a few). But it's probably a heavier lift to get all the FreeB= SD ports that are currently able to build with the current libiconv pkg to loo= k in /usr/local/include/libiconv instead of /usr/local/include. Maybe with a strategic change in Mk/Uses/iconv.mk, it might be not be too bad. It also might not be too hard to modify the dillo build to support using a different set of -I options to the build of src/form.cc and src/decode.c. = I'm not sure which would be more easily get accepted (dillo build change or fre= ebsd change to converters/libiconv). But first step is to come up with a patch = and get it reviewed. Yet another option... Here's another option. Create a sym link in the build area that point to t= he desired iconv.h. Then the existing -I (or -isystem) flags that point to pa= ths within the dillo build area would be sufficient. That might be the easiest path. > > Usually on FreeBSD in these situations for building most upstream proje= cts, > > it is most manageable to prefer the libs / include files in LOCALBASE i= f there > > is a choice that exists in both the base system (/usr/include & /lib & = /usr/lib) > > and also in LOCALBASE. > > That's what I had in mind too. Then just use the the the headers / libs from the libiconv pkg for the iconv needs instead of libc & /usr/include/iconv.h. You are already dependent on= one package (fltk). What's one more? --=20 You are receiving this mail because: You are the assignee for the bug.=