From nobody Sat Dec 02 16:34:15 2023 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SjFr81gr9z52vXZ for ; Sat, 2 Dec 2023 16:34:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SjFr80dvFz3bLT for ; Sat, 2 Dec 2023 16:34:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701534856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UxIS34DSegi8JFG5FNc4I6s0kz7NqarWmMwOBcyzYEw=; b=RrvYJKvsQD1uNWSE25T2b3BZGwVHKqWbjlQieeIL3BPBetp6GsM9jfl1INFCMhjmHw7IPv qZgdurvONzBppfqlMUP8LC4ISdrqeXL7oQ8LNXoq88lBpD2FhV3POAo3lasblRbetP3qEv d0UWoDJ8CbVu4+d3Y5U1kimYLjPpeOTCVxLRGcTKpSQOzS2N06Vcb623qbdunmZnghD0LH W+rqHGOdUDjsspkBox2b+gp6SI9dtzWLJv8ET523ODOF8x6gZMiVOQrnfX+Ym4D/HwZ+ex tCg41dskIWkuHqrx8rNuVYHwnRa7w0qXpH1qSLD2cQqQOCd/Vn3UjgqmJsshZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701534856; a=rsa-sha256; cv=none; b=dhO1Ii7S56vIHUg6sk0M1uLRIR1O4ZxMGY6/owB4KcbSWsr61jOcFY9G/m/ZTg17dvSdx1 J99yp4kjqsyFheLrxTJ8tDzdYYYGyh+gR8/lX5qyzdwPwFmfJi8hfEQciTNUvyFCBR/kqB EJAOgdp7GIX5q3HDon0p3VPeZiKZc35zxG6tZ61/zKxXPdtKGrYpTQxptnYBl4WWJ6/t10 fKblBwOVWp91Zm/7m3JJHgbIDwVq0mYkorIEQBhSjhpmAGCaseXm5wCvbpeao64QpCtFzI U0cA//zLwKetMwNgCV9FWHtACKSd7JW3XToM1TAcTMR+MKUyaky/60rwXU4vVw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SjFr76jcjz8vK for ; Sat, 2 Dec 2023 16:34:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3B2GYFQ5080572 for ; Sat, 2 Dec 2023 16:34:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3B2GYFG7080571 for desktop@FreeBSD.org; Sat, 2 Dec 2023 16:34:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 275484] x11-toolkits/wxgtk32 fails build, when built without WAYLAND Date: Sat, 02 Dec 2023 16:34:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch, patch-ready X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mi@ALDAN.algebra.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275484 Bug ID: 275484 Summary: x11-toolkits/wxgtk32 fails build, when built without WAYLAND Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch, patch-ready Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: desktop@FreeBSD.org Reporter: mi@ALDAN.algebra.com Assignee: desktop@FreeBSD.org Flags: maintainer-feedback?(desktop@FreeBSD.org) Created attachment 246724 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D246724&action= =3Dedit Only refer to gs_alreadySetSwapInterval, when building for Wayland The error is in the upstream code -- an attempt is made to unconditionally reference a local variable, which is only defined, when GDK_WINDOWING_WAYLA= ND is defined: ``` /n/home/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/bk-deps c++ -c= -o gldll_glegl.o=20=20=20=20=20=20=20=20 -I/n/home/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib/wx/inclu= de/gtk3-unicode-3.2 -I./include -DLIBICONV_PLUG -isystem /opt/include -I/opt/include -D_FILE_OFFSET_BITS=3D64 -I/opt/include/gtk-3.0 -I/opt/include/pango-1.0 -I/opt/include/cairo -I/opt/include/gdk-pixbuf-2.0 -I/opt/include/freetype2 -I/opt/include/harfbuzz -I/opt/include/dbus-1.0 -I/opt/lib/dbus-1.0/include -I/opt/include/glib-2.0 -I/opt/lib/glib-2.0/include -I/opt/include/atk-1.0 -pthread -I/opt/include/pixman-1 -I/opt/include/libpng16 -D_THREAD_SAFE -I/opt/include/gio-unix-2.0 -I/opt/include/fribidi -I/opt/include/at-spi2-atk/2.0 -I/opt/include/at-spi-2.0 -D__WXGTK__=20=20= =20=20=20 -DWXBUILDING -DWXUSINGDLL -DWXMAKINGDLL_GL -fPIC -DPIC -pthread -D_THREAD_S= AFE -Wall -Wundef -Wunused-parameter -Wno-ctor-dtor-privacy -Woverloaded-virtual -Wno-deprecated-declarations -I/opt/include/pango-1.0 -I/opt/include -I/opt/include/harfbuzz -I/opt/include/freetype2 -I/opt/include/glib-2.0 -I/opt/lib/glib-2.0/include -I/opt/include/cairo -I/opt/include/pixman-1 -I/opt/include/fribidi -I/opt/include/libpng16 -I/opt/include/gdk-pixbuf-2.0 -I/opt/include/gtk-3.0/unix-print -I/opt/include/gtk-3.0 -I/opt/include/dbus-1.0 -I/opt/lib/dbus-1.0/include -I/opt/include/atk-1.0 -I/opt/include/gio-unix-2.0 -I/opt/include/at-spi2-atk/2.0 -I/opt/include/at-spi-2.0 -I/opt/include/gspell-1 -I/opt/include/enchant-2 -I/opt/include/libsecret-1 -O2 -pipe -march=3Dsandybridge -DLIBICONV_PLUG -fstack-protector-strong -isystem /opt/include -fno-strict-aliasing -std=3D= c++11 -I/opt/include/webkitgtk-4.0 -I/opt/include/libsoup-2.4 -I/opt/include/libx= ml2 -I/opt/include/gstreamer-1.0 -I/opt/include/orc-0.4 -fvisibility=3Dhidden -fvisibility-inlines-hidden -DLIBICONV_PLUG -isystem /opt/include -O2 -pipe -march=3Dsandybridge -DLIBICONV_PLUG -fstack-protector-strong -isystem /opt/include -fno-strict-aliasing -DLIBICONV_PLUG -isystem /opt/include -std=3Dc++11 ./src/unix/glegl.cpp (if test -f utils/wxrc/Makefile ; then cd utils/wxrc && gmake all ; fi) gmake[3]: Entering directory '/n/home/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/utils/wxrc' gmake[3]: Nothing to be done for 'all'. gmake[3]: Leaving directory '/n/home/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/utils/wxrc' ./src/unix/glegl.cpp:813:11: error: use of undeclared identifier 'gs_alreadySetSwapInterval' if ( !gs_alreadySetSwapInterval.count(this) ) ^ ./src/unix/glegl.cpp:822:13: error: use of undeclared identifier 'gs_alreadySetSwapInterval' gs_alreadySetSwapInterval.insert(this); ^ 2 errors generated. ``` The patch makes the troublesome section conditional on the same define -- t= he comments indicate, that section should be WAYLAND-only -- and also changes = the variable's definition to static, because it is not referenced anywhere else= in the code. I'll try to submit it upstream too. --=20 You are receiving this mail because: You are the assignee for the bug.=