maintainer-feedback requested: [Bug 266558] graphics/cairo DOCS option - Coordinating GNOME_HTML_DIR for Makefile and DOCSDIR for pkg-plist
Date: Fri, 23 Sep 2022 03:04:57 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-desktop (Team) <desktop@FreeBSD.org> for maintainer-feedback: Bug 266558: graphics/cairo DOCS option - Coordinating GNOME_HTML_DIR for Makefile and DOCSDIR for pkg-plist https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266558 --- Description --- After beginning a ports upgrade this week, I noticed that the docs option has been updated for graphics/cairo. Candidly, it seems that I'll have to catch up with my ports email, for any info/follow through about the docs patches. In review of my earlier patch, I guess this is a sort of patch update? Presently, I wasn't able to install the updated graphics/cairo port with the updated docs option enabled. To my best estimate: With DOCSDIR set to ${PREFIX}/share/gtk-doc/html and that being used in a similar way to GNOME_HTML_DIR from /usr/ports/Mk/Uses/gnome.mk then the docs are then installed under ${PREFIX}/share/gtk-doc/html/cairo. The pkg-plist is set to locate the docs directly in ${DOCSDIR} however. At the time when I'd sent the earlier patch, I believe I wasn't then aware of how GNOME_HTML_DIR is used in gnome.mk. /usr/ports/Mk/Uses/gnome.mk will pass GNOME_HTML_DIR as the --with-html-dir to configure. With the attached diff, graphics/cairo would use a DOCSDIR as ${GNOME_HTML_DIR}/${PORTNAME} and a GNOME_HTML_DIR as ${PREFIX}/share/gtk-doc/html. The gtk-doc files can then be located without update to the pkg-plist Thx for noticing the patch! [1] https://gitlab.com/FreeBSD/freebsd-ports/-/blob/main/graphics/cairo/Makefile