From nobody Fri May 28 03:42:30 2021 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C5F55BFEFC2; Fri, 28 May 2021 03:42:33 +0000 (UTC) (envelope-from nc@freebsd.org) Received: from rainpuddle.neelc.org (rainpuddle.neelc.org [66.42.69.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Frr9P4kjkz3nY9; Fri, 28 May 2021 03:42:33 +0000 (UTC) (envelope-from nc@freebsd.org) Received: from mail.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) by rainpuddle.neelc.org (Postfix) with ESMTPSA id 64C27EB2A5; Thu, 27 May 2021 20:42:30 -0700 (PDT) List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 Date: Thu, 27 May 2021 20:42:30 -0700 From: Neel Chauhan To: koobs@freebsd.org Cc: ports-committers@freebsd.org, freebsd-ports@freebsd.org, portmgr@freebsd.org, gnome@freebsd.org, desktop@freebsd.org Subject: Re: An apology about my commits In-Reply-To: <303b9900-d008-78a7-b3bf-ffb33284a4ee@FreeBSD.org> References: <600673282f5cd5864a67655c4e156f26@freebsd.org> <303b9900-d008-78a7-b3bf-ffb33284a4ee@FreeBSD.org> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <8a8bf788f5deef5d83e9fcb5daa52f50@freebsd.org> X-Sender: nc@freebsd.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Frr9P4kjkz3nY9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N > It's your thoughts and care that count Neel, don't feel guilty. Thanks! > The responses you received could have been a bit more 'matter of fact'. > > What was *actually* important about the replies was 'we should be > QA'ing everything and getting more than one persons eyes on things'. True, especially for big packages like GNOME, KDE, Mozilla, Xorg, or LibreOffice. Sometimes, I get trigger-happy. But I really shouldn't, well unless it's a hobby project on GitHub. > Note (for everyone), some of the biggest impacts are caused by the > smallest commits. > > The idea of a 'trivial update' needs to be related to the dustbin, and > we're still hearing it often. +1 I've had "trivial updates" that broke things, both in and outside FreeBSD. I've had code broken at my $DAYJOB, and that a Microsoft SaaS product (not a household name product like Windows or Word, but still). I was a major Tor contributor from 2017-2020 and had bad patches that broke things or add bugs get in, and that with Tor being very security-focused. And hey, it's not like I'm pulling a University of Minnesota "research project" where the goal is to intentionally add bugs to the Linux kernel. -Neel