From nobody Sun Jan 05 17:14:33 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YR3pK4Tf9z5jySn for ; Sun, 05 Jan 2025 17:14:49 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YR3pJ5KBrz49Bc; Sun, 5 Jan 2025 17:14:48 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=asomers@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so26018783a12.1; Sun, 05 Jan 2025 09:14:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736097286; x=1736702086; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZIv02U8420QRTxDz3AdIZLAatLvCZOkuiUW3QAcwDU0=; b=PYOwZjV+a2Rst3GqP/sxiCrsEkho34Lkdv0LfC2qnz+jjmhgx4Rd5fqnaKup5SP9lb wY5AMElU+L4VGhNFB4NmLd4wLo82MSR0EPCGgdyid+jth7MmQPnkqSoZXvIYtJS+tWGc Rt7rhRGYfFIAUBHxpFV6Be/5AMerQOA49JZ/jQxQq+cVFjkXngo9rOGZEtUwGZfbnfqo 0PyDzUHOrYQUiqVdtZd4bbuRpLBogPkmXR8KQDeSX67CgfbSPFRpKoyUrin1IlTXgKyE KQaaFd0D7DP4dfEm1Wl4wPzBZhZdm4vxDX0zba3RAFcxKu4uXI6Kf5i4pjxyw26JI0t0 LNBg== X-Forwarded-Encrypted: i=1; AJvYcCWBnDtp++cEd3yp7TV0a1aMUm70Z785uLqSNicaRuIOG/TAK393MvWMRGqAca5Dt0D0ZQRI5w==@freebsd.org, AJvYcCXzyaEeE9bggghig8L1D1kqaX/f7szsCSpHKgKr6dy4GfDWjAt4UcHizoFh0qdpJ2L6fSHYd+X4J5HfMCoPf98=@freebsd.org X-Gm-Message-State: AOJu0YxlSU682HKaI4MTkso9igkg5tZS9vMmv9bdH0C2sWjEi0wMV6B5 Nf+aIP3YRM+zgBV2ZPPNHqmm+oz5S9wQOCLiF1sVK8eXPxrw/j21yKX7ZWVtu+sS7Z4lHbIlOH0 nnsTFC/j/IHtKNfNLAPHWynJEyYHoCCoB X-Gm-Gg: ASbGncvfTSKHWoN/nEX8ouCl/nI+I3zaQxiNMlpcdkfMKdpOTif+34UefxzL4g3TlFS uWfZq6Cuvo1UA78gm6bQE9F0/+1a1wnAZ+u1VcQ== X-Google-Smtp-Source: AGHT+IGW31s+9ZqkBgsHFKGFgjruFcnuycdBK2j4GY6FRcrWsuUA9TAQQOUWaZdGEh2G3N+OLQ8mB0CAPyI08qlgK6E= X-Received: by 2002:a05:6402:458c:b0:5d9:c2f:a961 with SMTP id 4fb4d7f45d1cf-5d90c2fa9famr9972093a12.11.1736097285428; Sun, 05 Jan 2025 09:14:45 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <94D96FE6-BFB6-4629-A9EA-32168741861E@freebsd.org> In-Reply-To: <94D96FE6-BFB6-4629-A9EA-32168741861E@freebsd.org> From: Alan Somers Date: Sun, 5 Jan 2025 10:14:33 -0700 Message-ID: Subject: Re: Building multiple kernels with "make release" To: Glen Barber Cc: Emmanuel Vadot , Miroslav Lachman <000.fbsd@quip.cz>, Juraj Lutter , FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4YR3pJ5KBrz49Bc X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.77 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.87)[-0.871]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FREEFALL_USER(0.00)[asomers]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_ONE(0.00)[1]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.41:from]; ARC_NA(0.00)[]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.41:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCPT_COUNT_FIVE(0.00)[5] To resurrect this old thread, I got it working. I can now run release.sh and it will build .iso files and VM images that contain two kernels. My PR is at https://github.com/freebsd/freebsd-src/pull/1566 . On Sat, Aug 21, 2021 at 11:14=E2=80=AFAM Glen Barber wrot= e: > > It is on my list of things to look into next week. > > Glen > Sent from my phone. > Please excuse my brevity and/or typos. > > On Aug 20, 2021, at 4:10 PM, Alan Somers wrote: > > =EF=BB=BF > On Thu, Jul 29, 2021 at 12:43 PM Emmanuel Vadot w= rote: >> >> On Thu, 29 Jul 2021 00:13:54 +0000 >> Glen Barber wrote: >> >> > On Wed, Jul 28, 2021 at 06:00:28PM -0600, Alan Somers wrote: >> > > On Wed, Jul 28, 2021 at 5:52 PM Miroslav Lachman <000.fbsd@quip.cz> = wrote: >> > > >> > > > On 28/07/2021 20:46, Juraj Lutter wrote: >> > > > > >> > > > > >> > > > >> On 28 Jul 2021, at 20:37, Glen Barber wrote: >> > > > >> >> > > > >> On Wed, Jul 28, 2021 at 12:05:25PM -0600, Alan Somers wrote: >> > > > >>> On Wed, Jul 28, 2021 at 11:57 AM Glen Barber = wrote: >> > > > >>>> Just on a hunch, could you try with adding INSTALLKERNEL=3D"$= {KERNEL}" >> > > > to >> > > > >>>> your release.conf? >> > > > >>>> >> > > > >>>> I now seem to recall some weirdness with this, but the exact = details >> > > > >>>> elude me at the moment. >> > > > >>>> >> > > > >>> >> > > > >>> Setting INSTALLKERNEL=3D"GENERIC-NODEBUG" during "make instal= lkernel" >> > > > >>> overrides whatever KERNCONF was set to. But it still only ins= talls one >> > > > >>> kernel. Trying to set that variable to a list doesn't work. >> > > > >> >> > > > >> Ok. Give me a day or so to try to figure out what is (or isn't= ) >> > > > >> happening here. I do not recall any recent-ish changes that wo= uld have >> > > > >> caused this, and I am 95% certain it has worked in the past. >> > > > > >> > > > > According to Makefile.inc1: >> > > > > >> > > > > make installkernel KERNCONF=3D?KERN1 KERN2? >> > > > > >> > > > > should install KERN1 and KERN2. Similar goes for buildkernel. >> > > > > >> > > > > Or is there something I am missing? >> > > > >> > > > Does 'make installkernel KERNCONF=3D?KERN1 KERN2?' really install = both >> > > > kernels? Under which names? >> > > > I have 3 kernels defined in KERNCONF in /etc/make.conf for years. = 3 >> > > > kernels are built by "make buildkernel" but only one installed by = "make >> > > > installkernel". >> > > > >> > > > To install other kernels I use: >> > > > >> > > > make installkernel KERNCONF=3DKERN2 KODIR=3D/boot/kernel.KERN2 >> > > > >> > > > make installkernel KERNCONF=3DKERN3 KODIR=3D/boot/kernel.KERN3 >> > > > >> > > >> > > Miroslav is right. Despite the comment that Juraj found, "make >> > > installkernel" only installs the first kernel listed in KERNCONF. >> > >> > Good find. I honestly thought this worked as expected versus as >> > written. In fact, I *thought* secondary, tertiary, etc. kernels were >> > installed as /boot/kernel.KERN2, /boot/kernel.KERN3 (using the example >> > above). >> >> You need to set NO_INSTALLEXTRAKERNELS=3Dno for that to happens (yes th= e >> variable name and double no sucks if anyone have a patch for that that >> would be awesome). >> >> > Although, I may be misremembering, and 'kernel.KERN2.txz' may be creat= ed >> > instead, although not installed/extracted. Though, we are going back = at >> > least seven years, and I do not even remember what I had eaten for >> > dinner last night, so there's that... >> > >> > Glen >> > >> >> >> -- >> Emmanuel Vadot > > > NO_INSTALLEXTRAKERNELS=3Dno works for "make installkernel". However, it= still doesn't work with release.sh. It seems there is work left to do. > -Alan