From nobody Fri Oct 25 22:10:58 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XZxnV3WMkz5bBwx for ; Fri, 25 Oct 2024 22:11:10 +0000 (UTC) (envelope-from oleglelchuk@gmail.com) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XZxnV1dPNz42jx for ; Fri, 25 Oct 2024 22:11:10 +0000 (UTC) (envelope-from oleglelchuk@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-6cc03b649f2so14793296d6.3 for ; Fri, 25 Oct 2024 15:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729894269; x=1730499069; darn=freebsd.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=7i/MPVkuibLBVJkI5krjZgIuQh0TpnGily1WD/P5oTw=; b=FwYfMpmA9lEEkncUVi0h9ol2wsWZmo8UoxZ4nvd+k80eJJafdxq9s1rrlAkua2l9XH z7mkUqEl5hzfyIuNjkxMHjEhSkfz9oBnMnxGYGiUfIba2NXpnySEu/4tiU5G68EwveTs k6PSWzgxEXIGdXxL4DI/n9DENeSAp5il9d9PWhePjwdyevgUNkbZihFm1PyYlNuHU38C wtUELk3J6LKsrxJTUZvhhL5RAK6xnSSZ2KTjO2mPnqGGcpco0QCrG3O5CxsLwG1jhtGZ h20Jt1xdle7VirSj7ECrKv5NYLpeSfGwFlPNOZStZiYqwW1PidmmFsEUmh2DOJbYFLSZ BspQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729894269; x=1730499069; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7i/MPVkuibLBVJkI5krjZgIuQh0TpnGily1WD/P5oTw=; b=YEEQXdtS27E4cybw732hjBeRUd77z8YE4vrowoqI+QRJaBVQIC3IQni5ArACR5dFQS 4iswVS/rFkDaWYlmv9UoSQO44fnrkmVgeojfwjBD/m/GADcrnfCN6a1WTaEdAOFWYMkQ VdwkBgnECzhuF5J/DDpVjidMlMc8LI8bCz4BKMOL7ssuj1FyNniKa6bAJoxuIpHjwD+9 U9ZeqY/+uTxzBEElVQHNCsoER0C5fh2o8/2uC218aurn+kJzI3gynpoIVTgcVRMkrMD5 iF6S1f3obG9CEdU2zpSbV2c5TXFTJBrH33gPZ+b9IrnrOk8JKB5hsDP5koXeU2SE2WTP +AtA== X-Forwarded-Encrypted: i=1; AJvYcCXXhXB+l07it+YOiEscZaozm08Uw71Qrtg/KzNOCO6QbqWPCa83DRZIPh2X9YWu0Ts7jTTlMOu+@freebsd.org X-Gm-Message-State: AOJu0YyCJzziTU8mtXWwiG0HjlHjLbk/tKHMQ1EQgmsN/s4pLrge9hCq 2frso2f7SsZiCVQNraLXFuTp1eZyj98Ml/LUwDskDLbGXHgA13yKsxXQBp8itcAaENL/F3EZqQr 3JmuMRgupcepkiV0iXaQ0JzsFz4fUeP+YkbQ= X-Google-Smtp-Source: AGHT+IGQClH1MNH6opTnbcaIJAegYmGfw81QRQyVIahoCLru4S8iLm+gXQtw5GsOiBk/FrQ2i2tD3qinPJAh58elMGQ= X-Received: by 2002:a05:6214:320b:b0:6c7:c5b5:a78d with SMTP id 6a1803df08f44-6d1856e7041mr12189166d6.18.1729894269162; Fri, 25 Oct 2024 15:11:09 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Oleg Lelchuk Date: Fri, 25 Oct 2024 18:10:58 -0400 Message-ID: Subject: Re: Problem (re)building graphics/drm-61-kmod via PORTS_MODULES+= To: David Wolfskill , Robert Clausecker , current@freebsd.org, Benjamin Jacobs Content-Type: multipart/alternative; boundary="000000000000699ca306255465da" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XZxnV1dPNz42jx X-Spamd-Bar: ---- --000000000000699ca306255465da Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable With clang 19, I can build i1915kms from https://github.com/freebsd/drm-kmod.git and I won't encounter any issues. However, with the port version of drm-61-kmod, I would still encounter an error. I think this happens because the port wants to build stuff in the linuxkpi_video directory, but with the master branch of github.com/freebsd/drm-kmod.git, I can just skip building linuxkpi_video and everything will be fine. This situation was observed after https://github.com/freebsd/drm-kmod/commit/5b2279ae2a59b653a3a553a8a8399e5e= 89bb2b90 commit was added and after https://cgit.freebsd.org/ports/commit/?id=3Da247eb9392542aeb11dc6d13778b59b= b4bce2d19 commit was added. On Fri, Oct 25, 2024 at 6:23=E2=80=AFAM David Wolfskill wrote: > On Fri, Oct 25, 2024 at 09:20:16AM +0200, Robert Clausecker wrote: > > Hi David, > > ... > > The same issue was reported in another thread. Try this workaround: > > Aye; saw that, tried it, and it works for me (modulo MUA-mangling of > whitespace). > > Here's a representation of what I used: > > diff --git a/graphics/drm-61-kmod/Makefile b/graphics/drm-61-kmod/Makefil= e > index 6db21111f255..596cdb20d13b 100644 > --- a/graphics/drm-61-kmod/Makefile > +++ b/graphics/drm-61-kmod/Makefile > @@ -49,6 +49,8 @@ PLIST_SUB+=3D I915=3D"@comment " > > MAKE_ENV+=3D MAKEOBJDIRPREFIX=3D${WRKSRC}/obj > > +post-patch: > + ${MKDIR} ${WRKSRC}/linuxkpi/dummy/include > pre-build: > ${MKDIR} ${WRKSRC}/obj > (cd ${WRKSRC} ; ${SETENV} ${MAKE_ENV} ${MAKE_CMD} obj) > > > > Thanks! > > Peace, > david > -- > David H. Wolfskill david@catwhisker.org > It has been said that history repeats itself. This is perhaps not quite > correct; it merely rhymes. -- Theodor Reik > > See https://www.catwhisker.org/~david/publickey.gpg for my public key. > --000000000000699ca306255465da Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
With clang 19, I can build i1915kms from=C2=A0https://github.com/freebsd/drm-kmod= .git and I won't encounter any issues. However, with the port versi= on of drm-61-kmod, I would still encounter an error. I think=C2=A0this happ= ens because the port wants to build stuff in the linuxkpi_video directory, = but with the master branch of github.com/freebsd/drm-kmod.git, I can just skip building linuxkp= i_video and everything will be fine. This situation was observed after=C2= =A0https://github.com/freebsd/drm-kmod/commit/5b2279ae= 2a59b653a3a553a8a8399e5e89bb2b90 commit was added and after=C2=A0https://cgit.freebsd.org/ports/commit/?id=3Da247eb9392542ae= b11dc6d13778b59bb4bce2d19 commit was added.

On Fri, Oct 25, 2024 at 6:23= =E2=80=AFAM David Wolfskill <dav= id@catwhisker.org> wrote:
On Fri, Oct 25, 2024 at 09:20:16AM +0200, Robert Clausecke= r wrote:
> Hi David,
> ...
> The same issue was reported in another thread.=C2=A0 Try this workarou= nd:

Aye; saw that, tried it, and it works for me (modulo MUA-mangling of
whitespace).

Here's a representation of what I used:

diff --git a/graphics/drm-61-kmod/Makefile b/graphics/drm-61-kmod/Makefile<= br> index 6db21111f255..596cdb20d13b 100644
--- a/graphics/drm-61-kmod/Makefile
+++ b/graphics/drm-61-kmod/Makefile
@@ -49,6 +49,8 @@ PLIST_SUB+=3D=C2=A0 =C2=A0I915=3D"@comment "
=C2=A0MAKE_ENV+=3D=C2=A0 =C2=A0 =C2=A0MAKEOBJDIRPREFIX=3D${WRKSRC}/obj

+post-patch:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${MKDIR} ${WRKSRC}/= linuxkpi/dummy/include
=C2=A0pre-build:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${MKDIR} ${WRKSRC}/= obj
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (cd ${WRKSRC} ; ${S= ETENV} ${MAKE_ENV} ${MAKE_CMD} obj)



Thanks!

Peace,
david
--
David H. Wolfskill=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 david@catwhisker.org
It has been said that history repeats itself. This is perhaps not quite
correct; it merely rhymes. -- Theodor Reik

See https://www.catwhisker.org/~david/publickey.gpg for my public key.
--000000000000699ca306255465da--