From nobody Wed Nov 27 21:56:56 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XzCw600csz5fr2Y for ; Wed, 27 Nov 2024 21:57:10 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XzCw52PDMz4RCq for ; Wed, 27 Nov 2024 21:57:09 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=TZzaerRD; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2a00:1450:4864:20::536 as permitted sender) smtp.mailfrom=rick.macklem@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5cefa22e9d5so198701a12.3 for ; Wed, 27 Nov 2024 13:57:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732744628; x=1733349428; darn=freebsd.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=xQn+3UnVn6LOCCInVQ4cCDqgSyMHjL43Cr267bTv6Os=; b=TZzaerRD568vp61iAvVUlhUJlsE/5Vt/9cGLkByn3iC2D84Y6SMdBft9e0QP6eDYyC tpMkwfzeDL7KgIsGYBWaPuyH9PKcCkk8hFKyyvut3qQz/jIjm/S8EPgaEJCvFF0KFgk1 WGWmDgWaeLA1tbJmukeJjZG/ED/XYX+CCSiS7H9BBrkX9U3DnbmxOqIwTqTWUMcwbpqN LkKRs5szZZbvWuqL2UYpjfRtQpPhtMj0q8nPnIy8/QktePmQLr8RbCzc6xTTAvRSS5ep 2vaWcUfd6fLNLVs60mha9VFD5z2bMkAa9ESwdyOtKwNlaxqvzVdpuwT/SgC6LBiG8bZG YuSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732744628; x=1733349428; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xQn+3UnVn6LOCCInVQ4cCDqgSyMHjL43Cr267bTv6Os=; b=M4weRBiuzt1vghydpZTbOg4nZJLV6mA0vwWfq5sF5kGdIiUHi6hTn+4KMzzOn6Xt22 VHyJCKM122Wbe3Qef+5xTQ5H0QzrzE850etME+0QtnNiJcwqdmZ6W7KHkGh3fpK/DT8+ o85iz0FTojAFS6J67QHvkEJZIZq+Unyc3ncoq/SX0LUrEiUBgZdCZL36bSqaeV2uySCH vF83dBhImReofAN8JtlS+kQfrvixJh+j+EnDycffBe585oHDVKvDqItjmQ7jlXdroHPt GuuIJTzx0EgB8xPIShPHSyNa76mtqhrc6f9kPQHIH5aIRylbuP7wRKy++CLYNUvJUz6p 01Kg== X-Gm-Message-State: AOJu0YwvaCZr8IgykFsF7BR5RL5kYWhFfANkB0lUaOYpill2tAlJpstB 48WPePqLT4L/uo9AIOYIrGqJ295i+hzr7qlzfTGknKJLad9BP0V0KLTyO4pgGHry/EnB3I3ar7F u5qh1UtzUwiCngihWU01NKE7P96DL X-Gm-Gg: ASbGncvf8iVeXskDGjpjuqmugf5+MX7xrg7mLDRwuH9tXnUq25TPvgY5FL4cO89A3QE l4VDoAl5Gd/jpoRpeqtcb9DA42jxA+4ORRaqLXX2GK043SmafxHGiII+zNBGe5lY= X-Google-Smtp-Source: AGHT+IFg9dUu4YjRziNG9OXImi/xD4KbC2fPjETIk7WTyypPbTrTuVj4ZGdACOgE+xU5mOnRl1CDakHxUOSK9cjrODU= X-Received: by 2002:a05:6402:3489:b0:5cf:e460:43e2 with SMTP id 4fb4d7f45d1cf-5d080bcbf9cmr4073454a12.15.1732744627709; Wed, 27 Nov 2024 13:57:07 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 From: Rick Macklem Date: Wed, 27 Nov 2024 13:56:56 -0800 Message-ID: Subject: RFC: fixing PR#282995 To: FreeBSD CURRENT Cc: Michael Proto Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-3.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.951]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; TO_DN_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TAGGED_FROM(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::536:from] X-Rspamd-Queue-Id: 4XzCw52PDMz4RCq X-Spamd-Bar: --- Hi, PR#282995 reports that the "-alldirs" export option is broken, since it allows an export where the directory path is not a mount point. I'll admit I did not recall this semantic for -alldirs and I now see it is only documented in the "Examples" section of exports(5). Looking at the code, it appears this was broken between releng1 and releng2.0 (about 30years ago) when the call to mount(2) in mountd.c was changed from using the path in the exports line to using f_mntonname. (The check for "it is a mount point" depended on mount(2) failing because the path was not a mount point.) I do believe the semantic is a useful one, although making it that way after 30years might be construed as a POLA violation? So, what do others think I should do with this? (A) - Patch mountd to enforce the "must be a mount point when -alldirs is specified, plus update exports(5) to state this semantic clearly. or (B) - Patch mountd so that it enforces "must be a mount point when -alldirs is specified, but only enabled via a new mountd command line option. --> ie. Leave the default as not enforced, but allow enforcement based on a new mountd option. - Document this in both exports(5) and mountd(8). or ??? Thanks in advance for your comments, rick