Re: panic after a97f683fe3c425

From: Oleksandr Kryvulia <shuriku_at_shurik.kiev.ua>
Date: Thu, 07 Nov 2024 20:27:30 UTC
07.11.24 22:03, Mark Johnston:
> On Thu, Nov 07, 2024 at 09:43:50PM +0200, Oleksandr Kryvulia wrote:
>> Hi, @current
>>
>> My laptop now panics while boot with [1].
>> git bisect shows a97f683fe3c425b425cf8cc466319f54ea957c20 as offending
>> commit.
>>
>> [1] https://imgur.com/a/Pb6eakW
> I believe the patch below will fix the problem.
>
> diff --git a/sys/amd64/vmm/vmm.c b/sys/amd64/vmm/vmm.c
> index 77e0adda86f5..9569f8ace909 100644
> --- a/sys/amd64/vmm/vmm.c
> +++ b/sys/amd64/vmm/vmm.c
> @@ -513,8 +513,9 @@ static moduledata_t vmm_kmod = {
>    *
>    * - VT-x initialization requires smp_rendezvous() and therefore must happen
>    *   after SMP is fully functional (after SI_SUB_SMP).
> + * - vmm device initialization requires an initialized devfs.
>    */
> -DECLARE_MODULE(vmm, vmm_kmod, SI_SUB_SMP + 1, SI_ORDER_ANY);
> +DECLARE_MODULE(vmm, vmm_kmod, MAX(SI_SUB_SMP, SI_SUB_DEVFS) + 1, SI_ORDER_ANY);
>   MODULE_VERSION(vmm, 1);
>   
>   static void
>

Yes, your patch solves a panic.
Thank you!