From nobody Thu Nov 07 20:03:43 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XktLY3dXJz5cWZ0 for ; Thu, 07 Nov 2024 20:03:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XktLX3qXWz4pjY for ; Thu, 7 Nov 2024 20:03:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3e5fa17a79dso967599b6e.1 for ; Thu, 07 Nov 2024 12:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731009827; x=1731614627; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=mxr9tDZI9cfx4k84fCIvhQgthtrwVIm9XYF+qxFw94g=; b=b90TTXC3zdS4uDgrCFfGTMjgskaBMrI+vvF9yzVDoDuEDcH3w8iOplHua69Cxi9u3j V5m5/IuOc7pegiVLJ5zfLX4/hfV3LSPuYzzlI2Pe15fGJK0C2cIkPMJpMqUJgAV4Nd3j aCShfXrfuduiyaXLWSHEyGoMDJpQRBDQXA/Y/Sp4boSR12xtJ+E9o7S171wYCer5taCh OQjZLxI3L67xAOx8xK9Vd1r6PW5BcbCGc1QVGNmvVSTsTDlx9B55hF6GEWWKAiNNNyzD Z0bbyexPrs9dwPfhB2GKmD8oCrPyaZKpmiDcIZ2IOv81CTseeguE8ZJs8ibq9TIJSNO3 Kaaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731009827; x=1731614627; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mxr9tDZI9cfx4k84fCIvhQgthtrwVIm9XYF+qxFw94g=; b=HDQ4X5ty7hUD9v6/7nLlLfx3hmlx/vGomBd39aRv+YlPEpFyPPDsAEfV8AbD5fT6kU 0mJVSXBrP30H7UJPEm/lIWnxpaQzdvYy6nnb5JqhgMeRdOmz5ha9U9kqB9Vzf74fIrjl ncYeRnoCdMIk7y6BnR4HEZdP/MZiFs3CR+9naJXCxKaQehEJ2ZneVg0n9MMhbDxOIbm5 mf9i5Mn+zKzfx/Bbqg2Wh1kg1pYGN9cEXS68mTCxri0tvIMU5o0i9oXd1GBuy4u0GHhM NlpueM4HdS69cHKU9HHHruomFgHLDCeXna+LjyHv7DohX6xO/PUDHHULAoNYi4fEpiOt VIeQ== X-Gm-Message-State: AOJu0YzkrlJtYaVBf8sBmWVWatBevDbiiZs/eLg9C2GQyUUnIFLbbIyF 3MZar4DbbtQTo0EcGvH69h8o9uwnYz7V8ILtuZ1RE8VqAIuY1stcwlaWMQ== X-Google-Smtp-Source: AGHT+IE4LHzW96TeF+KzZvyV0eF+8Vn4Hxu1sKV27QGUjJjizYb3cPZuKYTk29QcuI1M99soTqty3g== X-Received: by 2002:a05:6808:15a8:b0:3e5:f534:ddc4 with SMTP id 5614622812f47-3e79458571fmr564819b6e.13.1731009827426; Thu, 07 Nov 2024 12:03:47 -0800 (PST) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4de5f7e35c4sm447158173.3.2024.11.07.12.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 12:03:47 -0800 (PST) Date: Thu, 7 Nov 2024 15:03:43 -0500 From: Mark Johnston To: Oleksandr Kryvulia Cc: FreeBSD Current Subject: Re: panic after a97f683fe3c425 Message-ID: References: <95a67972-ea73-4821-bbec-3c8857b1f2f4@shurik.kiev.ua> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95a67972-ea73-4821-bbec-3c8857b1f2f4@shurik.kiev.ua> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XktLX3qXWz4pjY X-Spamd-Bar: ---- On Thu, Nov 07, 2024 at 09:43:50PM +0200, Oleksandr Kryvulia wrote: > Hi, @current > > My laptop now panics while boot with [1]. > git bisect shows a97f683fe3c425b425cf8cc466319f54ea957c20 as offending > commit. > > [1] https://imgur.com/a/Pb6eakW I believe the patch below will fix the problem. diff --git a/sys/amd64/vmm/vmm.c b/sys/amd64/vmm/vmm.c index 77e0adda86f5..9569f8ace909 100644 --- a/sys/amd64/vmm/vmm.c +++ b/sys/amd64/vmm/vmm.c @@ -513,8 +513,9 @@ static moduledata_t vmm_kmod = { * * - VT-x initialization requires smp_rendezvous() and therefore must happen * after SMP is fully functional (after SI_SUB_SMP). + * - vmm device initialization requires an initialized devfs. */ -DECLARE_MODULE(vmm, vmm_kmod, SI_SUB_SMP + 1, SI_ORDER_ANY); +DECLARE_MODULE(vmm, vmm_kmod, MAX(SI_SUB_SMP, SI_SUB_DEVFS) + 1, SI_ORDER_ANY); MODULE_VERSION(vmm, 1); static void