Re: July 2024 stabilization week

On 7/31/24 14:31, Gleb Smirnoff wrote:
> On Tue, Jul 30, 2024 at 05:05:33PM -0500, Kyle Evans wrote:
> K> > > commit ce220b82ad546d3518a805750e5ee6add73f1fbf
> K> > > Author: Alfonso Siciliano <alf.siciliano@gmail.com>
> K> > > Date:   Sat May 25 02:42:46 2024 +0200
> K> > >
> K> > >      change: --form and --mixedgauge do not print field input to output if <fi
> K> > > eldlen> <= 0
> K> > >
> K> > >
> K> > > That means if you have any scripting using 'bsddialog --form' with readonly
> K> > > values, you would need to adjust your scripts, otherwise your variables would
> K> > > be messed up, leading to any possible kind of bugs.
> K> >
> K> > I can't find this revision.
> K> >
> K> > slippy$ git log ce220b82ad546d3518a805750e5ee6add73f1fbf
> K> > fatal: bad object ce220b82ad546d3518a805750e5ee6add73f1fbf
> K> > slippy$
> K> >
> K> > To verify that my repo wasn't damaged in any way I cloned a fresh new repo
> K> > from git.freebsd.org. I still can't list that revision.
> K> >
> K>
> K> It's a bsddialog commit, since the full history isn't preserved in vendor
> K> imports for bsddialog
> K>
> K> https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf
> 
> btw, I'd suggest to switch to subtree merges for future bsddialog imports, so
> that full commit history is preserved.  I can help with that, if needed.
> 

Sorry, to be a bit pedantic: the way it's managed now is still a subtree 
merge, the difference is what's in the vendor branch that's merged in 
(full history vs. release diffs).

> Can you please ack that POLA breakage will be noted in the Release Notes of
> 15.0 and won't be merged to 14.x?
> 
I don't maintain bsddialog imports, just the one that fixed an immediate 
issue for the work I was doing, but Alfonso noted in response to a 
private e-mail thread you started that he'll do both.  He hasn't yet 
responded to current@ as stated in that e-mail, though, AFAICT.

Thanks,

Kyle Evans