From nobody Tue Jul 30 01:02:30 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WXxm42pQyz5SKtR for ; Tue, 30 Jul 2024 01:02:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WXxm335Zyz4N4F for ; Tue, 30 Jul 2024 01:02:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=kYzLeFek; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::535) smtp.mailfrom=wlosh@bsdimp.com Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-7a103ac7be3so2237581a12.3 for ; Mon, 29 Jul 2024 18:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1722301362; x=1722906162; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=31QdxXUrWBEjk9x112sRPI724c2H5ftpEAQkX6cqz+4=; b=kYzLeFekjZ/na9jIMz9e7aTNXDTyiWWcVBaHOZuccx8eeGlAnIAEXMrmUb6dxUJGdu 0wGpNaYMhyJNa7kZq1C7MNjuwUzopALzLFVExyD+xkfe3hiXPnUYuusB/4F8L8uKQbXA Hhc7B7WXFnE2y+8VfBt5AnNR2ZLm2g49grry+VAveKVrVuZ4MELgvCLHIusmAT4xQNn9 lMQWuPMxsJrQpueAQlSxWOoRJ5N5szNzwt0u4LTGOZ5F0xJyYDk8OGZPXGQHxaltj9Do Ht0WlzTvn2j60REosqlI/TheBFyQP8y3sGXtwG0zgWwhWyMzNuCNhyfTg/2Q5r1QBAL7 FHWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722301362; x=1722906162; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=31QdxXUrWBEjk9x112sRPI724c2H5ftpEAQkX6cqz+4=; b=qWz7iFzoHVs+aMedxn5wZeomNZ1B5pOaxkDAxVLMZKVxfFa1yZ/u2/5poZZ+yE3i7v WxpBy9CtGBkOfSo90aK8PzCsZ3nmDwmdF8grLwR+zwHb7jB6aPo5OcM5dYOt2mw6ZiRm 0hUioMmOBp3e2ORO+fDWj3v7AJve7cqYgAiA5o7SlFdPJyzAIcMvTHWVUhWAHJW1iR0h hMGRvIMAvIjMpaSIQzRbcXMaseJCPOcaliNPAykQoYOuO4qm8YOoP5XZGyMJF+zvpHHV Lz0Tf0dM1P4TSW+RmcLwwjzTjbbZ19PvEoxY0lNsZQJXaV34higpyX127dKTCwsZPlc3 Ru+g== X-Gm-Message-State: AOJu0Yw6WyKO+s7K+2P1coPK2o8C5RiBiyal61yPNMhIAqz+yMZfWFNr S9OnflGSu0p/GBjHxRkMp3lZoclgs7p8n++1+vTv1gewKy2WdhEksIa6I+RgGVoUj7c46nLSPnj eju+f8Qg2Cpbsd2em2DiS1mF6iqjCTRNBC44AYtbEpKS9PmR9 X-Google-Smtp-Source: AGHT+IFKrp50yXH0pDqwUu1lyoz9tKwXPTJ2HDDJM9XAriHYZfv4s+5OPgJPmsFoAk7UBxxuIhOlj5QjPGD9caJvIhM= X-Received: by 2002:a17:90a:3048:b0:2cb:4c06:8f11 with SMTP id 98e67ed59e1d1-2cf7e1fcb0amr7500497a91.22.1722301362135; Mon, 29 Jul 2024 18:02:42 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <32DC8FB2-1384-4F15-8232-2606CCAD358E@gmail.com> In-Reply-To: <32DC8FB2-1384-4F15-8232-2606CCAD358E@gmail.com> From: Warner Losh Date: Mon, 29 Jul 2024 19:02:30 -0600 Message-ID: Subject: Re: lua loader failes To: =?UTF-8?B?5YaF6Jek56WQ5LiA6YOO?= Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000e305b3061e6c88e0" X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TAGGED_RCPT(0.00)[]; MISSING_XM_UA(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::535:from]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; ARC_NA(0.00)[]; TO_DN_ALL(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4WXxm335Zyz4N4F --000000000000e305b3061e6c88e0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes. My fault. I'll fix. I thought I'd tested the menu... but apparently not. My apologies. Warner On Mon, Jul 29, 2024, 6:44=E2=80=AFPM =E5=86=85=E8=97=A4=E7=A5=90=E4=B8=80= =E9=83=8E wrote: > Hi, I updated my FreeBSD current machine to the following commit. > > FreeBSD vega.yuisoft.com 15.0-CURRENT FreeBSD 15.0-CURRENT #29 > main-n271492-0eac99f76ec3: Tue Jul 30 08:59:51 JST 2024 > yuichiro@vega.yuisoft.com:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEB= UG > amd64 > > The lua loader fails as follows. > > ERROR: error loading module 'menu' from file '/boot/lua/menu.lua': > /boot/lua/menu.lua:420: '}' expected (to close '{' at line 415) near 'v= i > sible=E2=80=99. > > A comma is probably missing. The following patch works for me. > > diff --git a/stand/lua/menu.lua b/stand/lua/menu.lua > index 66d7fe673023..7d295eeb65eb 100644 > --- a/stand/lua/menu.lua > +++ b/stand/lua/menu.lua > @@ -416,7 +416,7 @@ menu.welcome =3D { entry_typ= e =3D > core.MENU_SEPARATOR, > name =3D function() > return "Loader requires updating" > - end > + end, > visible =3D function() > return core.loaderTooOld() > end > > > =E2=80=94 > Yuichiro NAITO > naito.yuichiro@gmail.com > > > > > --000000000000e305b3061e6c88e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes. My fault. I'll fix. I thought I'd tested the= menu... but apparently not. My apologies.=C2=A0

Warner=C2=A0

<= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 29, 2024, 6:44=E2=80=AFPM = =E5=86=85=E8=97=A4=E7=A5=90=E4=B8=80=E9=83=8E <naito.yuichiro@gmail.com> wrote:
Hi, I updated my FreeBSD current machine to the fol= lowing commit.

FreeBSD vega.yuisoft.com 15.0-CURRENT FreeBSD 15.0-CURRENT #29= main-n271492-0eac99f76ec3: Tue Jul 30 08:59:51 JST 2024=C2=A0 =C2=A0 =C2= =A0yuichiro@vega.yuisoft.com:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEB= UG amd64

The lua loader fails as follows.

ERROR: error loading module 'menu' from file '/boot/lua/menu.lu= a':=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /boot/lua/menu.lua:420: '}= 9; expected (to close '{' at line 415) near 'vi
sible=E2=80=99.

A comma is probably missing. The following patch works for me.

diff --git a/stand/lua/menu.lua b/stand/lua/menu.lua
index 66d7fe673023..7d295eeb65eb 100644
--- a/stand/lua/menu.lua
+++ b/stand/lua/menu.lua
@@ -416,7 +416,7 @@ menu.welcome =3D {=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 entry_type =3D core= .MENU_SEPARATOR,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 name =3D function()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return "Loader requires updatin= g"
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0end
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0end,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 visible =3D function()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return core.loaderTooOld()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 end


=E2=80=94
Yuichiro NAITO
naito.yuichiro@gmail.com




--000000000000e305b3061e6c88e0--