From nobody Thu Jan 25 16:00:31 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TLQXT2Nb3z57WqJ for ; Thu, 25 Jan 2024 16:00:41 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (pdx.rh.CN85.dnsmgr.net [65.75.216.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4TLQXS61pKz50dK; Thu, 25 Jan 2024 16:00:40 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Authentication-Results: mx1.freebsd.org; none Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 40PG0VfM002220; Thu, 25 Jan 2024 08:00:31 -0800 (PST) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 40PG0VMb002219; Thu, 25 Jan 2024 08:00:31 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <202401251600.40PG0VMb002219@gndrsh.dnsmgr.net> Subject: Re: Removing fdisk and bsdlabel (legacy partition tools) In-Reply-To: To: Ed Maste Date: Thu, 25 Jan 2024 08:00:31 -0800 (PST) CC: Warner Losh , FreeBSD Current X-Mailer: ELM [version 2.4ME+ PL121h (25)] List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4TLQXS61pKz50dK X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:10494, ipnet:65.75.216.0/23, country:US] > On Wed, 24 Jan 2024 at 12:30, Warner Losh wrote: > > > > Those are the only users in the tree, but not for long :) > > I have some reviews open to remove some old fdisk / diskabel / > bsdlabel invocations from the tree. > > With those applied, for fdisk I see the following references > (excluding sbin/fdisk/* and comments, old examples, etc.): > > contrib/netbsd-tests/sbin/gpt/t_gpt.sh > tests/sys/cddl/zfs/bin/zpool_smi.ksh > > For bsdlabel / disklabel: > > sbin/growfs/tests/legacy_test.pl > tools/regression/msdosfs/msdosfstest-2.sh > tools/regression/tmpfs/t_vnd > tools/tools/nanobsd/legacy.sh > contrib/netbsd-tests/kernel/t_umount.sh > contrib/netbsd-tests/kernel/t_umountstress.sh > contrib/netbsd-tests/sbin/gpt/t_gpt.sh > sbin/newfs/runtest00.sh > sbin/newfs/runtest01.sh > > These will need to be addressed before actually removing any of these > binaries, of course. You seem to have missed /rescue. Now think about that long and hard, these tools classified as so important that they are part of /rescue. Again I can not stress enough how often I turn to these tools in a repair mode situation. > > I wouldn't object to making these ports, but both these programs use 'sekret' > > bits from the kernel that might not remain exposed as we clean things up. > > Though the IOCTLs they do (or used to do) may no longer be relevant. It's > > been so long that I've forgotten.... > > If we eventually stop exporting those kernel interfaces the tools > would fail anyway, so IMO we can keep providing the kernel interfaces > along with the headers etc, and keep building from source until/unless > we drop support altogether. > > -- Rod Grimes rgrimes@freebsd.org