From nobody Wed Jan 24 20:50:58 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TKx1z2P4Lz58hwF for ; Wed, 24 Jan 2024 20:51:03 +0000 (UTC) (envelope-from SRS0=ISnb=JC=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4TKx1z03WLz4R6D; Wed, 24 Jan 2024 20:51:03 +0000 (UTC) (envelope-from SRS0=ISnb=JC=quip.cz=000.fbsd@elsa.codelab.cz) Authentication-Results: mx1.freebsd.org; none Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 561E2D7890; Wed, 24 Jan 2024 21:51:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1706129460; bh=A2BE7L/IChHRQ1PugV4xMpozE37BZ5eLmHjKJqGAQak=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=JPzsbhh8mvscO0rjCuugTx16H7nyOo2C2YCQxXNI5vG5JcK0FGvbZpFjCXKLz2eze Dj/QY1HIB0duL41Y98E4pMBByXisPWB9ebU2Hz3OWgFhcOla/tz8TeLCEolhseYRgE piy5+gN+uIDTse8y/8EuF/KWnJ8rBfcbnoczsO5I= Received: from [192.168.145.49] (ip-89-177-27-225.bb.vodafone.cz [89.177.27.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 02550D788B; Wed, 24 Jan 2024 21:50:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1706129459; bh=A2BE7L/IChHRQ1PugV4xMpozE37BZ5eLmHjKJqGAQak=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=AVoHW3nH5NHcxsEXgQCnigRClUsMEEYhVHkNzYs35ugduiF1gbq5PD6qCHzX6kvX/ pY+rNneD05WhOANKTvQuqIFXrkQAKxTo5ZChMje+rR9fHUuFNJGAwv0RPa4RQQdA+N INLdqYt1D3rSGomrtdbQbLjNWLrCD7jGCYTIDcF0= Message-ID: Date: Wed, 24 Jan 2024 21:50:58 +0100 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Removing fdisk and bsdlabel (legacy partition tools) Content-Language: cs-Cestina To: "Rodney W. Grimes" , Warner Losh Cc: Ed Maste , FreeBSD Current References: <202401241850.40OIoJ9o098489@gndrsh.dnsmgr.net> From: Miroslav Lachman <000.fbsd@quip.cz> In-Reply-To: <202401241850.40OIoJ9o098489@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4TKx1z03WLz4R6D X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ] On 24/01/2024 19:50, Rodney W. Grimes wrote: >> On Wed, Jan 24, 2024 at 8:45?AM Ed Maste wrote: >> >>> MBR (PC BIOS) partition tables were historically maintained with >>> fdisk(8), but gpart(8) has long been the preferred method for working >>> with partition tables of all types. fdisk has been declared as >>> obsolete in the man page since 2015. Similarly BSD disklabels were >>> historically maintained with bsdlabel. It does not yet have a >>> deprecation notice - I have proposed a man page addition in >>> https://reviews.freebsd.org/D43563. > > man page additions are not going to reach the people who may be > using this. This should be a gonein(15) added to the binary. > I also suspect that all of the people doing ufs installs > are doing so via bsdlabel, not gpart. I have many FreeBSD installations running in a UFS-based VM, created using bsdinstall or manually using gpart. I haven't touched fdisk and bsdlabel in at least a decade. >>> I would like to disconnect these from the build, and subsequently >>> remove them. This is prompted by a recent bsdlabel bug report which >>> uncovered a longstanding buffer overflow in that tool. Effort is much >>> better focused on contemporary, maintained tools rather than >>> investigating issues in deprecated ones. Removing these tools would >>> happen in FreeBSD 15 only (no change in 14 or 13). >>> >>> Code review to disconnect fdisk: https://reviews.freebsd.org/D43575 > > How can you do bsdlabel -A -e /dev/foo with gpart? As far as I know > that functionality never made it to gpart, neither the -A or -e. I was curious what this command does that is so special, but it seems to be of no use anymore: % bsdlabel -A /dev/ada0 bsdlabel: disks with more than 2^32-1 sectors are not supported Do we really need a tool that can't handle disks of average size (in this case 4TB)? Kind regards Miroslav Lachman