From nobody Wed Jan 24 19:28:09 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TKvBP10n7z58Z7M for ; Wed, 24 Jan 2024 19:28:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TKvBN61g8z42jC; Wed, 24 Jan 2024 19:28:12 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id SYfjrzGaIGAIJSiuyrwejz; Wed, 24 Jan 2024 19:28:12 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id SiuwrjyVswbmvSiuxrtbv4; Wed, 24 Jan 2024 19:28:11 +0000 X-Authority-Analysis: v=2.4 cv=O6wqATxW c=1 sm=1 tr=0 ts=65b164cb a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=dEuoMetlWLkA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=9JuoSTmymGmPWKS-4pEA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id EF3AAB4F; Wed, 24 Jan 2024 11:28:09 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 3A57396; Wed, 24 Jan 2024 11:28:09 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ed Maste cc: FreeBSD Current Subject: Re: Removing fdisk and bsdlabel (legacy partition tools) In-reply-to: References: Comments: In-reply-to Ed Maste message dated "Wed, 24 Jan 2024 10:44:57 -0500." List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 24 Jan 2024 11:28:09 -0800 Message-Id: <20240124192809.3A57396@slippy.cwsent.com> X-CMAE-Envelope: MS4xfI5ukHfmGKKNDECFbDuEg7jHkCDso1O2fRt9msSxKUo/ZciMufW+77SD2W3fAH91FffMNu00C/Vld4LfDMiMJJvzGh62aVUreBNNzXLiq6pzF3CBON2h VTgU+n0H0zqcbjgS9WqJWZWi8tX+Xdp6j86oKWaaO0bPDy55IsQ5sceZ5bqIL78r7rHuc1RSiFs/c8+ZicqbuVQxc7Ao3DusGgHPfegkGR+NM+OQGbZdKMFD l4kFmLHi2XO45XJaZz7MIQ== X-Rspamd-Queue-Id: 4TKvBN61g8z42jC X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message , Ed Maste writes: > MBR (PC BIOS) partition tables were historically maintained with > fdisk(8), but gpart(8) has long been the preferred method for working > with partition tables of all types. fdisk has been declared as > obsolete in the man page since 2015. Similarly BSD disklabels were > historically maintained with bsdlabel. It does not yet have a > deprecation notice - I have proposed a man page addition in > https://reviews.freebsd.org/D43563. > > I would like to disconnect these from the build, and subsequently > remove them. This is prompted by a recent bsdlabel bug report which > uncovered a longstanding buffer overflow in that tool. Effort is much > better focused on contemporary, maintained tools rather than > investigating issues in deprecated ones. Removing these tools would > happen in FreeBSD 15 only (no change in 14 or 13). > > Code review to disconnect fdisk: https://reviews.freebsd.org/D43575 > > Note that this effort is limited to these maintenance tools only - > there is no change to kernel or gpart support for MBR or BSD > disklablel partitioning. That said, MBR partitioning and BSD > disklabels are best considered legacy formats and should be avoided > for new installations, if possible. > > If anyone is using fdisk and/or bsdlabel rather than gpart I would > appreciate knowing what is preventing you from using the contemporary > tools. > We need to fix the kern.geom.debugflags sysctl foot shooting option so that it works. (Not that bsdlabel or fdisk worked around the issue). Otherwise one is left with boot to single user or from alternate media if that doesn't work. I do have a patch that circumvents the problem. I haven't looked it it in years and probably needs some cleanup though. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0