From nobody Fri Jan 05 07:48:04 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T5wYX0DQwz56Qcl; Fri, 5 Jan 2024 07:48:16 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T5wYW4lB6z419Z; Fri, 5 Jan 2024 07:48:15 +0000 (UTC) (envelope-from tuexen@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:b11b:2fe9:ba6c:517c]) (Authenticated sender: micmac) by drew.franken.de (Postfix) with ESMTPSA id 265E4721E2821; Fri, 5 Jan 2024 08:48:05 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: Request for Testing: TCP RACK From: tuexen@freebsd.org In-Reply-To: <87jzoosuie.wl-herbert@gojira.at> Date: Fri, 5 Jan 2024 08:48:04 +0100 Cc: current@freebsd.org, net@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <42C327BD-6CE4-43AA-A1AE-3BEC08D623DB@freebsd.org> <87pm09ykb8.wl-herbert@gojira.at> <87o7ftyhkp.wl-herbert@gojira.at> <87msvdy0v4.wl-herbert@gojira.at> <867DC224-F0B1-4C9C-8EB7-C9F7BE1C029A@freebsd.org> <87edgo33s9.wl-herbert@gojira.at> <87o7e1s7oc.wl-herbert@gojira.at> <87le95rnp8.wl-herbert@gojira.at> <99432C3E-6AD0-4B1B-9E50-C455D397861B@freebsd.org> <87jzoosuie.wl-herbert@gojira.at> To: "Herbert J. Skuhra" X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4T5wYW4lB6z419Z X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:680, ipnet:2001:638::/32, country:DE] > On Jan 4, 2024, at 21:39, Herbert J. Skuhra wrote: >=20 > On Thu, 04 Jan 2024 21:22:22 +0100, tuexen@freebsd.org wrote: >>=20 >>> On Jan 4, 2024, at 18:52, Herbert J. Skuhra = wrote: >>>=20 >>> On Thu, 04 Jan 2024 11:40:35 +0100, "Herbert J. Skuhra" wrote: >>>>=20 >>>> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote: >>>>>=20 >>>>> Hi, >>>>>=20 >>>>> On Fri, 17 Nov 2023 00:15:13 +0100, tuexen@freebsd.org wrote: >>>>>>=20 >>>>>>> On Nov 16, 2023, at 20:06, Herbert J. Skuhra = wrote: >>>>>>>=20 >>>>>>> On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labb=C3=A9 = wrote: >>>>>>>>=20 >>>>>>>> On Thu, Nov 16, 2023 at 5:10=E2=80=AFPM Herbert J. Skuhra = wrote: >>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS". >>>>>>>>>=20 >>>>>>>>> After setting "sysctl net.inet.tcp.functions_default=3Drack" = git no >>>>>>>>> longer works: >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>> Are you using a fresh 15 head or a specific network setup ? >>>>>>>>=20 >>>>>>>> Because I'm not able to reproduce your problem on my system: >>>>>>>>=20 >>>>>>>> $ uname -a >>>>>>>> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0 >>>>>>>> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023 >>>>>>>> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS >>>>>>>> amd64 >>>>>>>> $ cat /usr/src/sys/amd64/conf/TCPHPTS >>>>>>>> include GENERIC-NODEBUG >>>>>>>> ident TCPHPTS >>>>>>>> options TCPHPTS >>>>>>>> $ sysctl net.inet.tcp.functions_default >>>>>>>> net.inet.tcp.functions_default: rack >>>>>>>> $ git clone -q git@github.com:freebsd/freebsd-src.git && echo = working >>>>>>>> working >>>>>>>> $ >>>>>>>=20 >>>>>>> OK, (g)it works if I disable pf. Do you use pf? >>>>>> Can you share your pf config such that I can reproduce the = problem locally? >>>>>=20 >>>>> 1. It even fails with a simple pf.conf: >>>>> pass in all >>>>> pass out all >>>>>=20 >>>>> 2. Fetching port distfiles also failed. >>>>>=20 >>>>> 3. If I disable rxcsum on the ethernet adapter (igb0) it works. >>>>=20 >>>> Disabling lro also resolves the issue. >>>=20 >>> If I run "sysctl net.inet.tcp.rack.features.cmpack=3D0" I don't have = to >>> disable rxcsum/tcxsum or lro on igb0. >> Does the problem also goes away if you disable pf completely, but = keep >> compressed acks enabled? >=20 > Yes, it works with pf disabled and compressed acks enabled. Thanks for the information! Best regards Michael >=20 > -- > Herbert