From nobody Sat Feb 24 19:15:40 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ThxRf1qQfz5BPxf for ; Sat, 24 Feb 2024 19:15:42 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.protected-networks.net (mail.protected-networks.net [IPv6:2001:470:8d59:1::8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits)) (Client CN "mail.protected-networks.net", Issuer "R3" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ThxRd4Rjyz40wT for ; Sat, 24 Feb 2024 19:15:41 +0000 (UTC) (envelope-from imb@protected-networks.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=protected-networks.net header.s=201508 header.b=A6c92lIq; dmarc=pass (policy=reject) header.from=protected-networks.net; spf=pass (mx1.freebsd.org: domain of imb@protected-networks.net designates 2001:470:8d59:1::8 as permitted sender) smtp.mailfrom=imb@protected-networks.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= protected-networks.net; h=content-transfer-encoding:content-type :content-type:in-reply-to:references:content-language:subject :subject:from:from:user-agent:mime-version:date:date:message-id; s=201508; t=1708802141; bh=h72N97d3xcto6HWXpibh0D6kKIO6Dd7BeA+a RmQ2g9g=; b=A6c92lIqc+Z8wd0jcpSomQoa4yYW7G7OgrKTAjUp9YdQZFng48oN SqrSRENw7iSou/Ztzu35qnxgQ84hPBTHBRiLBnoBFHpxnYIk6UcCmTcQxtVRCzmD A+B3kGN2hBCJfeaTzi4ckoDk6F1/9FtLYC2SaNLi8bHKihPepPpS3jo= Received: from [IPV6:2600:4040:53d9:8200:f21f:afff:fe66:957e] (unknown [IPv6:2600:4040:53d9:8200:f21f:afff:fe66:957e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: imb@mail.protected-networks.net) by mail.protected-networks.net (Postfix) with ESMTPSA id 3ECB04B756 for ; Sat, 24 Feb 2024 14:15:41 -0500 (EST) Message-ID: <193cf8bb-0549-43bb-8f30-9e994b7e0d0f@protected-networks.net> Date: Sat, 24 Feb 2024 14:15:40 -0500 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Michael Butler Subject: commit f74352f breaks world Content-Language: en-NZ References: <1ef71804-4227-4e3a-bfb5-b05c9f525181@protected-networks.net> To: freebsd-current Autocrypt: addr=imb@protected-networks.net; keydata= xsDiBETHZAURBACJicNaIbVVVZahtQcdJeogtTLjCYAdj4kFMpy6Y3Ac19UNWDM+TrD4yFPi 5nc/pp9M/5Q4RNBr6a97fTYroTaq+vDwWdklOHwD2ZXs7FqwWOtVSIPT/rev5fUvwEF2VFYE sNDbpE5HHpP/oFUw5scEJZVyOBJSGvYb1IhV55NWswCgzkUGbG8A3s+oZXkHqTCYGW/seukD +wTo/L835xLpbTJxoxEKeGA3aWifSsRvpWWHyXye6sTkSN3SmtE9A8Pqmdb1dBEO0eOms6GD RamvCFgdvg2HesAv9l7L/7Mm9iKJs6uTAa+taIQslpumGh4PRc94IepVFzAa4Ef/FA4mWx9w P/EqNsKUPE2U5HI1decbopkxH/d/A/9Hupc10lPsXVMACd54/YZRsSTTcArheekm8qE/f8Hl 1Q7At+yuFgfMll4QPAhefnrLUanXF1bWtxG5PmaJktDYp3HOmy43giZgacgt+a3TVd6vu8Gs DnI4FOfYllq7mZFezMIulCWUYtnkMEXEeyzp39dygi7blPIjckWlQ2sc380rTWljaGFlbCBC dXRsZXIgPGltYkBwcm90ZWN0ZWQtbmV0d29ya3MubmV0PsJgBBMRAgAgBQJEx2QFAhsDBgsJ CAcDAgQVAggDBBYCAwECHgECF4AACgkQQv9rrgRC1JL7mgCdEnPeo22kqT/bES+D78QSGhNR r8cAn2xOMeu6pBrc2tDY8Ky/70HBctmjzsFNBETHZA4QCACKbm/PMn4QcyDEvIn4MF+t2E1A zgiBAkPCMtWT1CcqeUj13OwNM8qJD/mBWjCZCnr1hKVbvzOmgKaM4uDCWIcSCdoDTJx1DqMx abr+EpHz1fL6aagEOKHz5sCYOkDXt3zzZ/5RBMdkEJwunXYtAbu5e68oty+d0DFzAM3pBp6l GC0TE3VutmFR/KK66rf0KB83YQBf/IAtyqsRIQPP9t0SLfJ+kqKXf73nvAUFEtb21gZSzhTm QP87QKyQvenE8o4PQ2tEslq2jICB7pGcqIrwP4o3Hl4V+HXi3lA26MMJ5rakQB2sKKWroPVQ BiRXO+W8Qf+0oQFq38oMXR5sPOs/AAMFB/sEKcjzvkwviZOsDElthxtgrmqUNKC9G/4Fw0tK k6fMynv+bcKz85k2uWOIfefUKBFoQ0SCphU4jquJENqqy6BPTkXePlIJok2/GkF7xtHm2FPq tTTuYmoBrGsls28Z9dn2LcBwFHz59SSWM9JFPIvFr9HCkKtp6zPUsJd5b02+0wgzDubTMQS9 M2LwGSh9xK6xl4MGgngl22b0TZDh5qHwmsywOX6SbGsQfeNpkptJ4gPjShypusFyF+pevnCM wTfUPCBd/AFbu2fHFQjA8sgkr5IqXuc4PoiIBXc9upoFpDqGkYssAKbzGcRsK94a8hRROJV9 bzPyYempIWaPXr2EwkkEGBECAAkFAkTHZA4CGwwACgkQQv9rrgRC1JKqhwCeOov6gTo8eWte es3gbLr2n2b5AXMAoItSlajet574lkouzY3u3scSRfiE In-Reply-To: <1ef71804-4227-4e3a-bfb5-b05c9f525181@protected-networks.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[protected-networks.net,reject]; R_SPF_ALLOW(-0.20)[+mx:c]; R_DKIM_ALLOW(-0.20)[protected-networks.net:s=201508]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; RCVD_TLS_ALL(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DKIM_TRACE(0.00)[protected-networks.net:+] X-Rspamd-Queue-Id: 4ThxRd4Rjyz40wT Moving these definitions breaks world outside the kernel :-( building shared library libmapper_std.so.5 Building /usr/obj/usr/src/amd64.amd64/lib/libiconv_modules/mapper_zone/libmapper_zone.so.5 building shared library libmapper_zone.so.5 Building /usr/obj/usr/src/amd64.amd64/lib/libstats/tcp_stats.o /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:38: error: use of undeclared identifier 'CC_ECN' 137 | STATS_VSS_DVHIST32_USR(HBKTS(DVBKT(CC_ECN), DVBKT(CC_RTO), | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:38: error: use of undeclared identifier 'CC_ECN' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:53: error: use of undeclared identifier 'CC_RTO' 137 | STATS_VSS_DVHIST32_USR(HBKTS(DVBKT(CC_ECN), DVBKT(CC_RTO), | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:53: error: use of undeclared identifier 'CC_RTO' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:13: error: use of undeclared identifier 'CC_RTO_ERR' 138 | DVBKT(CC_RTO_ERR), DVBKT(CC_NDUPACK)), 0) | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:13: error: use of undeclared identifier 'CC_RTO_ERR' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:32: error: use of undeclared identifier 'CC_NDUPACK' 138 | DVBKT(CC_RTO_ERR), DVBKT(CC_NDUPACK)), 0) | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:32: error: use of undeclared identifier 'CC_NDUPACK' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:38: error: use of undeclared identifier 'CC_ECN' 137 | STATS_VSS_DVHIST32_USR(HBKTS(DVBKT(CC_ECN), DVBKT(CC_RTO), | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:38: error: use of undeclared identifier 'CC_ECN' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:53: error: use of undeclared identifier 'CC_RTO' 137 | STATS_VSS_DVHIST32_USR(HBKTS(DVBKT(CC_ECN), DVBKT(CC_RTO), | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:137:53: error: use of undeclared identifier 'CC_RTO' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:13: error: use of undeclared identifier 'CC_RTO_ERR' 138 | DVBKT(CC_RTO_ERR), DVBKT(CC_NDUPACK)), 0) | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:13: error: use of undeclared identifier 'CC_RTO_ERR' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:32: error: use of undeclared identifier 'CC_NDUPACK' 138 | DVBKT(CC_RTO_ERR), DVBKT(CC_NDUPACK)), 0) | ^ /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:138:32: error: use of undeclared identifier 'CC_NDUPACK' /usr/src/lib/libstats/../../sys/netinet/tcp_stats.c:142:6: error: invalid application of 'sizeof' to an incomplete type 'struct voistatspec[]' 142 | NVSS(vss_congsig), vss_congsig, 0); | ^~~~~~~~~~~~~~~~~ /usr/obj/usr/src/amd64.amd64/tmp/usr/include/sys/stats.h:440:32: note: expanded from macro 'NVSS' 440 | #define NVSS(vss_slots) (sizeof((vss_slots)) / sizeof(struct voistatspec)) | ^~~~~~~~~~~~~ 17 errors generated. *** [tcp_stats.o] Error code 1 make[5]: stopped in /usr/src/lib/libstats .ERROR_TARGET='tcp_stats.o'