Re: Request for Testing: TCP RACK

From: <tuexen_at_freebsd.org>
Date: Tue, 06 Feb 2024 22:05:27 UTC 
> On Jan 5, 2024, at 08:48, tuexen@freebsd.org wrote:
> 
>> On Jan 4, 2024, at 21:39, Herbert J. Skuhra <herbert@gojira.at> wrote:
>> 
>> On Thu, 04 Jan 2024 21:22:22 +0100, tuexen@freebsd.org wrote:
>>> 
>>>> On Jan 4, 2024, at 18:52, Herbert J. Skuhra <herbert@gojira.at> wrote:
>>>> 
>>>> On Thu, 04 Jan 2024 11:40:35 +0100, "Herbert J. Skuhra" wrote:
>>>>> 
>>>>> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> On Fri, 17 Nov 2023 00:15:13 +0100, tuexen@freebsd.org wrote:
>>>>>>> 
>>>>>>>> On Nov 16, 2023, at 20:06, Herbert J. Skuhra <herbert@gojira.at> wrote:
>>>>>>>> 
>>>>>>>> On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
>>>>>>>>> 
>>>>>>>>> On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra <herbert@gojira.at> wrote:
>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
>>>>>>>>>> 
>>>>>>>>>> After setting "sysctl net.inet.tcp.functions_default=rack" git no
>>>>>>>>>> longer works:
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>> Are you using a fresh 15 head or a specific network setup ?
>>>>>>>>> 
>>>>>>>>> Because I'm not able to reproduce your problem on my system:
>>>>>>>>> 
>>>>>>>>> $ uname -a
>>>>>>>>> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
>>>>>>>>> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
>>>>>>>>> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
>>>>>>>>> amd64
>>>>>>>>> $ cat /usr/src/sys/amd64/conf/TCPHPTS
>>>>>>>>> include GENERIC-NODEBUG
>>>>>>>>> ident                   TCPHPTS
>>>>>>>>> options                 TCPHPTS
>>>>>>>>> $ sysctl net.inet.tcp.functions_default
>>>>>>>>> net.inet.tcp.functions_default: rack
>>>>>>>>> $ git clone -q git@github.com:freebsd/freebsd-src.git && echo working
>>>>>>>>> working
>>>>>>>>> $
>>>>>>>> 
>>>>>>>> OK, (g)it works if I disable pf. Do you use pf?
>>>>>>> Can you share your pf config such that I can reproduce the problem locally?
>>>>>> 
>>>>>> 1. It even fails with a simple pf.conf:
>>>>>> pass in all
>>>>>> pass out all
>>>>>> 
>>>>>> 2. Fetching port distfiles also failed.
>>>>>> 
>>>>>> 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
>>>>> 
>>>>> Disabling lro also resolves the issue.
>>>> 
>>>> If I run "sysctl net.inet.tcp.rack.features.cmpack=0" I don't have to
>>>> disable rxcsum/tcxsum or lro on igb0.
>>> Does the problem also goes away if you disable pf completely, but keep
>>> compressed acks enabled?
>> 
>> Yes, it works with pf disabled and compressed acks enabled.
> Thanks for the information!
A patch is available at:
https://reviews.freebsd.org/D43769

Best regards
Michael
> 
> Best regards
> Michael
>> 
>> --
>> Herbert
> 
>