From nobody Thu Dec 12 02:44:53 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y7xdw1KWnz5gsPZ for ; Thu, 12 Dec 2024 02:45:08 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y7xdt4ZvYz4X9n for ; Thu, 12 Dec 2024 02:45:06 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=XHoxvgzn; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2a00:1450:4864:20::531 as permitted sender) smtp.mailfrom=rick.macklem@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5cedf5fe237so150170a12.3 for ; Wed, 11 Dec 2024 18:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733971503; x=1734576303; darn=freebsd.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=xqJcu51mEoGOtCOx3ztiY/clkdaQe7AJVi7MCq9a90M=; b=XHoxvgznJeKlKta84JjVP/wypNqgQ2R5Vhy437IC8rSh1gECyuum1fG5sidfsZ3wRu Da2MBNxpHY/UKRbQzgI6Sy3453KsIQcXxy3n5JonrddtFwxAKQ2fDXstQwEDC+WWesZq /p8W9hj2dNkLDvLmn2Qtu2PQJk/NcX9kxISC/uFG2cpGZB+cxW/iOz75kLKi9WbAQ52t qVTIyFiPVvCeiJ8lISnEjkZcOyaSR4McTREDkA5detkB38hUgd/l3DGhN05vDOGP6USQ nX4SNTvyKjazR2O/LEiN4Z9ZBmtj6ftwJenqbdx+ji7YqKUCmGIkUovwde19t1pwXS70 dRJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733971503; x=1734576303; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xqJcu51mEoGOtCOx3ztiY/clkdaQe7AJVi7MCq9a90M=; b=aQV33O4C13Oia/JL8iGi9tBKVLX1SynQi+APc5N6khz/RRElLlamweWLV9Z6tRty++ 5mW9oYdWubanRbrz9pw6RGh3PhRT1T5LUO9qFaO3BiCcBq0VtVBfIPAYthoCu0mnwFcs OvS7wlKMyfRPg15B602huK0p1SsM6I/6HhbFK80XEnadHV7FB1guFkKTy6eiKVEIWoFv hBQ/Wy440qY1rZCZWAmWSDtUefrJXyTznRJLiedwTvbMB1O+c72T8q3HkawpoCW2J1zt sbvVTwPHnEKMdOxRfpa6qMQCO7vstM9ualUsdor8hkeWYIVDgRWhS2DCL46y5sITwAwp CTNw== X-Gm-Message-State: AOJu0Ywx+XP+qjibMwJv6c/SETn/FLMJ/U988n+LnQIBSms2UmguZyRz Z60f+r3Gm9k3rubcWmg2RJfZEWbH90tJOkB/U110b0OduFoKS82pZVFb9rpFEIqpTI+0oh1QPex F8cAFBhMUGnOdX9hZw3zG7cwQriGb X-Gm-Gg: ASbGncsxMyd8slwELvWhC2XHXHYNVSFVnbwhg1Pirj0Y1cRWbG6sU/pwst6BUZ0ODvE FDUlnsOfSsFoYsJo1ZxzWXWQtED4dzb5Yna1hShKAusiRfIdHJOD78uVNIk8fdALvEIhiUA== X-Google-Smtp-Source: AGHT+IEzZMcCO2uOjO2PrMBdx6vwFwVSvnna7Ua9I86ut03Wua25ioN7bv9IkQKJJHAZ1qmRsKcflox9QDAihcS0PsY= X-Received: by 2002:a05:6402:540e:b0:5d0:d5af:d417 with SMTP id 4fb4d7f45d1cf-5d433048d7dmr4671410a12.1.1733971503171; Wed, 11 Dec 2024 18:45:03 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 From: Rick Macklem Date: Wed, 11 Dec 2024 18:44:53 -0800 Message-ID: Subject: Module variable initialization To: FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-3.91 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.91)[-0.909]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; MID_RHS_MATCH_FROMTLD(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; TAGGED_FROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::531:from] X-Rspamd-Queue-Id: 4Y7xdt4ZvYz4X9n X-Spamd-Bar: --- Hi, Bugzilla pr#282156 reports a crash that appears to be caused by a NFS client variable (nfscbd_pool) not being initialized when a NFS mount is done. Now, the NFS client module (nfscl.ko) is weird in that it has two definitions for the module. There is a VFS_SET() one for the file system and a separate DECLARE_MODULE() for nfscl. (The latter exists so that the module can refuse to unload and define dependencies on other modules.) The variable (nfscbd_pool) is initialized in the modevent() function for nfscl in the MOD_LOAD section. Does anyone know if this can somehow result in the variable not being initialized when an NFS mount occurs? And, if the above is possible, would doing the initialization in the vfs_init function for VFS_SET() be guaranteed to happen before a mount is done? Thanks for any help with this, rick