From nobody Mon Aug 12 04:51:01 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wj2CZ0YlYz5T5SM for ; Mon, 12 Aug 2024 04:51:06 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wj2CY3h0vz4f2L for ; Mon, 12 Aug 2024 04:51:05 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id dBjCsEpEAMArNdN1MsEKxx; Mon, 12 Aug 2024 04:51:04 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id dN1Ks1NaAE0IVdN1Ls8ygi; Mon, 12 Aug 2024 04:51:04 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=cI9DsUeN c=1 sm=1 tr=0 ts=66b994b8 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=yoJbH4e0A30A:10 a=0depPUPBAAAA:8 a=CjxXgO3LAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=zJxzwE_Q5SxP4xXyorQA:9 a=CjuIK1q_8ugA:10 a=uu40koo1Yu1oziLcvR5q:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id E919CAD2; Sun, 11 Aug 2024 21:51:01 -0700 (PDT) Received: from slippy (localhost [IPv6:::1]) by slippy.cwsent.com (Postfix) with ESMTP id D61141B9; Sun, 11 Aug 2024 21:51:01 -0700 (PDT) Date: Sun, 11 Aug 2024 21:51:01 -0700 From: Cy Schubert To: Dennis Clarke Cc: freebsd-current@freebsd.org Subject: Re: git: ce4dcb97ca43 - main - zfs: merge openzfs/zfs@9c56b8ec7 Message-ID: <20240811215101.7e7b5bd5@slippy> In-Reply-To: <47f96d89-e1d1-43a8-b456-7b30240d1fad@blastwave.org> References: <20240811021506.04996DB@slippy.cwsent.com> <54076f5e-cd6d-40d6-b4b7-495cf8e67572@blastwave.org> <20240811134119.91DD57F@slippy.cwsent.com> <47f96d89-e1d1-43a8-b456-7b30240d1fad@blastwave.org> Organization: KOMQUATS X-Mailer: Claws Mail 3.20.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfJcJAZ2StwoTtL1brYGV++tSTeAADW1giDpowQiXmqIdkqoG1cY9estuzMdLkcR9GqJs/DBuJwTDaFdzkcH/kSHS3D0EG/EPaEbdUpF9aTdocbZgkLpV vzL5vCmJ4C8nlrVCTJ32mbteDlBsosZRg2tgznB6CJzLzb1wSLeZwkz9+J2syzx22bG2UDpjEZvC2/K4o11reW7Z/Y7VDNxhvhLEyttCLFA/ysNhCSly4dkp Av1CD4z596uy6nMlmR22QA== X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4Wj2CY3h0vz4f2L On Sun, 11 Aug 2024 12:29:18 -0400 Dennis Clarke wrote: > On 8/11/24 09:41, Cy Schubert wrote: > > In message <54076f5e-cd6d-40d6-b4b7-495cf8e67572@blastwave.org>, Dennis > > Clarke > > writes: > >> On 8/10/24 22:15, Cy Schubert wrote: > >>> In message , Mark Millard > >>> write > >>> s: > >> > >>>> =E2=80=A2 [2:12 PM]Flox: getting this error in ZFS since recent = > >>>> update in HEAD > >>>> =E2=80=A2 [2:12 PM]Flox: > >>>> sysctl_warn_reuse: can't re-use a leaf = > >>>> (kstat.zfs.zroot.dataset.objset-0x204.zil_itx_metaslab_slog_alloc)! > >>>> pid 58 (zpool) is attempting to use unsafe AIO requests - not logging = > >>>> anymore > >>>> > >>>> =E2=80=A2 [2:13 PM]Flox: > >>>> FreeBSD fbsd15.localdomain 15.0-CURRENT FreeBSD 15.0-CURRENT #0 = > >>>> main-aea9dba46b: Sat Aug 10 16:48:02 EDT 2024 = > >>>> mike@fbsd15.localdomain:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG = > >>>> amd64 > >>> > >>> Yeah. I'm getting tons of these on all my machines as well. > >>> > >>> sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.cwsys.dataset.objset-0x2c > >> c > >>> d.zil_itx_metaslab_slog_alloc)! > >>> > >>> > >> > >> > >> Yep. Seems to be a real thing just pouring out all over the console here > >> too : > >> > >> > >> sysctl_warn_reuse: can't re-use a leaf > >> (kstat.zfs.t1.dataset.objset-0x4b0.zil_itx_metaslab_slog_alloc)! > > > > This only happens on import: when the system boots and when any pools are > > imported later on. > > > > Sadly .. nope ... that is not the case : Given what I have reported to be true and you having reported a different condition that produces the error we likely have two different code paths that result in the same error. Having just rebooted my laptop produces the error for the main zpool on nvme and zpools on USB (conditionally) imported later producing the same error during each import. > > triton# uptime > 4:27PM up 11:33, 2 users, load averages: 2.76, 0.93, 0.37 > triton# > triton# sysctl_warn_reuse: can't re-use a leaf > (kstat.zfs.t1.dataset.objset-0x639a.zil_itx_metaslab_slog_alloc)! [...] > > So seems to be a thing when the machine is running and doing things like > a poudriere bulk build etc etc .. This could be due to mounts of zfs datasets, occurring during boot and multiple times by poudriere as it recreates each environment for the next build. It's zfs mount then. slippy# zfs umount t/wrkdir/amd64 slippy# zfs mount t/wrkdir/amd64 slippy# The above resulted in the following errors logged: sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.t.dataset.objset-0x851.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.t.dataset.objset-0x851.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.t.dataset.objset-0x851.zil_itx_metaslab_slog_alloc)! > > I have not seen it when the machine is just twiddling its thumbs > pondering an existential crisis. Yet. Correct. And a machine doing nothing won't produce the error until it performs a zfs mount -- in which case it's doing something. ;) > > >> > >> > >> Just a tad uncomfortable to see. > > > > Uncomfortable but harmless. > > > > In that case let's make it go away .. mmmkay ? > > -- > Dennis Clarke > RISC-V/SPARC/PPC/ARM/CISC > UNIX and Linux spoken > > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0