From nobody Sun Aug 11 14:14:34 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WhfmS378Xz5SvGV for ; Sun, 11 Aug 2024 14:14:48 +0000 (UTC) (envelope-from zarychtam@plan-b.pwste.edu.pl) Received: from plan-b.pwste.edu.pl (plan-b.pwste.edu.pl [IPv6:2001:678:618::40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "plan-b.pwste.edu.pl", Issuer "GEANT OV RSA CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WhfmQ5W0Mz59Fp for ; Sun, 11 Aug 2024 14:14:46 +0000 (UTC) (envelope-from zarychtam@plan-b.pwste.edu.pl) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=plan-b.pwste.edu.pl header.s=plan-b-mailer header.b=fklGAEAa; dmarc=pass (policy=quarantine) header.from=plan-b.pwste.edu.pl; spf=pass (mx1.freebsd.org: domain of zarychtam@plan-b.pwste.edu.pl designates 2001:678:618::40 as permitted sender) smtp.mailfrom=zarychtam@plan-b.pwste.edu.pl Received: from [192.168.7.70] (dom.potoki.eu [62.133.140.50]) (authenticated bits=0) by plan-b.pwste.edu.pl (8.18.1/8.17.2) with ESMTPSA id 47BEEYC3052037 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO) for ; Sun, 11 Aug 2024 16:14:35 +0200 (CEST) (envelope-from zarychtam@plan-b.pwste.edu.pl) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plan-b.pwste.edu.pl; s=plan-b-mailer; t=1723385675; bh=6Pf5zMUThTPZQ9KwAQDoWLjsSuWD++6niHMix/h3rL4=; h=Date:Subject:To:References:From:In-Reply-To; b=fklGAEAaIwxpwKb9wWLzQYX5ZiPx+08CimdWTZI9OVfSs42cr7JCwIgVreoSf/aJh M//ckuL28MFTAr1btN9CLrGdYPLcx0PTRsSVpDnvz08cose/NjNt7NQreYdiVJUqhH c+p32Jij/yawdHZSj/N2PqzGLxg+I/nhFKu7VD+ATijZbnigxZ5c5e5J6pCAJinV3u VOFb6/QEkCjeDH5BKC2yzGzw6FTpzrsAfBi3afU5faQhsjvPZGtC6cxZO7/tUA/BHt OOQymLP6pUWqRGj1XiQP57fzWtBAIyja+DN9spLavPthCN9r28Hgu1XLPtjuEmUCXQ CdG2lOnbp18Ag== X-Authentication-Warning: plan-b.pwste.edu.pl: Host dom.potoki.eu [62.133.140.50] claimed to be [192.168.7.70] Message-ID: Date: Sun, 11 Aug 2024 16:14:34 +0200 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: ce4dcb97ca43 - main - zfs: merge openzfs/zfs@9c56b8ec7 To: freebsd-current@freebsd.org References: <20240811021506.04996DB@slippy.cwsent.com> <54076f5e-cd6d-40d6-b4b7-495cf8e67572@blastwave.org> <20240811134119.91DD57F@slippy.cwsent.com> Content-Language: en-US From: Marek Zarychta Autocrypt: addr=zarychtam@plan-b.pwste.edu.pl; keydata= xsBNBFfi3cMBCADLecMTFXad4uDXqv3eRuB4qJJ8G9tzzFezeRnnwxOsPdytW5ES2z1ibSrR IsiImx6+PTqrAmXpTInxAi7yiZGdSiONRI4CCxKY9d1YFiNYT/2WyNXCekm9x29YeIU7x0JB Llbz0f/9HC+styBIu2H+PY/X98Clzm110CS+n/b9l1AtiGxTiVFj7/uavYAKxH6LNWnbkuc5 v8EVNc7NkEcl5h7Z9X5NEtzDxTOiBIFQ/kOT7LAtkYUPo1lqLeOM2DtWSXTXQgXl0zJI4iP1 OAu4qQYm2nXwq4b2AH9peknelvnt1mpfgDCGSKnhc26q6ibTfMwydp+tvUtQIQYpA6b9ABEB AAHNN01hcmVrIFphcnljaHRhIChQbGFuLWIpIDx6YXJ5Y2h0YW1AcGxhbi1iLnB3c3RlLmVk dS5wbD7CwHcEEwEIACEFAlfi4LkCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQHZW8 vIFppoJXdgf8D9X3VRFSNaR9lthSx/+uqas17J3FJKBo1xMQsC2a+44vzNvYJSuPGLLJ+LW2 HPVazjP/BWZJbxOYpliY4zxNRU0YCp0BLIVLibc//yax+mE42FND/+NiIZhqJscl6MLPrSwo sIwXec4XYkldkyqW/xBbBYXoIkBqdKB9j5j42Npy1IV/RizOSdmvTWY27ir8e/yGMR1RLr4F 8P5K3OWTdlGy2H2F/3J8bIPBLG6FpaIyLQw4dHSx8V02PYqDxK1cNo2kAOnU8PnZL/AGuMOH iv3MN1VYL8ehcmpBBsrZGebQJxrjY2/5IaTSgp9xHYT70kshuU6Qb97vk1mOjNZxgc7ATQRX 4t3DAQgA10h6RCXuBLMHxq5B8X/ZIlj9sgLoeyfRdDZEc9rT2KUeUJVHDsbvOFf4/7F1ovWY hJbA6GK/LUZeHHTjnbZcH1uDYQeHly4UOLxeEvhGoz4JhS2C7JzN/uRnwbdOAUbJr8rUj/IY a7gk906rktsc/Ldrxrxh7O6WO0JCh2XO/p4pDfEwwB37g4xHprSab28ECYJ9JMbtA8Sy4M55 g3+GQ28FvSlGnx48OoGXU2BZdc1vZKSQmNOlikB+9/hDX8zdYWVfDaX1TLQ8Ib4+xTUmapza mV/bxIsaZRBw+jFjLQHhTbIMfPEU+4mxFDvTdbKPruKPqVf1ydgMnPZWngowdwARAQABwsBf BBgBCAAJBQJX4t3DAhsMAAoJEB2VvLyBaaaC6qkIAJs9sDPqrqW0bYoRfzY6XjDWQ59p9tJi v8aogxacQNCfAu+WkJ8PNVUtC1dlVcG5NnZ80gXzd1rc8ueIvXlvdanUt/jZd8jbb3gaDbK3 wh1yMCGBl/1fOJTyEGYv1CRojv97KK89KP5+r8x1P1iHcSrunlDNqGxTMydNCwBH23QcOM+m u4spKnJ/s0VRBkw3xoKBZfZza6fTQ4gTpAipjyk7ldOGBV+PvkKATdhK2yLwuWXhKbg/GRlD 1r5P0gxzSqfV4My+KJuc2EDcrqp1y0wOpE1m9iZqCcd0fup5f7HDsYlLWshr7NQl28f6+fQb sylq/j672BHXsdeqf/Ip9V4= In-Reply-To: <20240811134119.91DD57F@slippy.cwsent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.89 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[plan-b.pwste.edu.pl,quarantine]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[plan-b.pwste.edu.pl:s=plan-b-mailer]; MIME_GOOD(-0.10)[text/plain]; ONCE_RECEIVED(0.10)[]; XM_UA_NO_VERSION(0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:206006, ipnet:2001:678:618::/48, country:PL]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FROM_HAS_DN(0.00)[]; HAS_XAW(0.00)[]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DKIM_TRACE(0.00)[plan-b.pwste.edu.pl:+] X-Rspamd-Queue-Id: 4WhfmQ5W0Mz59Fp W dniu 11.08.2024 o 15:41, Cy Schubert pisze: > In message <54076f5e-cd6d-40d6-b4b7-495cf8e67572@blastwave.org>, Dennis > Clarke > writes: >> On 8/10/24 22:15, Cy Schubert wrote: >>> In message , Mark Millard >>> write >>> s: >>>> =E2=80=A2 [2:12 PM]Flox: getting this error in ZFS since recent = >>>> update in HEAD >>>> =E2=80=A2 [2:12 PM]Flox: >>>> sysctl_warn_reuse: can't re-use a leaf = >>>> (kstat.zfs.zroot.dataset.objset-0x204.zil_itx_metaslab_slog_alloc)! >>>> pid 58 (zpool) is attempting to use unsafe AIO requests - not logging = >>>> anymore >>>> >>>> =E2=80=A2 [2:13 PM]Flox: >>>> FreeBSD fbsd15.localdomain 15.0-CURRENT FreeBSD 15.0-CURRENT #0 = >>>> main-aea9dba46b: Sat Aug 10 16:48:02 EDT 2024 = >>>> mike@fbsd15.localdomain:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG = >>>> amd64 >>> Yeah. I'm getting tons of these on all my machines as well. >>> >>> sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.cwsys.dataset.objset-0x2c >> c >>> d.zil_itx_metaslab_slog_alloc)! >>> >>> >> >> Yep. Seems to be a real thing just pouring out all over the console here >> too : >> >> >> sysctl_warn_reuse: can't re-use a leaf >> (kstat.zfs.t1.dataset.objset-0x4b0.zil_itx_metaslab_slog_alloc)! > This only happens on import: when the system boots and when any pools are > imported later on. > >> >> Just a tad uncomfortable to see. > Uncomfortable but harmless. So tons of the messages like below could be ignored? sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zhgst.dataset.objset-0x5f6.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zhgst.dataset.objset-0x5f6.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zhgst.dataset.objset-0x5f6.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zvol.dataset.objset-0x66b.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zvol.dataset.objset-0x66b.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zvol.dataset.objset-0x66b.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zvol.dataset.objset-0x54.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zvol.dataset.objset-0x54.zil_itx_metaslab_slog_alloc)! sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.zvol.dataset.objset-0x54.zil_itx_metaslab_slog_alloc)! BTW, thank you for bringing this up. > I haven't looked at this too closely but could dataset_kstats_create() be > called more than once for each dataset? > > We should probably also check to verify the leaf nodes are removed when a > pool is exported as well. I don't have any time to test this hypothesis > today but maybe tomorrow sometime. > > -- Marek Zarychta