From nobody Sun Aug 11 13:41:19 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Whf1t5xDSz5SqMv for ; Sun, 11 Aug 2024 13:41:22 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Whf1t5Bylz54PR for ; Sun, 11 Aug 2024 13:41:22 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id d4nVstrCOkYKFd8ozsagUP; Sun, 11 Aug 2024 13:41:21 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id d8oyspY6oKHV8d8ozs8EvB; Sun, 11 Aug 2024 13:41:21 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=XeEqz555 c=1 sm=1 tr=0 ts=66b8bf81 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=yoJbH4e0A30A:10 a=0depPUPBAAAA:8 a=CjxXgO3LAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=TNIv5-NpN9UG_CwSjcsA:9 a=CjuIK1q_8ugA:10 a=uu40koo1Yu1oziLcvR5q:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id CA04B5A5; Sun, 11 Aug 2024 06:41:19 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 91DD57F; Sun, 11 Aug 2024 06:41:19 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Dennis Clarke cc: freebsd-current@freebsd.org Subject: Re: git: ce4dcb97ca43 - main - zfs: merge openzfs/zfs@9c56b8ec7 In-reply-to: <54076f5e-cd6d-40d6-b4b7-495cf8e67572@blastwave.org> References: <20240811021506.04996DB@slippy.cwsent.com> <54076f5e-cd6d-40d6-b4b7-495cf8e67572@blastwave.org> Comments: In-reply-to Dennis Clarke message dated "Sun, 11 Aug 2024 01:52:45 -0400." List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 11 Aug 2024 06:41:19 -0700 Message-Id: <20240811134119.91DD57F@slippy.cwsent.com> X-CMAE-Envelope: MS4xfA0AKFS0y4HQhvQcZh1NUcfprfmZpyzf9KaM39x8B2MMrny9+gQU/7tzVbr0VDS15mWPjSq7LcnGb3UUm+anh64F++XR4jDEdKUdXtmyrss2pYevJo1l dgR+WTTNcU1wK8GEBUWy5CjLk5hQubWrPSMicKKujo7OfeBhOZTmuxEbKzedxHkVGPnAtjI0oxLLJDpfAfNuuyCoNzCuLuwp2LlZbcQVu/zifcYArZbIIJY/ SOKZU86Ymzj3jv3ozBCa9w== X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4Whf1t5Bylz54PR In message <54076f5e-cd6d-40d6-b4b7-495cf8e67572@blastwave.org>, Dennis Clarke writes: > On 8/10/24 22:15, Cy Schubert wrote: > > In message , Mark Millard > > write > > s: > > >> =E2=80=A2 [2:12 PM]Flox: getting this error in ZFS since recent = > >> update in HEAD > >> =E2=80=A2 [2:12 PM]Flox: > >> sysctl_warn_reuse: can't re-use a leaf = > >> (kstat.zfs.zroot.dataset.objset-0x204.zil_itx_metaslab_slog_alloc)! > >> pid 58 (zpool) is attempting to use unsafe AIO requests - not logging = > >> anymore > >> > >> =E2=80=A2 [2:13 PM]Flox: > >> FreeBSD fbsd15.localdomain 15.0-CURRENT FreeBSD 15.0-CURRENT #0 = > >> main-aea9dba46b: Sat Aug 10 16:48:02 EDT 2024 = > >> mike@fbsd15.localdomain:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG = > >> amd64 > > > > Yeah. I'm getting tons of these on all my machines as well. > > > > sysctl_warn_reuse: can't re-use a leaf (kstat.zfs.cwsys.dataset.objset-0x2c > c > > d.zil_itx_metaslab_slog_alloc)! > > > > > > > Yep. Seems to be a real thing just pouring out all over the console here > too : > > > sysctl_warn_reuse: can't re-use a leaf > (kstat.zfs.t1.dataset.objset-0x4b0.zil_itx_metaslab_slog_alloc)! This only happens on import: when the system boots and when any pools are imported later on. > > > Just a tad uncomfortable to see. Uncomfortable but harmless. > > > > > -- > -- > Dennis Clarke > RISC-V/SPARC/PPC/ARM/CISC > UNIX and Linux spoken > > I haven't looked at this too closely but could dataset_kstats_create() be called more than once for each dataset? We should probably also check to verify the leaf nodes are removed when a pool is exported as well. I don't have any time to test this hypothesis today but maybe tomorrow sometime. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0