From nobody Thu Aug 08 17:56:50 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wfvr96LHNz5TL9s for ; Thu, 08 Aug 2024 17:56:57 +0000 (UTC) (envelope-from tamelingdaniel@gmail.com) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wfvr86hrnz4WWF for ; Thu, 8 Aug 2024 17:56:56 +0000 (UTC) (envelope-from tamelingdaniel@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=HZP+Yg5i; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of tamelingdaniel@gmail.com designates 2a00:1450:4864:20::42b as permitted sender) smtp.mailfrom=tamelingdaniel@gmail.com Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3687ea0521cso890949f8f.1 for ; Thu, 08 Aug 2024 10:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723139813; x=1723744613; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E487wUlo5EWlT+In7z96VdXs+9+wqyCPUUsAcl+DhiY=; b=HZP+Yg5iG6b0P9GNNvjzWHzo47bcwLhPNi3G7GJqX9y0KZ28+Pk90AI0kcqnz/u4Ey UsmtTIY3l6etpxOcsa1pdbdKD+YWPNcWNB/rzpyhj3QzuDz/THrITvWcfnUaKoDkRgxV 9KxfX6p3XSPeFyHDlBHykX6QqXKQHcBREDLk80aZps8fQGw6hKbI5buxS/ZxKNWsCrPH rHiTZNHewUs6brixphatRQm+WoOxZZjx2HG6HB2PTnWWwr2p3Eufz9RultIkYnWKyM+E JdHEm1ZJJXihdJp7quyCtf8hXM7LuufaHPn8r+teWXmrDo6BH8zXlHM2ln9ZcRMfXYnZ EKIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723139813; x=1723744613; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E487wUlo5EWlT+In7z96VdXs+9+wqyCPUUsAcl+DhiY=; b=hZx6p0R9p9OF3npO/7zRjldx5hiCP4IAZyp8d9UeeIGjQ1AVzDufag8cQxuKl+Q1Sx du5DNSC8gPVwvPvPSyAACos4HQ2K5pQmXz5bYFysulJot/CB9txqTtojy31gN5W18+dw pU7Cn4Dl89ti/1qH2lvU27y6r0Qt4h6pkeAcf35SW1CbAr0B3i4w/7jXpK5oFVVgJfpF eXA0ZlOkoTB6LMEUnd9vRZIPp9ActB9EXNa66zNzMriaJuGvScLGrxoRLbupY67M5QoL ZmR6aHhvFcj2Ti7KpMztZVDp9DWLaF353PJsuB9VZYZMwrPN42nb1fSBwKiX3dMSEa7n 51SA== X-Gm-Message-State: AOJu0YyU7Wcg3oJppggMHfb7pKnezBOg+pMMT6fetlOct5BEWKjMYVrz 8tGeTu38WhnE5bwet+doZOER3mXliYLlXUEaKPKvMV0OdzevRrS4/5GjTAHi X-Google-Smtp-Source: AGHT+IFsZli+Bh+aNbV+SFD+9+evePN+26HdQGM+3imvrDRJTV9l9x6iF3k+3E68doV3sxVEhWGmWw== X-Received: by 2002:a05:6000:1ace:b0:368:4489:8efb with SMTP id ffacd0b85a97d-36d27580d86mr2992658f8f.40.1723139812727; Thu, 08 Aug 2024 10:56:52 -0700 (PDT) Received: from localhost ([2001:9e8:c428:5600:5fb:243b:36a4:d2c7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27156c8asm2648132f8f.24.2024.08.08.10.56.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 10:56:52 -0700 (PDT) Date: Thu, 8 Aug 2024 19:56:50 +0200 From: Daniel Tameling To: freebsd-current@freebsd.org Subject: Re: Fall back to fast_float when C++ stdlib doesn't provide from_chars for floats Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spamd-Bar: --- X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.997]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::42b:from] X-Rspamd-Queue-Id: 4Wfvr86hrnz4WWF On Tue, Aug 06, 2024 at 11:26:26AM +0100, Nuno Teixeira wrote: > > As I don't have skills to understand why this fix works, I'd like to have > some expert opinion on this fix since I don't know if this will be > supported in the future. Not an expert, but here is my opinion: the workaround uses the strtod function instead of the from_chars function. The latter got added in c++17 and the former is still in the latest standard, and I don't think it will be removed any time soon. So as long as it is supported by upstream, it should be save to use the workaround. You might want to raise the issue with toolchain@FreeBSD.org to get a reaction from the real experts. Maybe there is a better solution to your problem. -- Best regards, Daniel