From nobody Fri Apr 26 02:49:23 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VQcdC67V3z5HNYb for ; Fri, 26 Apr 2024 02:49:35 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VQcdB5llJz4TWy for ; Fri, 26 Apr 2024 02:49:34 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=VCFc6ecd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2607:f8b0:4864:20::52d as permitted sender) smtp.mailfrom=rick.macklem@gmail.com Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5bdbe2de25fso1256655a12.3 for ; Thu, 25 Apr 2024 19:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714099773; x=1714704573; darn=freebsd.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=YKvYoW1nBY1SWrg8dQT23zzYW1+uO3OJ2Zvwa0bobfA=; b=VCFc6ecd/0YYZd37Mz03uZPdleDiFzVK6brO6g5Bw2pL3bwyteRrwebNkzv1R0BwH7 TWOwHvISMfPCya+I8QgI225ipMxgqjhElIYjBCGS3CuUt5scqgdIKN0cDqKQEDlk6aSz A07TWpswrR/LgU79IyYIWNSWjvhCfDC6noLMZElS0EGxKD06pcNcjyr53PyNUtyLPQZw y79fyyTJ/JhN3/H9JJC674pmveI2+jV9f7ByjUj8linKwmoQ5bsXDQgp9XGYkpkk6GOT /eolMMiFC2rZyB8P2SO9Oi/10Sq3+6SBd7VnB9i+/ikY6CTUwBUvaf8Rlfaoag8v31nb A5XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714099773; x=1714704573; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YKvYoW1nBY1SWrg8dQT23zzYW1+uO3OJ2Zvwa0bobfA=; b=ieI9Syl/mqtdtWuTHwUYyAU+7INyzGC7znOtrgXGNQunKcvS7wEYxlgxcd9AwkNXF6 /FYuu0PNdAzJWjbhhE43/UUUH1y9eFMnhvmkOVXgcLlh543P9XA0kZjhUr33Tw0Zj1zE s7FHLv6bRcca2R7p96fKkyJCwuCpwD39IterydKprJCaMAdLnUH0u5e67DKiRqkFpeDe daUJTFXBUZiJrUNwm7wCKQQ3jMwfr9heSKWPqMwVenjcBZLyzmP2NPCIcGCLI8bEJrte uQTNCRJSEWP60U4p2JDqBYQJKlMjLB4Fn9ips8GYnRlIG+ny+qOgk+Z8rdDgIP3VbGil Itkg== X-Gm-Message-State: AOJu0Ywnab5uRt1arRoTICpNX06pkKSxAt3A2DMPkop9zFNjGVAIaBmO znnoxpn6V/YcnopjyX4HxZZpHnTTZDF31yt5NUm8Y8NOcZc3a0WUf5S1bIlEyYagjKEsudGTzgb E6yS/aA5YopnXIFj+fp806ihZaJtG X-Google-Smtp-Source: AGHT+IFcac8hcN5I/X2eAzIDb4eWylahfLDpC7RM5gyfGetBkyx8q6GT3xzy5KX2t6Yzk/sA9xuFzanaV2wgyFKqmjI= X-Received: by 2002:a05:6a21:3a43:b0:1a9:3e7a:b0fc with SMTP id zu3-20020a056a213a4300b001a93e7ab0fcmr1953972pzb.51.1714099772734; Thu, 25 Apr 2024 19:49:32 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 From: Rick Macklem Date: Thu, 25 Apr 2024 19:49:23 -0700 Message-ID: Subject: mysterious setting of B_DIRECT? To: FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.99 / 15.00]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.993]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; TAGGED_FROM(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::52d:from] X-Rspamd-Queue-Id: 4VQcdB5llJz4TWy Hi, This week I have been doing active testing as a part of an IETF bakeathon for NFSv4. During the week I had a NFSv4 client crash. On the surface, it is straightforward, in that it called ncl_doio_directwrite() and the field called b_caller1 was NULL. Now, here's the weird part... ncl_doio_directwrite() should never be called because B_DIRECT should never be set. (The only place B_DIRECT gets set in the code is never currently executed.) I have a patch that clears out the "never to be executed" code and this seems to avoid the patch, since with the patch, ncl_doio_directwrite() no longer exists. What I cannot figure out is how B_DIRECT got set? I can note that UFS was under heavy load when the client crashed, but I cannot see how a UFS "struct buf" would become a NFS "struct buf" without b_flags being set to 0. Anyone have any ideas? rick