From nobody Thu Sep 14 09:02:38 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RmWYY2vV4z4t1pF for ; Thu, 14 Sep 2023 09:02:41 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RmWYY2LgKz4X6s; Thu, 14 Sep 2023 09:02:41 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694682161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4alNtE8l0nJ8kBjJFa/HCbnTyuxi63eaxp5aefSAOqs=; b=K6m+PyzYlz/UUEdY9hPjbknWO9ZReJnvQkas4P0rudU9cs/rc26kS2C+5PwcwfZR0IZTpU bQqNww4vWnaKS9WoSwnhfCHXUEk/9zdJscQ+tZgZXwyHHkjrAKVCwbL2bHLA/+A1yONSyO fGr2elIuoYpmu8dFX202I1szamijEWT3yklHHsm/jaf68MHZugNFDzkcDJVrahyj0+uuPC X6vIGFhJqaXYcIM9HGPsnrQyeLB+XNyc+xVx9yqsnqoyjyBmojI54u4YFbFjDC6oVs8ipn IlcbcgrTaA+D1uID5/z0iAhRCiMmXswDLYu2POKx4g+Nc9zRnuubZvnHvDCN8g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694682161; a=rsa-sha256; cv=none; b=pPZ0n8BFf6WQ9SgIUb6Zp4YZirkZXe3vz7AmsevACITs5UDhFBw/FhVl6s55Mq58x3uDOn uZ4OXumj1vXRiP8HFdIqI0CKH5REw+ckJokNc27Qg/NftXp4p+NO17R4FuynCWx3Kc7D5S 5nfUOurrR33+A5yBJhOJRAkiJoJNMVat5AItsRmQPkKh6bAktdHVLXf+U0TPP6sYmzW6CR 6qGMF7Fpm3EzT/lANxDhNf05+xIY3JEwzAvb8uHxE1Y+rdKLaXgMiZNehLDgGmpDZOTay3 1Fize/JfttLjw+YjfsApY7Gdw11I6joYUO1HmjnsdgPFZgbcN7a5n3L/8qVJbw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694682161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4alNtE8l0nJ8kBjJFa/HCbnTyuxi63eaxp5aefSAOqs=; b=Fwtae3PoRUNT+8RSBdYmI8GLIDMK+OvoHm6988GbXU2oJW0KcfIloCaZzf05uJDA9qgLiV SCt6Wy3EsY1caBnAD9Yf3xalFirtzefMhwPeJpZhfIg81GbjnnzucocmpSnF5mEltQQOhE nKojWsMT/nLf6g0zxyV9bEpN9syuRAWrX3XZhMm5PsZhb0b49MZxVUm4NvDD8RE3ic8hUx R8WpKLdvF8Saa8O7tzeAHvHNa51afCMmFfWfCFvAK1aB3NS7yGJdN0LX9yQqotoZ8XcyE4 oUjs+aA+fA9iC1L7GFFeSZTIcz/M9PgFgq2YAqKOUbud0GPwFAqLJBmXtVa8Iw== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RmWYY0pkYz1L5W; Thu, 14 Sep 2023 09:02:41 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 8881C77E8; Thu, 14 Sep 2023 11:02:39 +0200 (CEST) From: Kristof Provost To: Mark Millard Cc: Current FreeBSD Subject: Re: git: 8d49fd7331bc - main - pf: remove DIOCGETRULE and DIOCGETSTATUS : net/py-libdnet and net/scapy now broken, kyua test suite damaged Date: Thu, 14 Sep 2023 10:02:38 +0100 X-Mailer: MailMate (1.14r5937) Message-ID: <9A0C699C-78DA-4EB9-945D-A7C3B29EF31D@FreeBSD.org> In-Reply-To: <86F9198D-5B52-4B59-A44D-DA249643B864@yahoo.com> References: <86F9198D-5B52-4B59-A44D-DA249643B864.ref@yahoo.com> <86F9198D-5B52-4B59-A44D-DA249643B864@yahoo.com> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Mark, On 14 Sep 2023, at 7:37, Mark Millard wrote: > This change leads the port net/py-libdnet to be broken: > > --- fw-pf.lo --- > fw-pf.c:212:22: error: use of undeclared identifier 'DIOCGETRULE' > if (ioctl(fw->fd, DIOCGETRULE, &pcr) =3D=3D 0 && > ^ > fw-pf.c:252:22: error: use of undeclared identifier 'DIOCGETRULE' > if (ioctl(fw->fd, DIOCGETRULE, &pcr) =3D=3D 0 && > ^ > --- intf.lo --- > for (cnt =3D 0; !matched && cnt < (int) entry->intf_alias_num; cnt++) {= > ^ > intf.c:571:2: note: previous statement is here > if (entry->intf_addr.addr_type =3D=3D ADDR_TYPE_IP && > ^ > --- fw-pf.lo --- > fw-pf.c:296:28: error: use of undeclared identifier 'DIOCGETRULE' > if ((ret =3D ioctl(fw->fd, DIOCGETRULE, &pr)) < 0) > ^ > 3 errors generated. > > That leads to: > > [00:00:41] [29] [00:00:26] Finished net/py-libdnet@py39 | py39-libdnet-= 1.13_4: Failed: build > [00:00:42] [29] [00:00:27] Skipping net/scapy@py39 | py39-scapy-2.5.0_1= : Dependent port net/py-libdnet@py39 | py39-libdnet-1.13_4 failed > The commit removed those ioctls because they=E2=80=99ve been superseded b= y newer (nvlist-based) versions. Ports are strongly advised to use libpfctl rather than trying to deal wit= h nvlists themselves. See https://lists.freebsd.org/archives/freebsd-pf/2023-April/000345.html = for an example of what the ports will have to do. It=E2=80=99s generally = a trivial change. Best regards, Kristof